Title: [212884] trunk/LayoutTests
Revision
212884
Author
clo...@igalia.com
Date
2017-02-23 07:54:46 -0800 (Thu, 23 Feb 2017)

Log Message

[GTK] MediaStream and WebRTC layout test gardening

Unreviewed.

* TestExpectations: Clarify some comments.
* platform/gtk/TestExpectations: Unskip most of the MediaStream / WebRTC tests for GTK and mark the expected failures accordingly.
* platform/gtk/fast/mediastream/RTCPeerConnection-more-media-to-negotiate-expected.txt: Removed. The test passes on GTK with the
general test expectation.

Modified Paths

Removed Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (212883 => 212884)


--- trunk/LayoutTests/ChangeLog	2017-02-23 15:13:16 UTC (rev 212883)
+++ trunk/LayoutTests/ChangeLog	2017-02-23 15:54:46 UTC (rev 212884)
@@ -1,3 +1,14 @@
+2017-02-23  Carlos Alberto Lopez Perez  <clo...@igalia.com>
+
+        [GTK] MediaStream and WebRTC layout test gardening
+
+        Unreviewed.
+
+        * TestExpectations: Clarify some comments.
+        * platform/gtk/TestExpectations: Unskip most of the MediaStream / WebRTC tests for GTK and mark the expected failures accordingly.
+        * platform/gtk/fast/mediastream/RTCPeerConnection-more-media-to-negotiate-expected.txt: Removed. The test passes on GTK with the
+        general test expectation.
+
 2017-02-23  Tomas Popela  <tpop...@redhat.com>
 
         [GTK] Drag and drop is always moving the content even if copy is requested

Modified: trunk/LayoutTests/TestExpectations (212883 => 212884)


--- trunk/LayoutTests/TestExpectations	2017-02-23 15:13:16 UTC (rev 212883)
+++ trunk/LayoutTests/TestExpectations	2017-02-23 15:54:46 UTC (rev 212884)
@@ -687,7 +687,8 @@
 # Media Sessions is not yet enabled by default: ENABLE(MEDIA_SESSION)
 media/session [ Skip ]
 
-# WebRTC backend not enabled by default.
+# WebRTC backend not enabled by default on Mac/iOS.
+# GTK enables some of this tests on their TestExpectations file.
 webrtc [ Skip ]
 fast/mediastream/getUserMedia-webaudio.html [ Skip ]
 fast/mediastream/RTCPeerConnection-AddRemoveStream.html [ Skip ]

Modified: trunk/LayoutTests/platform/gtk/TestExpectations (212883 => 212884)


--- trunk/LayoutTests/platform/gtk/TestExpectations	2017-02-23 15:13:16 UTC (rev 212883)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2017-02-23 15:54:46 UTC (rev 212884)
@@ -322,7 +322,22 @@
 webkit.org/b/85211 ietestcenter/css3/flexbox/flexbox-align-stretch-001.htm [ ImageOnlyFailure ]
 webkit.org/b/85212 ietestcenter/css3/flexbox/flexbox-layout-002.htm [ ImageOnlyFailure ]
 
-# Mediastream implementation is not complete yet.
+# WebRTC / MediaStream implementation is not complete yet.
+# Some of this tests are skipped on the general TestExpectations,
+# Enable them here and list the individual expectations in order to get
+# notifications of new failures.
+fast/mediastream [ Pass ]
+webrtc [ Pass ]
+# GTK uses OWR instead of libwebrtc
+webrtc/libwebrtc [ Skip ]
+# Some WebRTC features like datachannel are still not implemented
+webrtc/datachannel/basic.html [ Timeout ]
+webrtc/no-port-zero-in-upd-candidates.html [ Timeout ]
+webrtc/video-disabled-black.html [ Failure ]
+webrtc/video.html [ Failure ]
+# The MediaStream implementation is also still not completed
+webkit.org/b/79203 fast/mediastream/mock-media-source-webaudio.html [ Timeout ]
+webkit.org/b/79203 fast/mediastream/getUserMedia-webaudio.html [ Failure ]
 webkit.org/b/79203 fast/mediastream/MediaStream-video-element.html [ Failure ]
 webkit.org/b/79203 fast/mediastream/mock-media-source.html [ Failure ]
 webkit.org/b/79203 fast/mediastream/MediaStream-video-element-track-stop.html [ Timeout ]
@@ -333,6 +348,7 @@
 webkit.org/b/79203 fast/mediastream/RTCPeerConnection-ice.html [ Timeout ]
 webkit.org/b/79203 fast/mediastream/RTCPeerConnection-stats.html [ Failure ]
 webkit.org/b/79203 fast/mediastream/RTCPeerConnection-statsSelector.html [ Failure ]
+webkit.org/b/79203 fast/mediastream/RTCPeerConnection-remotely-assigned-transceiver-mid.html [ Timeout Pass ]
 webkit.org/b/79203 webaudio/mediastreamaudiosourcenode.html [ Failure ]
 webkit.org/b/151344 fast/mediastream/MediaStream-add-ended-tracks.html [ Timeout ]
 webkit.org/b/151344 fast/mediastream/MediaStream-add-remove-tracks.html [ Failure ]
@@ -339,14 +355,8 @@
 webkit.org/b/160996 fast/mediastream/MediaStream-video-element-video-tracks-disabled-then-enabled.html [ Timeout ]
 webkit.org/b/160996 fast/mediastream/MediaStream-video-element-video-tracks-disabled.html [ ImageOnlyFailure ]
 webkit.org/b/161956 fast/mediastream/MediaStream-video-element-displays-buffer.html [ Failure ]
+webkit.org/b/168773 fast/mediastream/MediaStream-MediaElement-setObject-null.html [ Failure ]
 
-# Test skipped in the main expectation file.
-fast/mediastream/RTCPeerConnection-AddRemoveStream.html [ Pass ]
-fast/mediastream/RTCPeerConnection-closed-state.html [ Pass ]
-fast/mediastream/RTCPeerConnection-iceconnectionstatechange-event.html [ Pass ]
-fast/mediastream/RTCPeerConnection-onnegotiationneeded.html [ Pass ]
-fast/mediastream/RTCPeerConnection-overloaded-operations-params.html [ Pass ]
-fast/mediastream/RTCRtpSender-replaceTrack.html [ Pass ]
 
 # Proximity Events is not supported.
 webkit.org/b/99060 proximity [ Failure ]
@@ -2852,7 +2862,6 @@
 webkit.org/b/168370 accessibility/hidden-th-still-column-header.html [ Failure ]
 webkit.org/b/168370 accessibility/selected-text-range-aria-elements.html [ Failure ]
 
-webkit.org/b/168373 fast/mediastream/MediaStream-MediaElement-setObject-null.html [ Failure ]
 webkit.org/b/168373 fullscreen/video-controls-rtl.html [ Failure ]
 webkit.org/b/168373 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/readyState_during_canplaythrough.html [ Failure ]
 webkit.org/b/168373 media/media-preload-no-delay-loadevent.html [ Failure ]
@@ -2901,11 +2910,6 @@
 webkit.org/b/168572 intersection-observer/intersection-observer-entry-interface.html [ Failure ]
 webkit.org/b/168572 js/dom/regress-157246.html [ Failure ]
 
-webkit.org/b/168647 fast/mediastream/RTCPeerConnection-more-media-to-negotiate.html [ Failure ]
-webkit.org/b/168647 imported/w3c/web-platform-tests/webrtc/datachannel-emptystring.html [ Failure ]
-webkit.org/b/168647 imported/w3c/web-platform-tests/webrtc/no-media-call.html [ Failure ]
-webkit.org/b/168647 imported/w3c/web-platform-tests/webrtc/promises-call.html [ Failure ]
-
 webkit.org/b/168719 fast/css/paint-order-shadow.html [ ImageOnlyFailure ]
 
 #////////////////////////////////////////////////////////////////////////////////////////

Deleted: trunk/LayoutTests/platform/gtk/fast/mediastream/RTCPeerConnection-more-media-to-negotiate-expected.txt (212883 => 212884)


--- trunk/LayoutTests/platform/gtk/fast/mediastream/RTCPeerConnection-more-media-to-negotiate-expected.txt	2017-02-23 15:13:16 UTC (rev 212883)
+++ trunk/LayoutTests/platform/gtk/fast/mediastream/RTCPeerConnection-more-media-to-negotiate-expected.txt	2017-02-23 15:54:46 UTC (rev 212884)
@@ -1,26 +0,0 @@
-Test that a negotiationneeded event is fired when not all local media can be included in an answer
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS pc.signalingState is 'stable'
-Add local audio and video tracks to pc
-pc.addTrack(stream.getAudioTracks()[0], stream)
-pc.addTrack(stream.getVideoTracks()[0], stream)
-PASS pc.getTransceivers().length is 2
-PASS negotiationneededevent fired: There is local media added with addTrack
-
-Register a new handler for the negotiationneededevent
-PASS remotePc.getTransceivers().length is 1
-Create a remote offer with audio only
-Set remote offer as remote description
-PASS Remote offer set
-PASS pc.getTransceivers().length is 2
-Create an answer for the audio only offer
-Set answer as local description
-PASS negotiationneededevent fired: There is local media not negotiated that needs to be negotiated in a follow-up offer
-PASS Answer set
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to