Title: [213018] trunk/Source/WebKit/mac
- Revision
- 213018
- Author
- a...@apple.com
- Date
- 2017-02-26 16:17:34 -0800 (Sun, 26 Feb 2017)
Log Message
Don't import RetainPtr in WebNotification.h
https://bugs.webkit.org/show_bug.cgi?id=168876
Reviewed by Dan Bernstein.
This is an Objective-C SPI header.
* WebView/WebNotification.h:
* WebView/WebNotification.mm:
(-[WebNotification initWithCoreNotification:notificationID:]):
(-[WebNotification dealloc]):
Modified Paths
Diff
Modified: trunk/Source/WebKit/mac/ChangeLog (213017 => 213018)
--- trunk/Source/WebKit/mac/ChangeLog 2017-02-27 00:16:50 UTC (rev 213017)
+++ trunk/Source/WebKit/mac/ChangeLog 2017-02-27 00:17:34 UTC (rev 213018)
@@ -1,3 +1,17 @@
+2017-02-26 Alexey Proskuryakov <a...@apple.com>
+
+ Don't import RetainPtr in WebNotification.h
+ https://bugs.webkit.org/show_bug.cgi?id=168876
+
+ Reviewed by Dan Bernstein.
+
+ This is an Objective-C SPI header.
+
+ * WebView/WebNotification.h:
+ * WebView/WebNotification.mm:
+ (-[WebNotification initWithCoreNotification:notificationID:]):
+ (-[WebNotification dealloc]):
+
2017-02-26 Aakash Jain <aakash_j...@apple.com>
Simplify EXPORTED_SYMBOLS_FILE variables in WebKitLegacy.xcconfig
Modified: trunk/Source/WebKit/mac/WebView/WebNotification.h (213017 => 213018)
--- trunk/Source/WebKit/mac/WebView/WebNotification.h 2017-02-27 00:16:50 UTC (rev 213017)
+++ trunk/Source/WebKit/mac/WebView/WebNotification.h 2017-02-27 00:17:34 UTC (rev 213018)
@@ -26,14 +26,12 @@
* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-#include <wtf/RetainPtr.h>
-
@class WebNotificationPrivate;
@class WebSecurityOrigin;
@interface WebNotification : NSObject
{
- RetainPtr<WebNotificationPrivate> _private;
+ WebNotificationPrivate *_private;
}
- (NSString *)title;
Modified: trunk/Source/WebKit/mac/WebView/WebNotification.mm (213017 => 213018)
--- trunk/Source/WebKit/mac/WebView/WebNotification.mm 2017-02-27 00:16:50 UTC (rev 213017)
+++ trunk/Source/WebKit/mac/WebView/WebNotification.mm 2017-02-27 00:17:34 UTC (rev 213018)
@@ -65,7 +65,7 @@
{
if (!(self = [super init]))
return nil;
- _private = adoptNS([[WebNotificationPrivate alloc] init]);
+ _private = [[WebNotificationPrivate alloc] init];
_private->_internal = coreNotification;
_private->_notificationID = notificationID;
return self;
@@ -79,6 +79,12 @@
return nil;
}
+- (void)dealloc
+{
+ [_private release];
+ [super dealloc];
+}
+
- (NSString *)title
{
#if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
