Title: [213291] trunk/LayoutTests
- Revision
- 213291
- Author
- commit-qu...@webkit.org
- Date
- 2017-03-02 10:42:16 -0800 (Thu, 02 Mar 2017)
Log Message
LayoutTest media/modern-media-controls/pip-support/pip-support-click.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=168658
<rdar://problem/30799251>
Patch by Antoine Quint <grao...@apple.com> on 2017-03-02
Reviewed by Dean Jackson.
Use an asynchronous assertion to determine when the PiP button has been sized and can thus be clicked.
* media/modern-media-controls/pip-support/pip-support-click-expected.txt:
* media/modern-media-controls/pip-support/pip-support-click.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (213290 => 213291)
--- trunk/LayoutTests/ChangeLog 2017-03-02 18:38:29 UTC (rev 213290)
+++ trunk/LayoutTests/ChangeLog 2017-03-02 18:42:16 UTC (rev 213291)
@@ -1,3 +1,16 @@
+2017-03-02 Antoine Quint <grao...@apple.com>
+
+ LayoutTest media/modern-media-controls/pip-support/pip-support-click.html is a flaky timeout
+ https://bugs.webkit.org/show_bug.cgi?id=168658
+ <rdar://problem/30799251>
+
+ Reviewed by Dean Jackson.
+
+ Use an asynchronous assertion to determine when the PiP button has been sized and can thus be clicked.
+
+ * media/modern-media-controls/pip-support/pip-support-click-expected.txt:
+ * media/modern-media-controls/pip-support/pip-support-click.html:
+
2017-03-02 Ryan Haddad <ryanhad...@apple.com>
Land TestExpectations for rdar://problem/30735372.
Modified: trunk/LayoutTests/media/modern-media-controls/pip-support/pip-support-click-expected.txt (213290 => 213291)
--- trunk/LayoutTests/media/modern-media-controls/pip-support/pip-support-click-expected.txt 2017-03-02 18:38:29 UTC (rev 213290)
+++ trunk/LayoutTests/media/modern-media-controls/pip-support/pip-support-click-expected.txt 2017-03-02 18:42:16 UTC (rev 213291)
@@ -3,6 +3,7 @@
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+PASS mediaController.controls.pipButton.element.getBoundingClientRect().width became different from 0
PASS media.webkitPresentationMode is "picture-in-picture"
PASS successfullyParsed is true
Modified: trunk/LayoutTests/media/modern-media-controls/pip-support/pip-support-click.html (213290 => 213291)
--- trunk/LayoutTests/media/modern-media-controls/pip-support/pip-support-click.html 2017-03-02 18:38:29 UTC (rev 213290)
+++ trunk/LayoutTests/media/modern-media-controls/pip-support/pip-support-click.html 2017-03-02 18:42:16 UTC (rev 213291)
@@ -28,19 +28,6 @@
const media = document.querySelector("video");
const mediaController = createControls(container, media, null);
-scheduler.frameDidFire = function() {
- if (media.paused)
- return;
-
- const button = mediaController.controls.pipButton.element;
- if (button.getBoundingClientRect().width === 0)
- return;
-
- media.pause();
- pressOnElement(button);
- scheduler.frameDidFire = null;
-};
-
media.addEventListener("webkitpresentationmodechanged", () => {
shouldBeEqualToString("media.webkitPresentationMode", "picture-in-picture");
@@ -53,6 +40,11 @@
finishMediaControlsTest();
});
+shouldBecomeDifferent("mediaController.controls.pipButton.element.getBoundingClientRect().width", "0", () => {
+ media.pause();
+ pressOnElement(mediaController.controls.pipButton.element);
+});
+
</script>
<script src=""
</body>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
