Modified: trunk/LayoutTests/ChangeLog (213309 => 213310)
--- trunk/LayoutTests/ChangeLog 2017-03-02 22:50:57 UTC (rev 213309)
+++ trunk/LayoutTests/ChangeLog 2017-03-02 23:39:40 UTC (rev 213310)
@@ -1,3 +1,14 @@
+2017-03-02 Youenn Fablet <you...@apple.com>
+
+ Activate some new webrtc tests
+ https://bugs.webkit.org/show_bug.cgi?id=168850
+
+ Reviewed by Alex Christensen.
+
+ * TestExpectations: Marking webrtc/audio-peer-connection-webaudio.html as failing.
+ * webrtc/audio-peer-connection-webaudio.html: Making test nicer when failing.
+ * webrtc/datachannel/basic-expected.txt: Updated test expectation.
+
2017-03-02 Dave Hyatt <hy...@apple.com>
flex-basis should be 0% (not 0px) when omitted
Modified: trunk/LayoutTests/TestExpectations (213309 => 213310)
--- trunk/LayoutTests/TestExpectations 2017-03-02 22:50:57 UTC (rev 213309)
+++ trunk/LayoutTests/TestExpectations 2017-03-02 23:39:40 UTC (rev 213310)
@@ -691,6 +691,8 @@
# WebRTC backend not enabled by default on Mac/iOS release bots.
# GTK enables some of this tests on their TestExpectations file.
[ Release ] webrtc [ Skip ]
+
+webrtc/audio-peer-connection-webaudio.html [ Failure ]
fast/mediastream/getUserMedia-webaudio.html [ Skip ]
fast/mediastream/RTCPeerConnection-AddRemoveStream.html [ Skip ]
fast/mediastream/RTCPeerConnection-closed-state.html [ Skip ]
Modified: trunk/LayoutTests/webrtc/audio-peer-connection-webaudio.html (213309 => 213310)
--- trunk/LayoutTests/webrtc/audio-peer-connection-webaudio.html 2017-03-02 22:50:57 UTC (rev 213309)
+++ trunk/LayoutTests/webrtc/audio-peer-connection-webaudio.html 2017-03-02 23:39:40 UTC (rev 213310)
@@ -8,9 +8,6 @@
<script src =""
<script>
var test = async_test(() => {
- if (window.internals)
- internals.useMockRTCPeerConnectionFactory("TwoRealPeerConnections");
-
if (window.testRunner)
testRunner.setUserMediaPermission(true);
@@ -19,10 +16,13 @@
var heardBip = false;
navigator.mediaDevices.getUserMedia({audio: true}).then((stream) => {
+ if (window.internals)
+ internals.useMockRTCPeerConnectionFactory("TwoRealPeerConnections");
+
createConnections((firstConnection) => {
firstConnection.addStream(stream);
}, (secondConnection) => {
- secondConnection._onaddstream_ = (streamEvent) => {
+ secondConnection._onaddstream_ = (streamEvent) => {
var context = new webkitAudioContext();
var sourceNode = context.createMediaStreamSource(streamEvent.stream);
var analyser = context.createAnalyser();
@@ -60,15 +60,15 @@
done();
};
- var done = () => {
+ var done = test.step_func_done(() => {
clearTimeout(timeout);
clearInterval(interval);
- assert_true(heardHum);
- assert_true(heardBip);
- assert_true(heardBop);
+ assert_true(heardHum, "heard hum");
+ assert_true(heardBip, "heard bip");
+ assert_true(heardBop, "heard bop");
test.done();
- };
+ };);
var timeout = setTimeout(done, 3000);
var interval = setInterval(analyse, 1000 / 30);
Modified: trunk/LayoutTests/webrtc/datachannel/basic-expected.txt (213309 => 213310)
--- trunk/LayoutTests/webrtc/datachannel/basic-expected.txt 2017-03-02 22:50:57 UTC (rev 213309)
+++ trunk/LayoutTests/webrtc/datachannel/basic-expected.txt 2017-03-02 23:39:40 UTC (rev 213310)
@@ -1,4 +1,6 @@
PASS Basic data channel exchange from offerer to receiver
PASS Basic data channel exchange from receiver to offerer
+PASS Basic data channel exchange from offerer to receiver using UDP only
+PASS Basic data channel exchange from offerer to receiver using TCP only
Modified: trunk/Source/WebKit2/ChangeLog (213309 => 213310)
--- trunk/Source/WebKit2/ChangeLog 2017-03-02 22:50:57 UTC (rev 213309)
+++ trunk/Source/WebKit2/ChangeLog 2017-03-02 23:39:40 UTC (rev 213310)
@@ -1,3 +1,13 @@
+2017-03-02 Youenn Fablet <you...@apple.com>
+
+ Activate some new webrtc tests
+ https://bugs.webkit.org/show_bug.cgi?id=168850
+
+ Reviewed by Alex Christensen.
+
+ * Shared/WebPreferencesDefinitions.h: Activating peer connection by default when libwebrtc is on.
+ This allows ensuring the network process will have its sandbox extension.
+
2017-03-02 Brian Burg <bb...@apple.com>
Web Automation: _WKAutomationSessionDelegate should work with WKWebViews
Modified: trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h (213309 => 213310)
--- trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h 2017-03-02 22:50:57 UTC (rev 213309)
+++ trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h 2017-03-02 23:39:40 UTC (rev 213310)
@@ -206,7 +206,7 @@
macro(SubpixelCSSOMElementMetricsEnabled, subpixelCSSOMElementMetricsEnabled, Bool, bool, false, "", "") \
macro(UseGiantTiles, useGiantTiles, Bool, bool, false, "", "") \
macro(MediaStreamEnabled, mediaStreamEnabled, Bool, bool, false, "", "") \
- macro(PeerConnectionEnabled, peerConnectionEnabled, Bool, bool, false, "", "") \
+ macro(PeerConnectionEnabled, peerConnectionEnabled, Bool, bool, WebCore::LibWebRTCProvider::webRTCAvailable(), "", "") \
macro(UseLegacyTextAlignPositionedElementBehavior, useLegacyTextAlignPositionedElementBehavior, Bool, bool, false, "", "") \
macro(SpatialNavigationEnabled, spatialNavigationEnabled, Bool, bool, false, "", "") \
macro(MediaSourceEnabled, mediaSourceEnabled, Bool, bool, true, "", "") \
