- Revision
- 213321
- Author
- commit-qu...@webkit.org
- Date
- 2017-03-02 16:10:24 -0800 (Thu, 02 Mar 2017)
Log Message
Add ability to read bindings test results
https://bugs.webkit.org/show_bug.cgi?id=169063
Patch by Srinivasan Vijayaraghavan <svijayaragha...@apple.com> on 2017-03-02
Reviewed by Alexey Proskuryakov.
* Scripts/webkitpy/common/net/bindingstestresults.py: Added.
(BindingsTestResults): Conforms to the AbstractTestResults interface.
(BindingsTestResults.__init__): Constructor.
(BindingsTestResults.results_from_string): Generates BindingsTestResults object from JSON string.
(BindingsTestResults.is_subset): Compare failing tests in two BindingsTestResults objects.
(BindingsTestResults.equals): Checks if two BindingsTestResults objects contain the same failing test names.
(BindingsTestResults.all_passed): Return True if all bindings tests passed.
(BindingsTestResults.failing_tests): Returns a list of failing tests.
(BindingsTestResults.did_exceed_test_failure_limit): Always returns False, exists to conform to the interface.
* Scripts/webkitpy/common/net/bindingstestresults_unittest.py: Added.
(BindingsTestResultsTest): Class to test BindingsTestResults.
(BindingsTestResultsTest.test_results_from_string): Unit tests string -> BindingsTestResults conversion.
(BindingsTestResultsTest.test_results_from_string_success): Ditto, for success cases.
* Scripts/webkitpy/tool/bot/bindingstestresultsreader.py: Added.
(BindingsTestResultsReader): Conforms to the AbstractTestResultsReader interface.
(BindingsTestResultsReader.results): Reads the results file and returns a BindingsTestResults object.
Modified Paths
Added Paths
Diff
Modified: trunk/Tools/ChangeLog (213320 => 213321)
--- trunk/Tools/ChangeLog 2017-03-03 00:01:22 UTC (rev 213320)
+++ trunk/Tools/ChangeLog 2017-03-03 00:10:24 UTC (rev 213321)
@@ -1,3 +1,27 @@
+2017-03-02 Srinivasan Vijayaraghavan <svijayaragha...@apple.com>
+
+ Add ability to read bindings test results
+ https://bugs.webkit.org/show_bug.cgi?id=169063
+
+ Reviewed by Alexey Proskuryakov.
+
+ * Scripts/webkitpy/common/net/bindingstestresults.py: Added.
+ (BindingsTestResults): Conforms to the AbstractTestResults interface.
+ (BindingsTestResults.__init__): Constructor.
+ (BindingsTestResults.results_from_string): Generates BindingsTestResults object from JSON string.
+ (BindingsTestResults.is_subset): Compare failing tests in two BindingsTestResults objects.
+ (BindingsTestResults.equals): Checks if two BindingsTestResults objects contain the same failing test names.
+ (BindingsTestResults.all_passed): Return True if all bindings tests passed.
+ (BindingsTestResults.failing_tests): Returns a list of failing tests.
+ (BindingsTestResults.did_exceed_test_failure_limit): Always returns False, exists to conform to the interface.
+ * Scripts/webkitpy/common/net/bindingstestresults_unittest.py: Added.
+ (BindingsTestResultsTest): Class to test BindingsTestResults.
+ (BindingsTestResultsTest.test_results_from_string): Unit tests string -> BindingsTestResults conversion.
+ (BindingsTestResultsTest.test_results_from_string_success): Ditto, for success cases.
+ * Scripts/webkitpy/tool/bot/bindingstestresultsreader.py: Added.
+ (BindingsTestResultsReader): Conforms to the AbstractTestResultsReader interface.
+ (BindingsTestResultsReader.results): Reads the results file and returns a BindingsTestResults object.
+
2017-03-02 Aakash Jain <aakash_j...@apple.com>
Move stringMatchesWildcardString from WebKit2 to WebCore
Added: trunk/Tools/Scripts/webkitpy/common/net/bindingstestresults.py (0 => 213321)
--- trunk/Tools/Scripts/webkitpy/common/net/bindingstestresults.py (rev 0)
+++ trunk/Tools/Scripts/webkitpy/common/net/bindingstestresults.py 2017-03-03 00:10:24 UTC (rev 213321)
@@ -0,0 +1,62 @@
+# Copyright (C) 2017 Apple Inc. All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions
+# are met:
+# 1. Redistributions of source code must retain the above copyright
+# notice, this list of conditions and the following disclaimer.
+# 2. Redistributions in binary form must reproduce the above copyright
+# notice, this list of conditions and the following disclaimer in the
+# documentation and/or other materials provided with the distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND
+# ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+# DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR
+# ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+# CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+import logging
+
+from webkitpy.common.net.abstracttestresults import AbstractTestResults
+
+_log = logging.getLogger(__name__)
+
+
+class BindingsTestResults(AbstractTestResults):
+ def __init__(self, failures, errors):
+ self._failures = failures
+ self._errors = errors
+
+ self._failing_test_names = failures + errors
+
+ @classmethod
+ def results_from_string(cls, string):
+ parsed_results = cls.parse_json_string(string)
+ if not parsed_results:
+ return None
+
+ if 'failures' not in parsed_results or 'errors' not in parsed_results:
+ return None
+
+ return cls(parsed_results['failures'], parsed_results['errors'])
+
+ def is_subset(self, other):
+ return set(self._failures) <= set(other._failures) and set(self._errors) <= set(other._errors)
+
+ def equals(self, other):
+ return set(self._failures) == set(other._failures) and set(self._errors) == set(other._errors)
+
+ def all_passed(self):
+ return not self._failures and not self._errors
+
+ def failing_tests(self):
+ return self._failing_test_names
+
+ # No defined failure limit for bindings tests.
+ def did_exceed_test_failure_limit(self):
+ return False
Added: trunk/Tools/Scripts/webkitpy/common/net/bindingstestresults_unittest.py (0 => 213321)
--- trunk/Tools/Scripts/webkitpy/common/net/bindingstestresults_unittest.py (rev 0)
+++ trunk/Tools/Scripts/webkitpy/common/net/bindingstestresults_unittest.py 2017-03-03 00:10:24 UTC (rev 213321)
@@ -0,0 +1,43 @@
+# Copyright (C) 2017 Apple Inc. All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions
+# are met:
+# 1. Redistributions of source code must retain the above copyright
+# notice, this list of conditions and the following disclaimer.
+# 2. Redistributions in binary form must reproduce the above copyright
+# notice, this list of conditions and the following disclaimer in the
+# documentation and/or other materials provided with the distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND
+# ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+# DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR
+# ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+# CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+import unittest
+
+from webkitpy.common.net.bindingstestresults import BindingsTestResults
+
+
+class BindingsTestResultsTest(unittest.TestCase):
+ def test_results_from_string(self):
+ incomplete_json_v1 = '{"failures": []}'
+ incomplete_json_v2 = '{"errors":[]}'
+ self.assertEqual(None, BindingsTestResults.results_from_string(incomplete_json_v1))
+ self.assertEqual(None, BindingsTestResults.results_from_string(incomplete_json_v2))
+
+ def test_results_from_string_success(self):
+ no_failures_string = '{"failures": [], "errors":[]}'
+ no_failures_results = BindingsTestResults([], [])
+ self.assertTrue(no_failures_results.equals(BindingsTestResults.results_from_string(no_failures_string)))
+ self.assertTrue(no_failures_results.all_passed())
+
+ test_string = '{"failures": ["failure1"], "errors": ["error1", "error2"]}'
+ test_results = BindingsTestResults(["failure1"], ["error1", "error2"])
+ self.assertTrue(test_results.equals(BindingsTestResults.results_from_string(test_string)))
Added: trunk/Tools/Scripts/webkitpy/tool/bot/bindingstestresultsreader.py (0 => 213321)
--- trunk/Tools/Scripts/webkitpy/tool/bot/bindingstestresultsreader.py (rev 0)
+++ trunk/Tools/Scripts/webkitpy/tool/bot/bindingstestresultsreader.py 2017-03-03 00:10:24 UTC (rev 213321)
@@ -0,0 +1,35 @@
+# Copyright (C) 2017 Apple Inc. All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions
+# are met:
+# 1. Redistributions of source code must retain the above copyright
+# notice, this list of conditions and the following disclaimer.
+# 2. Redistributions in binary form must reproduce the above copyright
+# notice, this list of conditions and the following disclaimer in the
+# documentation and/or other materials provided with the distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND
+# ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+# DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR
+# ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+# CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+import logging
+
+from webkitpy.common.net.bindingstestresults import BindingsTestResults
+from webkitpy.tool.bot.abstracttestresultsreader import AbstractTestResultsReader
+
+_log = logging.getLogger(__name__)
+
+
+class BindingsTestResultsReader(AbstractTestResultsReader):
+ def results(self):
+ results_path = self._host.filesystem.join(self._results_directory, 'bindings_test_results.json')
+ contents = self._read_file_contents(results_path)
+ return BindingsTestResults.results_from_string(contents)
