Title: [213915] trunk/Source/WebKit2
- Revision
- 213915
- Author
- [email protected]
- Date
- 2017-03-14 10:39:27 -0700 (Tue, 14 Mar 2017)
Log Message
Fix uninitialized public members in NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=169598
Reviewed by Alex Christensen.
* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::NetworkProcess):
* NetworkProcess/NetworkProcessCreationParameters.h:
* NetworkProcess/cache/NetworkCacheStorage.cpp:
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::WebProcessPool):
* UIProcess/soup/WebProcessPoolSoup.cpp:
(WebKit::WebProcessPool::platformInitializeNetworkProcess):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (213914 => 213915)
--- trunk/Source/WebKit2/ChangeLog 2017-03-14 17:30:19 UTC (rev 213914)
+++ trunk/Source/WebKit2/ChangeLog 2017-03-14 17:39:27 UTC (rev 213915)
@@ -1,3 +1,19 @@
+2017-03-14 Tomas Popela <[email protected]>
+
+ Fix uninitialized public members in NetworkProcess
+ https://bugs.webkit.org/show_bug.cgi?id=169598
+
+ Reviewed by Alex Christensen.
+
+ * NetworkProcess/NetworkProcess.cpp:
+ (WebKit::NetworkProcess::NetworkProcess):
+ * NetworkProcess/NetworkProcessCreationParameters.h:
+ * NetworkProcess/cache/NetworkCacheStorage.cpp:
+ * UIProcess/WebProcessPool.cpp:
+ (WebKit::WebProcessPool::WebProcessPool):
+ * UIProcess/soup/WebProcessPoolSoup.cpp:
+ (WebKit::WebProcessPool::platformInitializeNetworkProcess):
+
2017-03-10 Ada Chan <[email protected]>
[Mac] Add API to get the NSURLProtectionSpace from WKProtectionSpaceRef
Modified: trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp (213914 => 213915)
--- trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp 2017-03-14 17:30:19 UTC (rev 213914)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp 2017-03-14 17:39:27 UTC (rev 213915)
@@ -97,7 +97,6 @@
: m_hasSetCacheModel(false)
, m_cacheModel(CacheModelDocumentViewer)
, m_diskCacheIsDisabledForTesting(false)
- , m_canHandleHTTPSServerTrustEvaluation(true)
#if PLATFORM(COCOA)
, m_clearCacheDispatchGroup(0)
#endif
Modified: trunk/Source/WebKit2/NetworkProcess/NetworkProcessCreationParameters.h (213914 => 213915)
--- trunk/Source/WebKit2/NetworkProcess/NetworkProcessCreationParameters.h 2017-03-14 17:30:19 UTC (rev 213914)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkProcessCreationParameters.h 2017-03-14 17:39:27 UTC (rev 213915)
@@ -49,18 +49,18 @@
void encode(IPC::Encoder&) const;
static bool decode(IPC::Decoder&, NetworkProcessCreationParameters&);
- bool privateBrowsingEnabled;
- CacheModel cacheModel;
+ bool privateBrowsingEnabled { false };
+ CacheModel cacheModel { CacheModelDocumentViewer };
int64_t diskCacheSizeOverride { -1 };
- bool canHandleHTTPSServerTrustEvaluation;
+ bool canHandleHTTPSServerTrustEvaluation { true };
String diskCacheDirectory;
SandboxExtension::Handle diskCacheDirectoryExtensionHandle;
#if ENABLE(NETWORK_CACHE)
- bool shouldEnableNetworkCache;
- bool shouldEnableNetworkCacheEfficacyLogging;
+ bool shouldEnableNetworkCache { false };
+ bool shouldEnableNetworkCacheEfficacyLogging { false };
#if ENABLE(NETWORK_CACHE_SPECULATIVE_REVALIDATION)
- bool shouldEnableNetworkCacheSpeculativeRevalidation;
+ bool shouldEnableNetworkCacheSpeculativeRevalidation { false };
#endif
#endif
#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101100
@@ -72,7 +72,7 @@
SandboxExtension::Handle parentBundleDirectoryExtensionHandle;
#endif
bool shouldSuppressMemoryPressureHandler { false };
- bool shouldUseTestingNetworkSession;
+ bool shouldUseTestingNetworkSession { false };
std::chrono::milliseconds loadThrottleLatency { 0ms };
Vector<String> urlSchemesRegisteredForCustomProtocols;
@@ -98,9 +98,9 @@
#if USE(SOUP)
String cookiePersistentStoragePath;
- uint32_t cookiePersistentStorageType;
- HTTPCookieAcceptPolicy cookieAcceptPolicy;
- bool ignoreTLSErrors;
+ uint32_t cookiePersistentStorageType { 0 };
+ HTTPCookieAcceptPolicy cookieAcceptPolicy { 0 };
+ bool ignoreTLSErrors { true };
Vector<String> languages;
WebCore::SoupNetworkProxySettings proxySettings;
#endif
Modified: trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp (213914 => 213915)
--- trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp 2017-03-14 17:30:19 UTC (rev 213914)
+++ trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp 2017-03-14 17:39:27 UTC (rev 213915)
@@ -367,13 +367,13 @@
Key key;
std::chrono::system_clock::time_point timeStamp;
SHA1::Digest headerHash;
- uint64_t headerSize;
+ uint64_t headerSize { 0 };
SHA1::Digest bodyHash;
- uint64_t bodySize;
- bool isBodyInline;
+ uint64_t bodySize { 0 };
+ bool isBodyInline { false };
// Not encoded as a field. Header starts immediately after meta data.
- uint64_t headerOffset;
+ uint64_t headerOffset { 0 };
};
static bool decodeRecordMetaData(RecordMetaData& metaData, const Data& fileData)
Modified: trunk/Source/WebKit2/UIProcess/WebProcessPool.cpp (213914 => 213915)
--- trunk/Source/WebKit2/UIProcess/WebProcessPool.cpp 2017-03-14 17:30:19 UTC (rev 213914)
+++ trunk/Source/WebKit2/UIProcess/WebProcessPool.cpp 2017-03-14 17:39:27 UTC (rev 213915)
@@ -180,7 +180,6 @@
#endif
, m_shouldUseTestingNetworkSession(false)
, m_processTerminationEnabled(true)
- , m_canHandleHTTPSServerTrustEvaluation(true)
, m_didNetworkProcessCrash(false)
, m_memoryCacheDisabled(false)
, m_alwaysRunsAtBackgroundPriority(m_configuration->alwaysRunsAtBackgroundPriority())
Modified: trunk/Source/WebKit2/UIProcess/soup/WebProcessPoolSoup.cpp (213914 => 213915)
--- trunk/Source/WebKit2/UIProcess/soup/WebProcessPoolSoup.cpp 2017-03-14 17:30:19 UTC (rev 213914)
+++ trunk/Source/WebKit2/UIProcess/soup/WebProcessPoolSoup.cpp 2017-03-14 17:39:27 UTC (rev 213915)
@@ -42,7 +42,6 @@
parameters.cookieAcceptPolicy = m_initialHTTPCookieAcceptPolicy;
parameters.ignoreTLSErrors = m_ignoreTLSErrors;
parameters.languages = WebCore::userPreferredLanguages();
- parameters.shouldEnableNetworkCacheEfficacyLogging = false;
parameters.proxySettings = m_networkProxySettings;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
