Title: [213923] trunk/Source/WebCore
- Revision
- 213923
- Author
- commit-qu...@webkit.org
- Date
- 2017-03-14 11:53:32 -0700 (Tue, 14 Mar 2017)
Log Message
Remove redundant check for "firstLine" in RenderBlock::lineHeight()
https://bugs.webkit.org/show_bug.cgi?id=169610
Patch by Adrian Perez de Castro <ape...@igalia.com> on 2017-03-14
Reviewed by Michael Catanzaro.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::lineHeight): Remove test of "firstLine" that
was already checked in the condition for the enclosing if-clause.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (213922 => 213923)
--- trunk/Source/WebCore/ChangeLog 2017-03-14 18:36:22 UTC (rev 213922)
+++ trunk/Source/WebCore/ChangeLog 2017-03-14 18:53:32 UTC (rev 213923)
@@ -1,3 +1,14 @@
+2017-03-14 Adrian Perez de Castro <ape...@igalia.com>
+
+ Remove redundant check for "firstLine" in RenderBlock::lineHeight()
+ https://bugs.webkit.org/show_bug.cgi?id=169610
+
+ Reviewed by Michael Catanzaro.
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::lineHeight): Remove test of "firstLine" that
+ was already checked in the condition for the enclosing if-clause.
+
2017-03-14 Antoine Quint <grao...@apple.com>
[Modern Media Controls] Fullscreen controls during Live Broadcast is completely broken
Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (213922 => 213923)
--- trunk/Source/WebCore/rendering/RenderBlock.cpp 2017-03-14 18:36:22 UTC (rev 213922)
+++ trunk/Source/WebCore/rendering/RenderBlock.cpp 2017-03-14 18:53:32 UTC (rev 213923)
@@ -2943,7 +2943,7 @@
return RenderBox::lineHeight(firstLine, direction, linePositionMode);
if (firstLine && view().usesFirstLineRules()) {
- auto& s = firstLine ? firstLineStyle() : style();
+ auto& s = firstLineStyle();
if (&s != &style())
return s.computedLineHeight();
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
