Title: [213927] trunk/Source/WebKit2
- Revision
- 213927
- Author
- ryanhad...@apple.com
- Date
- 2017-03-14 12:16:43 -0700 (Tue, 14 Mar 2017)
Log Message
Unreviewed, rolling out r213915.
Caused WK2 LayoutTests to exit early with timeouts.
Reverted changeset:
"Fix uninitialized public members in NetworkProcess"
https://bugs.webkit.org/show_bug.cgi?id=169598
http://trac.webkit.org/changeset/213915
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (213926 => 213927)
--- trunk/Source/WebKit2/ChangeLog 2017-03-14 19:16:36 UTC (rev 213926)
+++ trunk/Source/WebKit2/ChangeLog 2017-03-14 19:16:43 UTC (rev 213927)
@@ -1,3 +1,15 @@
+2017-03-14 Ryan Haddad <ryanhad...@apple.com>
+
+ Unreviewed, rolling out r213915.
+
+ Caused WK2 LayoutTests to exit early with timeouts.
+
+ Reverted changeset:
+
+ "Fix uninitialized public members in NetworkProcess"
+ https://bugs.webkit.org/show_bug.cgi?id=169598
+ http://trac.webkit.org/changeset/213915
+
2017-03-14 Brady Eidson <beid...@apple.com>
REGRESSION (r213877): WebKit2.CookieManager fails.
Modified: trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp (213926 => 213927)
--- trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp 2017-03-14 19:16:36 UTC (rev 213926)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp 2017-03-14 19:16:43 UTC (rev 213927)
@@ -97,6 +97,7 @@
: m_hasSetCacheModel(false)
, m_cacheModel(CacheModelDocumentViewer)
, m_diskCacheIsDisabledForTesting(false)
+ , m_canHandleHTTPSServerTrustEvaluation(true)
#if PLATFORM(COCOA)
, m_clearCacheDispatchGroup(0)
#endif
Modified: trunk/Source/WebKit2/NetworkProcess/NetworkProcessCreationParameters.h (213926 => 213927)
--- trunk/Source/WebKit2/NetworkProcess/NetworkProcessCreationParameters.h 2017-03-14 19:16:36 UTC (rev 213926)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkProcessCreationParameters.h 2017-03-14 19:16:43 UTC (rev 213927)
@@ -49,18 +49,18 @@
void encode(IPC::Encoder&) const;
static bool decode(IPC::Decoder&, NetworkProcessCreationParameters&);
- bool privateBrowsingEnabled { false };
- CacheModel cacheModel { CacheModelDocumentViewer };
+ bool privateBrowsingEnabled;
+ CacheModel cacheModel;
int64_t diskCacheSizeOverride { -1 };
- bool canHandleHTTPSServerTrustEvaluation { true };
+ bool canHandleHTTPSServerTrustEvaluation;
String diskCacheDirectory;
SandboxExtension::Handle diskCacheDirectoryExtensionHandle;
#if ENABLE(NETWORK_CACHE)
- bool shouldEnableNetworkCache { false };
- bool shouldEnableNetworkCacheEfficacyLogging { false };
+ bool shouldEnableNetworkCache;
+ bool shouldEnableNetworkCacheEfficacyLogging;
#if ENABLE(NETWORK_CACHE_SPECULATIVE_REVALIDATION)
- bool shouldEnableNetworkCacheSpeculativeRevalidation { false };
+ bool shouldEnableNetworkCacheSpeculativeRevalidation;
#endif
#endif
#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101100
@@ -72,7 +72,7 @@
SandboxExtension::Handle parentBundleDirectoryExtensionHandle;
#endif
bool shouldSuppressMemoryPressureHandler { false };
- bool shouldUseTestingNetworkSession { false };
+ bool shouldUseTestingNetworkSession;
std::chrono::milliseconds loadThrottleLatency { 0ms };
Vector<String> urlSchemesRegisteredForCustomProtocols;
@@ -98,9 +98,9 @@
#if USE(SOUP)
String cookiePersistentStoragePath;
- uint32_t cookiePersistentStorageType { 0 };
- HTTPCookieAcceptPolicy cookieAcceptPolicy { 0 };
- bool ignoreTLSErrors { true };
+ uint32_t cookiePersistentStorageType;
+ HTTPCookieAcceptPolicy cookieAcceptPolicy;
+ bool ignoreTLSErrors;
Vector<String> languages;
WebCore::SoupNetworkProxySettings proxySettings;
#endif
Modified: trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp (213926 => 213927)
--- trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp 2017-03-14 19:16:36 UTC (rev 213926)
+++ trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp 2017-03-14 19:16:43 UTC (rev 213927)
@@ -367,13 +367,13 @@
Key key;
std::chrono::system_clock::time_point timeStamp;
SHA1::Digest headerHash;
- uint64_t headerSize { 0 };
+ uint64_t headerSize;
SHA1::Digest bodyHash;
- uint64_t bodySize { 0 };
- bool isBodyInline { false };
+ uint64_t bodySize;
+ bool isBodyInline;
// Not encoded as a field. Header starts immediately after meta data.
- uint64_t headerOffset { 0 };
+ uint64_t headerOffset;
};
static bool decodeRecordMetaData(RecordMetaData& metaData, const Data& fileData)
Modified: trunk/Source/WebKit2/UIProcess/WebProcessPool.cpp (213926 => 213927)
--- trunk/Source/WebKit2/UIProcess/WebProcessPool.cpp 2017-03-14 19:16:36 UTC (rev 213926)
+++ trunk/Source/WebKit2/UIProcess/WebProcessPool.cpp 2017-03-14 19:16:43 UTC (rev 213927)
@@ -180,6 +180,7 @@
#endif
, m_shouldUseTestingNetworkSession(false)
, m_processTerminationEnabled(true)
+ , m_canHandleHTTPSServerTrustEvaluation(true)
, m_didNetworkProcessCrash(false)
, m_memoryCacheDisabled(false)
, m_alwaysRunsAtBackgroundPriority(m_configuration->alwaysRunsAtBackgroundPriority())
Modified: trunk/Source/WebKit2/UIProcess/soup/WebProcessPoolSoup.cpp (213926 => 213927)
--- trunk/Source/WebKit2/UIProcess/soup/WebProcessPoolSoup.cpp 2017-03-14 19:16:36 UTC (rev 213926)
+++ trunk/Source/WebKit2/UIProcess/soup/WebProcessPoolSoup.cpp 2017-03-14 19:16:43 UTC (rev 213927)
@@ -42,6 +42,7 @@
parameters.cookieAcceptPolicy = m_initialHTTPCookieAcceptPolicy;
parameters.ignoreTLSErrors = m_ignoreTLSErrors;
parameters.languages = WebCore::userPreferredLanguages();
+ parameters.shouldEnableNetworkCacheEfficacyLogging = false;
parameters.proxySettings = m_networkProxySettings;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
