Title: [213973] trunk/Source/_javascript_Core
Revision
213973
Author
tpop...@redhat.com
Date
2017-03-14 22:52:08 -0700 (Tue, 14 Mar 2017)

Log Message

Wrong condition in offlineasm/risc.rb
https://bugs.webkit.org/show_bug.cgi?id=169597

Reviewed by Mark Lam.

It's missing the 'and' operator between the conditions.

* offlineasm/risc.rb:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (213972 => 213973)


--- trunk/Source/_javascript_Core/ChangeLog	2017-03-15 05:21:06 UTC (rev 213972)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-03-15 05:52:08 UTC (rev 213973)
@@ -1,3 +1,14 @@
+2017-03-14  Tomas Popela  <tpop...@redhat.com>
+
+        Wrong condition in offlineasm/risc.rb
+        https://bugs.webkit.org/show_bug.cgi?id=169597
+
+        Reviewed by Mark Lam.
+
+        It's missing the 'and' operator between the conditions.
+
+        * offlineasm/risc.rb:
+
 2017-03-14  Mark Lam  <mark....@apple.com>
 
         BytecodeGenerator should use the same function to determine if it needs to store the DerivedConstructor in an ArrowFunction lexical environment.

Modified: trunk/Source/_javascript_Core/offlineasm/risc.rb (213972 => 213973)


--- trunk/Source/_javascript_Core/offlineasm/risc.rb	2017-03-15 05:21:06 UTC (rev 213972)
+++ trunk/Source/_javascript_Core/offlineasm/risc.rb	2017-03-15 05:52:08 UTC (rev 213973)
@@ -374,7 +374,7 @@
             when "addi", "addp", "addq", "addis", "subi", "subp", "subq", "subis"
                 if node.operands[0].is_a? Immediate and
                         (not validImmediates.include? node.operands[0].value) and
-                        validImmediates.include? -node.operands[0].value
+                        validImmediates.include? -node.operands[0].value and
                         node.operands.size == 2
                     if node.opcode =~ /add/
                         newOpcode = "sub" + $~.post_match
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to