Title: [214022] trunk/Source/_javascript_Core
- Revision
- 214022
- Author
- commit-qu...@webkit.org
- Date
- 2017-03-15 18:01:45 -0700 (Wed, 15 Mar 2017)
Log Message
[jsc][mips] Fix compilation error introduced in r213652
https://bugs.webkit.org/show_bug.cgi?id=169723
Patch by Guillaume Emont <guijem...@igalia.com> on 2017-03-15
Reviewed by Mark Lam.
The new replaceWithBkpt() contains a lapsus in it
(s/code/instructionStart) and won't compile.
* assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::replaceWithBkpt):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (214021 => 214022)
--- trunk/Source/_javascript_Core/ChangeLog 2017-03-16 01:01:06 UTC (rev 214021)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-03-16 01:01:45 UTC (rev 214022)
@@ -1,3 +1,16 @@
+2017-03-15 Guillaume Emont <guijem...@igalia.com>
+
+ [jsc][mips] Fix compilation error introduced in r213652
+ https://bugs.webkit.org/show_bug.cgi?id=169723
+
+ Reviewed by Mark Lam.
+
+ The new replaceWithBkpt() contains a lapsus in it
+ (s/code/instructionStart) and won't compile.
+
+ * assembler/MIPSAssembler.h:
+ (JSC::MIPSAssembler::replaceWithBkpt):
+
2017-03-15 Daniel Ehrenberg <little...@chromium.org>
Switch back to ISO 4217 for Intl CurrencyDigits data
Modified: trunk/Source/_javascript_Core/assembler/MIPSAssembler.h (214021 => 214022)
--- trunk/Source/_javascript_Core/assembler/MIPSAssembler.h 2017-03-16 01:01:06 UTC (rev 214021)
+++ trunk/Source/_javascript_Core/assembler/MIPSAssembler.h 2017-03-16 01:01:45 UTC (rev 214022)
@@ -931,7 +931,7 @@
static void replaceWithBkpt(void* instructionStart)
{
ASSERT(!(bitwise_cast<uintptr_t>(instructionStart) & 3));
- MIPSWord* insn = reinterpret_cast<MIPSWord*>(reinterpret_cast<intptr_t>(code));
+ MIPSWord* insn = reinterpret_cast<MIPSWord*>(reinterpret_cast<intptr_t>(instructionStart));
int value = 512; /* BRK_BUG */
insn[0] = (0x0000000d | ((value & 0x3ff) << OP_SH_CODE));
cacheFlush(instructionStart, sizeof(MIPSWord));
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes