Title: [214199] trunk/Source/WebInspectorUI
- Revision
- 214199
- Author
- nvasil...@apple.com
- Date
- 2017-03-20 18:01:22 -0700 (Mon, 20 Mar 2017)
Log Message
Web Inspector: Clicking on Clear Network Items icon throws an exception if timing popover is visible
https://bugs.webkit.org/show_bug.cgi?id=169852
<rdar://problem/31132652>
Reviewed by Joseph Pecoraro.
* UserInterface/Views/ResourceTimelineDataGridNode.js:
(WebInspector.ResourceTimelineDataGridNode.prototype._mouseoverRecordBar):
(WebInspector.ResourceTimelineDataGridNode):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (214198 => 214199)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-03-21 00:46:11 UTC (rev 214198)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-03-21 01:01:22 UTC (rev 214199)
@@ -1,5 +1,17 @@
2017-03-20 Nikita Vasilyev <nvasil...@apple.com>
+ Web Inspector: Clicking on Clear Network Items icon throws an exception if timing popover is visible
+ https://bugs.webkit.org/show_bug.cgi?id=169852
+ <rdar://problem/31132652>
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Views/ResourceTimelineDataGridNode.js:
+ (WebInspector.ResourceTimelineDataGridNode.prototype._mouseoverRecordBar):
+ (WebInspector.ResourceTimelineDataGridNode):
+
+2017-03-20 Nikita Vasilyev <nvasil...@apple.com>
+
REGRESSION (r187873): Web Inspector: When resizing, prevent DataGrid columns from collapsing entirely
https://bugs.webkit.org/show_bug.cgi?id=169899
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ResourceTimelineDataGridNode.js (214198 => 214199)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ResourceTimelineDataGridNode.js 2017-03-21 00:46:11 UTC (rev 214198)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ResourceTimelineDataGridNode.js 2017-03-21 01:01:22 UTC (rev 214199)
@@ -421,7 +421,11 @@
recordBar.element.addEventListener("mouseleave", () => {
if (!this.dataGrid)
return;
- this.dataGrid._dismissPopoverTimeout = setTimeout(() => this.dataGrid._popover.dismiss(), WebInspector.ResourceTimelineDataGridNode.DelayedPopoverDismissalTimeout);
+
+ this.dataGrid._dismissPopoverTimeout = setTimeout(() => {
+ if (this.dataGrid)
+ this.dataGrid._popover.dismiss();
+ }, WebInspector.ResourceTimelineDataGridNode.DelayedPopoverDismissalTimeout);
}, {once: true});
this.dataGrid._popover.presentNewContentWithFrame(popoverContentElement, targetFrame.pad(2), preferredEdges);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
