Title: [214233] trunk/Tools
Revision
214233
Author
aakash_j...@apple.com
Date
2017-03-21 15:33:30 -0700 (Tue, 21 Mar 2017)

Log Message

ews should indicate in logs when it fails to parse_bug_id_from_attachment_page
https://bugs.webkit.org/show_bug.cgi?id=169927

Reviewed by  Alexey Proskuryakov.

* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(Bugzilla._parse_bug_id_from_attachment_page): Added log statement.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (214232 => 214233)


--- trunk/Tools/ChangeLog	2017-03-21 21:39:01 UTC (rev 214232)
+++ trunk/Tools/ChangeLog	2017-03-21 22:33:30 UTC (rev 214233)
@@ -1,3 +1,13 @@
+2017-03-21  Aakash Jain  <aakash_j...@apple.com>
+
+        ews should indicate in logs when it fails to parse_bug_id_from_attachment_page
+        https://bugs.webkit.org/show_bug.cgi?id=169927
+
+        Reviewed by  Alexey Proskuryakov.
+
+        * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
+        (Bugzilla._parse_bug_id_from_attachment_page): Added log statement.
+
 2017-03-20  Simon Fraser  <simon.fra...@apple.com>
 
         Add a system trace point for memory warning handling

Modified: trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py (214232 => 214233)


--- trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py	2017-03-21 21:39:01 UTC (rev 214232)
+++ trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py	2017-03-21 22:33:30 UTC (rev 214233)
@@ -488,8 +488,7 @@
         # The "Up" relation happens to point to the bug.
         up_link = BeautifulSoup(page).find('link', rel='Up')
         if not up_link:
-            # This attachment does not exist (or you don't have permissions to
-            # view it).
+            _log.warning("This attachment does not exist (or you don't have permissions to view it).")
             return None
         match = re.search("show_bug.cgi\?id=(?P<bug_id>\d+)", up_link['href'])
         return int(match.group('bug_id'))
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to