Title: [214258] trunk
- Revision
- 214258
- Author
- grao...@webkit.org
- Date
- 2017-03-22 10:51:10 -0700 (Wed, 22 Mar 2017)
Log Message
[Modern Media Controls] Rendering glitches for fullscreen controls while dragging
https://bugs.webkit.org/show_bug.cgi?id=169949
<rdar://problem/30687803>
Reviewed by Eric Carlson.
Source/WebCore:
Clipping the controls bar has some unwelcome side effects and isn't necessary, so
we simply remove it. An existing test was amended to check that there is no clipping
applied to the controls bar.
* Modules/modern-media-controls/controls/macos-fullscreen-media-controls.css:
(.media-controls.mac.fullscreen > .controls-bar):
LayoutTests:
Add an assertion that checks that the controls bar is not clipped.
* media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-controls-bar-styles-expected.txt:
* media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-controls-bar-styles.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (214257 => 214258)
--- trunk/LayoutTests/ChangeLog 2017-03-22 17:48:51 UTC (rev 214257)
+++ trunk/LayoutTests/ChangeLog 2017-03-22 17:51:10 UTC (rev 214258)
@@ -1,3 +1,16 @@
+2017-03-22 Antoine Quint <grao...@webkit.org>
+
+ [Modern Media Controls] Rendering glitches for fullscreen controls while dragging
+ https://bugs.webkit.org/show_bug.cgi?id=169949
+ <rdar://problem/30687803>
+
+ Reviewed by Eric Carlson.
+
+ Add an assertion that checks that the controls bar is not clipped.
+
+ * media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-controls-bar-styles-expected.txt:
+ * media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-controls-bar-styles.html:
+
2017-03-22 Carlos Garcia Campos <cgar...@igalia.com>
Unreviewed GTK+ gardening. Rebaseline fast/text/hyphenate-limit-lines.html.
Modified: trunk/LayoutTests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-controls-bar-styles-expected.txt (214257 => 214258)
--- trunk/LayoutTests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-controls-bar-styles-expected.txt 2017-03-22 17:48:51 UTC (rev 214257)
+++ trunk/LayoutTests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-controls-bar-styles-expected.txt 2017-03-22 17:51:10 UTC (rev 214258)
@@ -6,6 +6,7 @@
PASS style.bottom is "25px"
PASS style.width is "468px"
PASS style.height is "75px"
+PASS style.overflow is "visible"
PASS bounds.left is 166
PASS bounds.top is 500
PASS bounds.width is 468
Modified: trunk/LayoutTests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-controls-bar-styles.html (214257 => 214258)
--- trunk/LayoutTests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-controls-bar-styles.html 2017-03-22 17:48:51 UTC (rev 214257)
+++ trunk/LayoutTests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-controls-bar-styles.html 2017-03-22 17:51:10 UTC (rev 214258)
@@ -33,6 +33,7 @@
shouldBeEqualToString("style.bottom", "25px");
shouldBeEqualToString("style.width", "468px");
shouldBeEqualToString("style.height", "75px");
+ shouldBeEqualToString("style.overflow", "visible");
shouldBe("bounds.left", "166");
shouldBe("bounds.top", "500");
Modified: trunk/Source/WebCore/ChangeLog (214257 => 214258)
--- trunk/Source/WebCore/ChangeLog 2017-03-22 17:48:51 UTC (rev 214257)
+++ trunk/Source/WebCore/ChangeLog 2017-03-22 17:51:10 UTC (rev 214258)
@@ -1,3 +1,18 @@
+2017-03-22 Antoine Quint <grao...@webkit.org>
+
+ [Modern Media Controls] Rendering glitches for fullscreen controls while dragging
+ https://bugs.webkit.org/show_bug.cgi?id=169949
+ <rdar://problem/30687803>
+
+ Reviewed by Eric Carlson.
+
+ Clipping the controls bar has some unwelcome side effects and isn't necessary, so
+ we simply remove it. An existing test was amended to check that there is no clipping
+ applied to the controls bar.
+
+ * Modules/modern-media-controls/controls/macos-fullscreen-media-controls.css:
+ (.media-controls.mac.fullscreen > .controls-bar):
+
2017-03-22 John Wilander <wilan...@apple.com>
Add back the null check in TextureCacheCV::textureFromImage()
Modified: trunk/Source/WebCore/Modules/modern-media-controls/controls/macos-fullscreen-media-controls.css (214257 => 214258)
--- trunk/Source/WebCore/Modules/modern-media-controls/controls/macos-fullscreen-media-controls.css 2017-03-22 17:48:51 UTC (rev 214257)
+++ trunk/Source/WebCore/Modules/modern-media-controls/controls/macos-fullscreen-media-controls.css 2017-03-22 17:51:10 UTC (rev 214258)
@@ -38,7 +38,6 @@
bottom: 25px;
width: var(--controls-bar-width);
height: 75px;
- overflow: hidden;
}
.media-controls.mac.fullscreen > .controls-bar > .background-tint > div {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
