Title: [214312] trunk/Source/WebCore
Revision
214312
Author
commit-qu...@webkit.org
Date
2017-03-23 13:20:10 -0700 (Thu, 23 Mar 2017)

Log Message

Add logging in case libwebrtc.dylib cannot be opened
https://bugs.webkit.org/show_bug.cgi?id=170017

Patch by Youenn Fablet <you...@apple.com> on 2017-03-23
Reviewed by Geoffrey Garen.

No change of behavior.

* platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:
(WebCore::LibWebRTCProvider::webRTCAvailable):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (214311 => 214312)


--- trunk/Source/WebCore/ChangeLog	2017-03-23 19:56:46 UTC (rev 214311)
+++ trunk/Source/WebCore/ChangeLog	2017-03-23 20:20:10 UTC (rev 214312)
@@ -1,3 +1,15 @@
+2017-03-23  Youenn Fablet  <you...@apple.com>
+
+        Add logging in case libwebrtc.dylib cannot be opened
+        https://bugs.webkit.org/show_bug.cgi?id=170017
+
+        Reviewed by Geoffrey Garen.
+
+        No change of behavior.
+
+        * platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:
+        (WebCore::LibWebRTCProvider::webRTCAvailable):
+
 2017-03-23  Jiewen Tan  <jiewen_...@apple.com>
 
         Unreviewed, a speculative build fix

Modified: trunk/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp (214311 => 214312)


--- trunk/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp	2017-03-23 19:56:46 UTC (rev 214311)
+++ trunk/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp	2017-03-23 20:20:10 UTC (rev 214312)
@@ -177,8 +177,10 @@
 #if USE(LIBWEBRTC)
     static bool available = [] {
         void* libwebrtcLibrary = dlopen("libwebrtc.dylib", RTLD_LAZY);
-        if (!libwebrtcLibrary)
+        if (!libwebrtcLibrary) {
+            RELEASE_LOG(WebRTC, "Attempted to load libwebrtc without success: %s", dlerror());
             return false;
+        }
         dlclose(libwebrtcLibrary);
         return true;
     }();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to