Title: [214469] trunk
- Revision
- 214469
- Author
- commit-qu...@webkit.org
- Date
- 2017-03-28 00:49:56 -0700 (Tue, 28 Mar 2017)
Log Message
AX: Media controls should be able to be re-activated after faded away
https://bugs.webkit.org/show_bug.cgi?id=170048
<rdar://problem/30157179>
Patch by Aaron Chu <aaron_...@apple.com> on 2017-03-28
Reviewed by Antoine Quint.
Source/WebCore:
Added a "foucsin" listener for the controls bar so that when an element
within fires a "focusin" event, the controls bar reappears if it is faded.
Test: media/modern-media-controls/media-controls/media-controls-appear-when-focus.html
* Modules/modern-media-controls/controls/controls-bar.js:
(ControlsBar.prototype.handleEvent):
LayoutTests:
* media/modern-media-controls/media-controls/media-controls-appear-when-focus-expected.txt: Added.
* media/modern-media-controls/media-controls/media-controls-appear-when-focus.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (214468 => 214469)
--- trunk/LayoutTests/ChangeLog 2017-03-28 07:34:18 UTC (rev 214468)
+++ trunk/LayoutTests/ChangeLog 2017-03-28 07:49:56 UTC (rev 214469)
@@ -1,3 +1,14 @@
+2017-03-28 Aaron Chu <aaron_...@apple.com>
+
+ AX: Media controls should be able to be re-activated after faded away
+ https://bugs.webkit.org/show_bug.cgi?id=170048
+ <rdar://problem/30157179>
+
+ Reviewed by Antoine Quint.
+
+ * media/modern-media-controls/media-controls/media-controls-appear-when-focus-expected.txt: Added.
+ * media/modern-media-controls/media-controls/media-controls-appear-when-focus.html: Added.
+
2017-03-28 Antoine Quint <grao...@apple.com>
[Modern Media Controls] Improve media documents across macOS, iPhone and iPad
Added: trunk/LayoutTests/media/modern-media-controls/media-controls/media-controls-appear-when-focus-expected.txt (0 => 214469)
--- trunk/LayoutTests/media/modern-media-controls/media-controls/media-controls-appear-when-focus-expected.txt (rev 0)
+++ trunk/LayoutTests/media/modern-media-controls/media-controls/media-controls-appear-when-focus-expected.txt 2017-03-28 07:49:56 UTC (rev 214469)
@@ -0,0 +1,13 @@
+Testing the visibility of MediaControls when one of its buttons fires a focus event.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS mediaControls.controlsBar.faded is false
+PASS mediaControls.controlsBar.faded is true
+PASS mediaControls.controlsBar.faded is false
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/media/modern-media-controls/media-controls/media-controls-appear-when-focus.html (0 => 214469)
--- trunk/LayoutTests/media/modern-media-controls/media-controls/media-controls-appear-when-focus.html (rev 0)
+++ trunk/LayoutTests/media/modern-media-controls/media-controls/media-controls-appear-when-focus.html 2017-03-28 07:49:56 UTC (rev 214469)
@@ -0,0 +1,21 @@
+<script src=""
+<script src="" type="text/_javascript_"></script>
+<body>
+<script type="text/_javascript_">
+
+description("Testing the visibility of <code>MediaControls</code> when one of its buttons fires a focus event.");
+
+const mediaControls = new MediaControls({ layoutTraits: LayoutTraits.macOS });
+
+shouldBeFalse("mediaControls.controlsBar.faded");
+mediaControls.controlsBar.faded = true;
+shouldBeTrue("mediaControls.controlsBar.faded");
+let focusin = new Event("focusin");
+mediaControls.controlsBar.element.dispatchEvent(focusin);
+shouldBeFalse("mediaControls.controlsBar.faded");
+
+debug("");
+
+</script>
+<script src=""
+</body>
Modified: trunk/Source/WebCore/ChangeLog (214468 => 214469)
--- trunk/Source/WebCore/ChangeLog 2017-03-28 07:34:18 UTC (rev 214468)
+++ trunk/Source/WebCore/ChangeLog 2017-03-28 07:49:56 UTC (rev 214469)
@@ -1,3 +1,19 @@
+2017-03-28 Aaron Chu <aaron_...@apple.com>
+
+ AX: Media controls should be able to be re-activated after faded away
+ https://bugs.webkit.org/show_bug.cgi?id=170048
+ <rdar://problem/30157179>
+
+ Reviewed by Antoine Quint.
+
+ Added a "foucsin" listener for the controls bar so that when an element
+ within fires a "focusin" event, the controls bar reappears if it is faded.
+
+ Test: media/modern-media-controls/media-controls/media-controls-appear-when-focus.html
+
+ * Modules/modern-media-controls/controls/controls-bar.js:
+ (ControlsBar.prototype.handleEvent):
+
2017-03-28 Antoine Quint <grao...@apple.com>
[Modern Media Controls] Improve media documents across macOS, iPhone and iPad
Modified: trunk/Source/WebCore/Modules/modern-media-controls/controls/controls-bar.js (214468 => 214469)
--- trunk/Source/WebCore/Modules/modern-media-controls/controls/controls-bar.js 2017-03-28 07:34:18 UTC (rev 214468)
+++ trunk/Source/WebCore/Modules/modern-media-controls/controls/controls-bar.js 2017-03-28 07:49:56 UTC (rev 214469)
@@ -40,6 +40,8 @@
this.fadesWhileIdle = false;
this.userInteractionEnabled = true;
+
+ this.element.addEventListener("focusin", this);
}
// Public
@@ -169,7 +171,7 @@
} else if (event.type === "mouseleave") {
delete this._disableAutoHiding;
this._resetAutoHideTimer(true);
- } else if (event.type === "focus")
+ } else if (event.type === "focusin")
this.faded = false;
}
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
