Title: [214482] trunk/Source/WebCore
Revision
214482
Author
simon.fra...@apple.com
Date
2017-03-28 11:29:37 -0700 (Tue, 28 Mar 2017)

Log Message

Make sure the non-fast scrolling debug overlay is correctly updated
https://bugs.webkit.org/show_bug.cgi?id=170142

Reviewed by Tim Horton.

AsyncScrollingCoordinator::frameViewEventTrackingRegionsChanged() is called on a timer
from Document code, so the existing DebugPageOverlays::didLayout() call at the end
of FrameView::layout() wasn't sufficient to keep the non-fast scrollable region up-to-date
on iOS.

* page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::frameViewEventTrackingRegionsChanged):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (214481 => 214482)


--- trunk/Source/WebCore/ChangeLog	2017-03-28 18:27:02 UTC (rev 214481)
+++ trunk/Source/WebCore/ChangeLog	2017-03-28 18:29:37 UTC (rev 214482)
@@ -1,3 +1,18 @@
+2017-03-27  Simon Fraser  <simon.fra...@apple.com>
+
+        Make sure the non-fast scrolling debug overlay is correctly updated
+        https://bugs.webkit.org/show_bug.cgi?id=170142
+
+        Reviewed by Tim Horton.
+
+        AsyncScrollingCoordinator::frameViewEventTrackingRegionsChanged() is called on a timer
+        from Document code, so the existing DebugPageOverlays::didLayout() call at the end
+        of FrameView::layout() wasn't sufficient to keep the non-fast scrollable region up-to-date
+        on iOS.
+
+        * page/scrolling/AsyncScrollingCoordinator.cpp:
+        (WebCore::AsyncScrollingCoordinator::frameViewEventTrackingRegionsChanged):
+
 2017-03-28  Antoine Quint  <grao...@apple.com>
 
         [Modern Media Controls] AirPlay placard text looks bad on 1x displays

Modified: trunk/Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp (214481 => 214482)


--- trunk/Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp	2017-03-28 18:27:02 UTC (rev 214481)
+++ trunk/Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp	2017-03-28 18:29:37 UTC (rev 214482)
@@ -28,6 +28,7 @@
 #if ENABLE(ASYNC_SCROLLING)
 #include "AsyncScrollingCoordinator.h"
 
+#include "DebugPageOverlays.h"
 #include "Document.h"
 #include "EditorClient.h"
 #include "Frame.h"
@@ -196,12 +197,13 @@
     node->setExpectsWheelEventTestTrigger(page->expectsWheelEventTriggers());
 }
 
-void AsyncScrollingCoordinator::frameViewEventTrackingRegionsChanged(FrameView&)
+void AsyncScrollingCoordinator::frameViewEventTrackingRegionsChanged(FrameView& frameView)
 {
     if (!m_scrollingStateTree->rootStateNode())
         return;
 
     setEventTrackingRegionsDirty();
+    DebugPageOverlays::didChangeEventHandlers(frameView.frame());
 }
 
 void AsyncScrollingCoordinator::frameViewRootLayerDidChange(FrameView& frameView)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to