Diff
Modified: trunk/Source/WebCore/ChangeLog (99426 => 99427)
--- trunk/Source/WebCore/ChangeLog 2011-11-07 16:31:51 UTC (rev 99426)
+++ trunk/Source/WebCore/ChangeLog 2011-11-07 16:48:35 UTC (rev 99427)
@@ -1,3 +1,13 @@
+2011-11-07 Pavel Feldman <pfeld...@google.com>
+
+ Not reviewed: follow up to r99407. Style the suggest box.
+ https://bugs.webkit.org/show_bug.cgi?id=65511
+
+
+ * inspector/front-end/TextPrompt.js:
+ * inspector/front-end/inspector.css:
+ * inspector/front-end/textPrompt.css:
+
2011-11-07 Roland Steiner <rolandstei...@chromium.org>
https://bugs.webkit.org/show_bug.cgi?id=70223
Modified: trunk/Source/WebCore/inspector/front-end/TextPrompt.js (99426 => 99427)
--- trunk/Source/WebCore/inspector/front-end/TextPrompt.js 2011-11-07 16:31:51 UTC (rev 99426)
+++ trunk/Source/WebCore/inspector/front-end/TextPrompt.js 2011-11-07 16:48:35 UTC (rev 99427)
@@ -815,7 +815,7 @@
window.addEventListener("scroll", this._boundOnScroll, true);
window.addEventListener("resize", this._boundOnResize, true);
- this._element = this._parentElement.createChild("div", "suggest-box custom-popup-vertical-scroll custom-popup-horizontal-scroll " + (className || ""));
+ this._element = this._parentElement.createChild("div", "suggest-box " + (className || ""));
this._element.addEventListener("mousedown", this._onboxmousedown.bind(this), true);
this.containerElement = this._element.createChild("div", "container");
this.contentElement = this.containerElement.createChild("div", "content");
@@ -855,9 +855,9 @@
// Lay out the suggest-box relative to the anchorBox.
const anchorBox = this._inputElement.boxInWindow(window, this._parentElement);
const suggestBoxPaddingX = 21;
- const suggestBoxPaddingY = 12;
+ const suggestBoxPaddingY = 2;
const spacer = 6;
- const minHeight = 50;
+ const minHeight = 25;
const maxWidth = document.body.offsetWidth - anchorBox.x - spacer;
const width = Math.min(contentWidth, maxWidth - suggestBoxPaddingX) + suggestBoxPaddingX;
@@ -967,7 +967,7 @@
*/
updateSuggestionsSoon: function(completions)
{
- if (!("_suggestTimeout" in this))
+ if (!this._suggestTimeout)
this._suggestTimeout = setTimeout(this.updateSuggestions.bind(this, completions), 10);
},
@@ -976,7 +976,7 @@
*/
updateSuggestions: function(completions)
{
- if ("_suggestTimeout" in this) {
+ if (this._suggestTimeout) {
clearTimeout(this._suggestTimeout);
delete this._suggestTimeout;
}
@@ -1017,6 +1017,7 @@
var child = this.contentElement.firstChild;
var childText = child ? child.textContent : null;
this.contentElement.removeChildren();
+
delete this._selectedElement;
var userEnteredText = this._textPrompt._userEnteredText;
Modified: trunk/Source/WebCore/inspector/front-end/inspector.css (99426 => 99427)
--- trunk/Source/WebCore/inspector/front-end/inspector.css 2011-11-07 16:31:51 UTC (rev 99426)
+++ trunk/Source/WebCore/inspector/front-end/inspector.css 2011-11-07 16:48:35 UTC (rev 99427)
@@ -2520,21 +2520,14 @@
/* Generic suggest box style */
.suggest-box.generic-suggest {
- border-radius: 0 5px 5px 5px;
margin-left: -1px;
border-color: rgb(66%, 66%, 66%);
- -webkit-box-shadow: 8px 8px 6px rgba(40, 40, 40, 0.40);
}
.suggest-box.generic-suggest.above-anchor {
border-radius: 5px 5px 5px 0;
- -webkit-box-shadow: 8px -8px 6px rgba(40, 40, 40, 0.40);
}
-.suggest-box.generic-suggest .content {
- margin: 3px;
-}
-
/* Custom popup scrollers */
.custom-popup-horizontal-scroll ::-webkit-scrollbar, .custom-popup-vertical-scroll ::-webkit-scrollbar {
Modified: trunk/Source/WebCore/inspector/front-end/inspectorCommon.css (99426 => 99427)
--- trunk/Source/WebCore/inspector/front-end/inspectorCommon.css 2011-11-07 16:31:51 UTC (rev 99426)
+++ trunk/Source/WebCore/inspector/front-end/inspectorCommon.css 2011-11-07 16:48:35 UTC (rev 99427)
@@ -13,7 +13,6 @@
font-family: Lucida Grande, sans-serif;
font-size: 10px;
margin: 0;
- -webkit-text-size-adjust: none;
-webkit-user-select: none;
}
Modified: trunk/Source/WebCore/inspector/front-end/textPrompt.css (99426 => 99427)
--- trunk/Source/WebCore/inspector/front-end/textPrompt.css 2011-11-07 16:31:51 UTC (rev 99426)
+++ trunk/Source/WebCore/inspector/front-end/textPrompt.css 2011-11-07 16:48:35 UTC (rev 99427)
@@ -35,7 +35,6 @@
border: 1px solid black;
padding: 2px;
z-index: 100;
- -webkit-box-shadow: 10px 10px 8px rgba(40, 40, 40, 0.40);
}
.suggest-box.visible {
@@ -48,7 +47,6 @@
left: 0;
right: 0;
bottom: 0;
- margin: 2px 0;
overflow-x: hidden;
overflow-y: auto;
}
@@ -67,8 +65,7 @@
}
.suggest-box-content-item.selected {
- border: 1px solid rgb(0, 0, 0);
- background-color: rgb(238, 238, 238);
+ background-color: rgb(212, 212, 212);
}
.suggest-box-content-item:hover:not(.selected) {
