Title: [215215] trunk/Tools
- Revision
- 215215
- Author
- commit-qu...@webkit.org
- Date
- 2017-04-10 20:33:56 -0700 (Mon, 10 Apr 2017)
Log Message
Have parseRevisionProperty use default repo name as the Buildbot key.
https://bugs.webkit.org/show_bug.cgi?id=170696
Patch by Kocsen Chung <kocsen_ch...@apple.com> on 2017-04-10
Reviewed by Daniel Bates.
Previously, we needed to set a key and a fallbackKey when addressing
Buildbot data for Internal. That is no longer necessary as we can make a safe assumption
that the repo name maps exactly to that key for every repository other
than WebKit.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
Set `key = repositoryName` and only use fallback keys when dealing with WebKit.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js (215214 => 215215)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js 2017-04-11 02:49:59 UTC (rev 215214)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js 2017-04-11 03:33:56 UTC (rev 215215)
@@ -201,21 +201,21 @@
return property[0] === "got_revision";
});
var branches = this.queue.branches;
+
for (var i = 0; i < branches.length; ++i) {
var repository = branches[i].repository;
var repositoryName = repository.name;
var key;
var fallbackKey;
+
if (repository === Dashboard.Repository.OpenSource) {
key = "WebKit";
fallbackKey = "opensource";
- } else if (repository === Dashboard.Repository.Internal) {
- key = "Internal";
- fallbackKey = "internal";
} else {
key = repositoryName;
fallbackKey = null;
}
+
var revision = parseRevisionProperty(revisionProperty, key, fallbackKey);
this.revision[repositoryName] = revision;
}
Modified: trunk/Tools/ChangeLog (215214 => 215215)
--- trunk/Tools/ChangeLog 2017-04-11 02:49:59 UTC (rev 215214)
+++ trunk/Tools/ChangeLog 2017-04-11 03:33:56 UTC (rev 215215)
@@ -1,3 +1,18 @@
+2017-04-10 Kocsen Chung <kocsen_ch...@apple.com>
+
+ Have parseRevisionProperty use default repo name as the Buildbot key.
+ https://bugs.webkit.org/show_bug.cgi?id=170696
+
+ Reviewed by Daniel Bates.
+
+ Previously, we needed to set a key and a fallbackKey when addressing
+ Buildbot data for Internal. That is no longer necessary as we can make a safe assumption
+ that the repo name maps exactly to that key for every repository other
+ than WebKit.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
+ Set `key = repositoryName` and only use fallback keys when dealing with WebKit.
+
2017-04-10 Aakash Jain <aakash_j...@apple.com>
Add test262 _javascript_Core tests to dashboard
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
