Title: [215222] trunk/LayoutTests
- Revision
- 215222
- Author
- [email protected]
- Date
- 2017-04-11 02:20:16 -0700 (Tue, 11 Apr 2017)
Log Message
[css-grid] Fix fast/css-grid-layout/grid-simplified-layout-positioned.html
https://bugs.webkit.org/show_bug.cgi?id=167538
Reviewed by Darin Adler.
fast/css-grid-layout/grid-simplified-layout-positioned.html was flacky
as the caret was not always painted in the test runner.
The test was checking for a crash in simplified layout (see bug #163450)
and has nothing to do with the caret or "autofocus" behavior.
"autofocus" was needed to get the crash, so this change modifies
the test to blur the element, so the caret is not painted anymore.
* fast/css-grid-layout/grid-simplified-layout-positioned-expected.html:
Don't focus the input element.
* fast/css-grid-layout/grid-simplified-layout-positioned.html: Blur
the input element to avoid showing the caret.
* platform/mac-wk2/TestExpectations: Remove file from expectations.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (215221 => 215222)
--- trunk/LayoutTests/ChangeLog 2017-04-11 08:29:43 UTC (rev 215221)
+++ trunk/LayoutTests/ChangeLog 2017-04-11 09:20:16 UTC (rev 215222)
@@ -1,3 +1,23 @@
+2017-04-11 Manuel Rego Casasnovas <[email protected]>
+
+ [css-grid] Fix fast/css-grid-layout/grid-simplified-layout-positioned.html
+ https://bugs.webkit.org/show_bug.cgi?id=167538
+
+ Reviewed by Darin Adler.
+
+ fast/css-grid-layout/grid-simplified-layout-positioned.html was flacky
+ as the caret was not always painted in the test runner.
+ The test was checking for a crash in simplified layout (see bug #163450)
+ and has nothing to do with the caret or "autofocus" behavior.
+ "autofocus" was needed to get the crash, so this change modifies
+ the test to blur the element, so the caret is not painted anymore.
+
+ * fast/css-grid-layout/grid-simplified-layout-positioned-expected.html:
+ Don't focus the input element.
+ * fast/css-grid-layout/grid-simplified-layout-positioned.html: Blur
+ the input element to avoid showing the caret.
+ * platform/mac-wk2/TestExpectations: Remove file from expectations.
+
2017-04-10 Jiewen Tan <[email protected]>
Unreviewed, test expectations update
Modified: trunk/LayoutTests/fast/css-grid-layout/grid-simplified-layout-positioned-expected.html (215221 => 215222)
--- trunk/LayoutTests/fast/css-grid-layout/grid-simplified-layout-positioned-expected.html 2017-04-11 08:29:43 UTC (rev 215221)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-simplified-layout-positioned-expected.html 2017-04-11 09:20:16 UTC (rev 215222)
@@ -9,4 +9,4 @@
</style>
This text and input should appear at 100x100 position.
Like if they have a left and top margin of 100px.
-<input autofocus>
+<input>
Modified: trunk/LayoutTests/fast/css-grid-layout/grid-simplified-layout-positioned.html (215221 => 215222)
--- trunk/LayoutTests/fast/css-grid-layout/grid-simplified-layout-positioned.html 2017-04-11 08:29:43 UTC (rev 215221)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-simplified-layout-positioned.html 2017-04-11 09:20:16 UTC (rev 215222)
@@ -15,3 +15,15 @@
This text and input should appear at 100x100 position.
Like if they have a left and top margin of 100px.
<input autofocus>
+<script>
+ if (window.testRunner)
+ window.testRunner.waitUntilDone();
+ // "autofocus" is needed to force the simplified layout call.
+ // We are removing the focus here to match the expected file and avoid issues with the caret.
+ // We need a small timeout so "blur()" is run after "autofocus".
+ setTimeout(function() {
+ document.querySelector("input").blur();
+ if (window.testRunner)
+ window.testRunner.notifyDone();
+ }, 100);
+</script>
Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (215221 => 215222)
--- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2017-04-11 08:29:43 UTC (rev 215221)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2017-04-11 09:20:16 UTC (rev 215222)
@@ -613,8 +613,6 @@
webkit.org/b/168065 inspector/unit-tests/heap-snapshot.html [ Pass Failure Timeout ]
-webkit.org/b/167538 [ Sierra ] fast/css-grid-layout/grid-simplified-layout-positioned.html [ Pass ImageOnlyFailure ]
-
webkit.org/b/168235 [ Debug ] imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-a-element/a-download-click.html [ Pass Failure ]
webkit.org/b/168085 tiled-drawing/scrolling/latched-to-deleted-node.html [ Pass Failure ]
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
