Title: [99453] trunk/Source/WebCore
- Revision
- 99453
- Author
- [email protected]
- Date
- 2011-11-07 12:09:42 -0800 (Mon, 07 Nov 2011)
Log Message
Web Inspector: Suggest box should not accept suggestion on space key pressed.
https://bugs.webkit.org/show_bug.cgi?id=71706
Reviewed by Pavel Feldman.
* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype.onKeyDown):
(WebInspector.TextPrompt.SuggestBox.prototype.tabKeyPressed):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (99452 => 99453)
--- trunk/Source/WebCore/ChangeLog 2011-11-07 19:46:54 UTC (rev 99452)
+++ trunk/Source/WebCore/ChangeLog 2011-11-07 20:09:42 UTC (rev 99453)
@@ -1,3 +1,14 @@
+2011-11-07 Vsevolod Vlasov <[email protected]>
+
+ Web Inspector: Suggest box should not accept suggestion on space key pressed.
+ https://bugs.webkit.org/show_bug.cgi?id=71706
+
+ Reviewed by Pavel Feldman.
+
+ * inspector/front-end/TextPrompt.js:
+ (WebInspector.TextPrompt.prototype.onKeyDown):
+ (WebInspector.TextPrompt.SuggestBox.prototype.tabKeyPressed):
+
2011-11-07 Andreas Kling <[email protected]>
Don't use CSSOM's CSSValue.cssValueType internally in WebCore.
Modified: trunk/Source/WebCore/inspector/front-end/TextPrompt.js (99452 => 99453)
--- trunk/Source/WebCore/inspector/front-end/TextPrompt.js 2011-11-07 19:46:54 UTC (rev 99452)
+++ trunk/Source/WebCore/inspector/front-end/TextPrompt.js 2011-11-07 20:09:42 UTC (rev 99453)
@@ -246,8 +246,7 @@
if (this._suggestForceable && event.ctrlKey && !event.metaKey && !event.altKey && !event.shiftKey) {
this.defaultKeyHandler(event, true);
handled = true;
- } else if (this.isSuggestBoxVisible())
- handled = this._suggestBox.spaceKeyPressed(event);
+ }
break;
case "Alt":
case "Meta":
@@ -1084,11 +1083,5 @@
tabKeyPressed: function(event)
{
return this.enterKeyPressed(event);
- },
-
- spaceKeyPressed: function(event)
- {
- this.acceptSuggestion();
- return false; // Do not inhibit a whitespace entry after the suggestion.
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
