Title: [215421] trunk/Source/WebKit2
- Revision
- 215421
- Author
- wenson_hs...@apple.com
- Date
- 2017-04-17 12:26:29 -0700 (Mon, 17 Apr 2017)
Log Message
[WK2] Respect a new internal setting for defaulting to character selection granularity
https://bugs.webkit.org/show_bug.cgi?id=170904
<rdar://problem/31364280>
Reviewed by Dan Bernstein.
Respect a new WebKitDebugDefaultSelectionGranularityCharacter user default by initializing
WKWebViewConfiguration with WKSelectionGranularityCharacter, but only when linked on or after the first iOS to
use WKSelectionGranularityCharacter by default.
* UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration init]):
* UIProcess/Cocoa/VersionChecks.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (215420 => 215421)
--- trunk/Source/WebKit2/ChangeLog 2017-04-17 18:26:17 UTC (rev 215420)
+++ trunk/Source/WebKit2/ChangeLog 2017-04-17 19:26:29 UTC (rev 215421)
@@ -1,3 +1,19 @@
+2017-04-17 Wenson Hsieh <wenson_hs...@apple.com>
+
+ [WK2] Respect a new internal setting for defaulting to character selection granularity
+ https://bugs.webkit.org/show_bug.cgi?id=170904
+ <rdar://problem/31364280>
+
+ Reviewed by Dan Bernstein.
+
+ Respect a new WebKitDebugDefaultSelectionGranularityCharacter user default by initializing
+ WKWebViewConfiguration with WKSelectionGranularityCharacter, but only when linked on or after the first iOS to
+ use WKSelectionGranularityCharacter by default.
+
+ * UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
+ (-[WKWebViewConfiguration init]):
+ * UIProcess/Cocoa/VersionChecks.h:
+
2017-04-17 Eric Carlson <eric.carl...@apple.com>
Provide a way for clients to unmute a media stream.
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm (215420 => 215421)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm 2017-04-17 18:26:17 UTC (rev 215420)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm 2017-04-17 19:26:29 UTC (rev 215421)
@@ -197,6 +197,11 @@
_treatsSHA1SignedCertificatesAsInsecure = YES;
_needsStorageAccessFromFileURLsQuirk = YES;
+#if PLATFORM(IOS)
+ BOOL defaultToSelectionGranularityCharacter = [[NSUserDefaults standardUserDefaults] boolForKey:@"WebKitDebugDefaultSelectionGranularityCharacter"] && WebKit::linkedOnOrAfter(WebKit::SDKVersion::FirstToUseSelectionGranularityCharacterByDefault);
+ _selectionGranularity = defaultToSelectionGranularityCharacter ? WKSelectionGranularityCharacter : WKSelectionGranularityDynamic;
+#endif
+
return self;
}
Modified: trunk/Source/WebKit2/UIProcess/Cocoa/VersionChecks.h (215420 => 215421)
--- trunk/Source/WebKit2/UIProcess/Cocoa/VersionChecks.h 2017-04-17 18:26:17 UTC (rev 215420)
+++ trunk/Source/WebKit2/UIProcess/Cocoa/VersionChecks.h 2017-04-17 19:26:29 UTC (rev 215421)
@@ -35,6 +35,7 @@
FirstWithMediaTypesRequiringUserActionForPlayback = DYLD_IOS_VERSION_10_0,
FirstWithExceptionsForDuplicateCompletionHandlerCalls = DYLD_IOS_VERSION_11_0,
FirstToExcludeLocalStorageFromBackup = DYLD_IOS_VERSION_11_0,
+ FirstToUseSelectionGranularityCharacterByDefault = DYLD_IOS_VERSION_11_0,
#elif PLATFORM(MAC)
FirstWithNetworkCache = DYLD_MACOSX_VERSION_10_11,
FirstWithExceptionsForDuplicateCompletionHandlerCalls = DYLD_MACOSX_VERSION_10_13,
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
