Title: [99480] trunk/Source/WebKit/efl
- Revision
- 99480
- Author
- commit-qu...@webkit.org
- Date
- 2011-11-07 14:38:32 -0800 (Mon, 07 Nov 2011)
Log Message
[EFL] Emit the "frame,created" signal earlier.
https://bugs.webkit.org/show_bug.cgi?id=71696
Patch by Raphael Kubo da Costa <k...@profusion.mobi> on 2011-11-07
Reviewed by Kenneth Rohde Christiansen.
FrameLoader::loadURLIntoChildFrame will trigger the machinery that will call
FrameLoaderClientEfl::dispatchDidStartProvisionalLoad. However, since we were
emitting the "frame,created" signal after that, applications would connect to
it after some other frame signals had already been emitted. Should help tests
such as http/tests/loading/empty-subframe.html pass.
* ewk/ewk_frame.cpp:
(ewk_frame_child_add):
* ewk/ewk_view.cpp:
(ewk_view_frame_create):
Modified Paths
Diff
Modified: trunk/Source/WebKit/efl/ChangeLog (99479 => 99480)
--- trunk/Source/WebKit/efl/ChangeLog 2011-11-07 22:35:13 UTC (rev 99479)
+++ trunk/Source/WebKit/efl/ChangeLog 2011-11-07 22:38:32 UTC (rev 99480)
@@ -1,3 +1,21 @@
+2011-11-07 Raphael Kubo da Costa <k...@profusion.mobi>
+
+ [EFL] Emit the "frame,created" signal earlier.
+ https://bugs.webkit.org/show_bug.cgi?id=71696
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ FrameLoader::loadURLIntoChildFrame will trigger the machinery that will call
+ FrameLoaderClientEfl::dispatchDidStartProvisionalLoad. However, since we were
+ emitting the "frame,created" signal after that, applications would connect to
+ it after some other frame signals had already been emitted. Should help tests
+ such as http/tests/loading/empty-subframe.html pass.
+
+ * ewk/ewk_frame.cpp:
+ (ewk_frame_child_add):
+ * ewk/ewk_view.cpp:
+ (ewk_view_frame_create):
+
2011-11-04 Raphael Kubo da Costa <k...@profusion.mobi>
[EFL] DRT: Fix the order of the items in the dumped history list.
Modified: trunk/Source/WebKit/efl/ewk/ewk_frame.cpp (99479 => 99480)
--- trunk/Source/WebKit/efl/ewk/ewk_frame.cpp 2011-11-07 22:35:13 UTC (rev 99479)
+++ trunk/Source/WebKit/efl/ewk/ewk_frame.cpp 2011-11-07 22:38:32 UTC (rev 99480)
@@ -1151,6 +1151,7 @@
return true;
}
+ evas_object_smart_callback_call(smartData->view, "frame,created", frame);
smartData->frame->loader()->loadURLIntoChildFrame(url, referrer, coreFrame);
// The frame's onload handler may have removed it from the document.
@@ -1160,7 +1161,6 @@
return true;
}
- // TODO: announce frame was created?
return true;
}
Modified: trunk/Source/WebKit/efl/ewk/ewk_view.cpp (99479 => 99480)
--- trunk/Source/WebKit/efl/ewk/ewk_view.cpp 2011-11-07 22:35:13 UTC (rev 99479)
+++ trunk/Source/WebKit/efl/ewk/ewk_view.cpp 2011-11-07 22:38:32 UTC (rev 99480)
@@ -3393,7 +3393,6 @@
smartData->changed.frame_rect = true;
_ewk_view_smart_changed(smartData);
- evas_object_smart_callback_call(ewkView, "frame,created", frame);
return coreFrame.release();
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
