Title: [215657] trunk/Source
Revision
215657
Author
aes...@apple.com
Date
2017-04-21 17:53:44 -0700 (Fri, 21 Apr 2017)

Log Message

[macOS] Enable media selection button on AVTouchBarScrubber
https://bugs.webkit.org/show_bug.cgi?id=171149
<rdar://problem/29875010>

Reviewed by Beth Dakin.

Source/WebCore:

* platform/spi/cocoa/AVKitSPI.h:

Source/WebKit2:

* UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::updateMediaTouchBar):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (215656 => 215657)


--- trunk/Source/WebCore/ChangeLog	2017-04-22 00:51:15 UTC (rev 215656)
+++ trunk/Source/WebCore/ChangeLog	2017-04-22 00:53:44 UTC (rev 215657)
@@ -1,5 +1,15 @@
 2017-04-21  Andy Estes  <aes...@apple.com>
 
+        [macOS] Enable media selection button on AVTouchBarScrubber
+        https://bugs.webkit.org/show_bug.cgi?id=171149
+        <rdar://problem/29875010>
+
+        Reviewed by Beth Dakin.
+
+        * platform/spi/cocoa/AVKitSPI.h:
+
+2017-04-21  Andy Estes  <aes...@apple.com>
+
         [macOS] Name WebPlaybackControlsManager delegate methods correctly depending on OS version
         https://bugs.webkit.org/show_bug.cgi?id=171147
         <rdar://problem/29875010>

Modified: trunk/Source/WebCore/platform/spi/cocoa/AVKitSPI.h (215656 => 215657)


--- trunk/Source/WebCore/platform/spi/cocoa/AVKitSPI.h	2017-04-22 00:51:15 UTC (rev 215656)
+++ trunk/Source/WebCore/platform/spi/cocoa/AVKitSPI.h	2017-04-22 00:53:44 UTC (rev 215657)
@@ -221,6 +221,7 @@
 
 @interface AVTouchBarScrubber : NSView
 @property (assign, nullable) id<AVTouchBarPlaybackControlsControlling> playbackControlsController;
+@property BOOL canShowMediaSelectionButton;
 @end
 
 @class AVThumbnail;

Modified: trunk/Source/WebKit2/ChangeLog (215656 => 215657)


--- trunk/Source/WebKit2/ChangeLog	2017-04-22 00:51:15 UTC (rev 215656)
+++ trunk/Source/WebKit2/ChangeLog	2017-04-22 00:53:44 UTC (rev 215657)
@@ -1,3 +1,14 @@
+2017-04-21  Andy Estes  <aes...@apple.com>
+
+        [macOS] Enable media selection button on AVTouchBarScrubber
+        https://bugs.webkit.org/show_bug.cgi?id=171149
+        <rdar://problem/29875010>
+
+        Reviewed by Beth Dakin.
+
+        * UIProcess/Cocoa/WebViewImpl.mm:
+        (WebKit::WebViewImpl::updateMediaTouchBar):
+
 2017-04-21  Wenson Hsieh  <wenson_hs...@apple.com>
 
         [WK2] Add delegate hooks for overriding unhanded data interaction operations

Modified: trunk/Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm (215656 => 215657)


--- trunk/Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm	2017-04-22 00:51:15 UTC (rev 215656)
+++ trunk/Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm	2017-04-22 00:53:44 UTC (rev 215657)
@@ -1140,6 +1140,7 @@
     if (!m_mediaPlaybackControlsView) {
 #if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300
         m_mediaPlaybackControlsView = adoptNS([allocAVTouchBarScrubberInstance() init]);
+        [m_mediaPlaybackControlsView setCanShowMediaSelectionButton:YES];
 #else
         m_mediaPlaybackControlsView = adoptNS([allocAVFunctionBarScrubberInstance() init]);
 #endif // __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to