Title: [215769] trunk/Source/WebCore
- Revision
- 215769
- Author
- aakash_j...@apple.com
- Date
- 2017-04-25 16:49:14 -0700 (Tue, 25 Apr 2017)
Log Message
WebCore.framework should restrict allowable_clients
https://bugs.webkit.org/show_bug.cgi?id=171260
Reviewed by Alexey Proskuryakov.
* Configurations/WebCore.xcconfig: Adding allowable_client to all platform, in order to restrict WebCore
from being directly linked on any platform.
Moved WebKitLegacy and WebCoreTestSupport to OTHER_LDFLAGS_BASE.
Removed WebKit2 as allowable_client from mac.
Added iTunesU, Casablanca and Remote to OTHER_LDFLAGS_BASE_ios for iTunes related projects.
Added WebKit, TVBooks, DumpRenderTree, WebKitTestRunner and TestWebKitAPI to OTHER_LDFLAGS_BASE_ios.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (215768 => 215769)
--- trunk/Source/WebCore/ChangeLog 2017-04-25 23:45:45 UTC (rev 215768)
+++ trunk/Source/WebCore/ChangeLog 2017-04-25 23:49:14 UTC (rev 215769)
@@ -1,3 +1,17 @@
+2017-04-25 Aakash Jain <aakash_j...@apple.com>
+
+ WebCore.framework should restrict allowable_clients
+ https://bugs.webkit.org/show_bug.cgi?id=171260
+
+ Reviewed by Alexey Proskuryakov.
+
+ * Configurations/WebCore.xcconfig: Adding allowable_client to all platform, in order to restrict WebCore
+ from being directly linked on any platform.
+ Moved WebKitLegacy and WebCoreTestSupport to OTHER_LDFLAGS_BASE.
+ Removed WebKit2 as allowable_client from mac.
+ Added iTunesU, Casablanca and Remote to OTHER_LDFLAGS_BASE_ios for iTunes related projects.
+ Added WebKit, TVBooks, DumpRenderTree, WebKitTestRunner and TestWebKitAPI to OTHER_LDFLAGS_BASE_ios.
+
2017-04-25 Said Abou-Hallawa <sabouhall...@apple.com>
Restrict WebKit image formats to a known whitelist
Modified: trunk/Source/WebCore/Configurations/WebCore.xcconfig (215768 => 215769)
--- trunk/Source/WebCore/Configurations/WebCore.xcconfig 2017-04-25 23:45:45 UTC (rev 215768)
+++ trunk/Source/WebCore/Configurations/WebCore.xcconfig 2017-04-25 23:49:14 UTC (rev 215769)
@@ -78,11 +78,12 @@
LIBWEBRTC_LIBRARY_DIR_USE_OVERRIDE_FRAMEWORKS_DIR_YES = $(WK_OVERRIDE_FRAMEWORKS_DIR);
OTHER_LDFLAGS = $(inherited) $(WK_RELOCATABLE_FRAMEWORK_LDFLAGS) $(OTHER_LDFLAGS_PLATFORM);
-OTHER_LDFLAGS_BASE = -lsqlite3 -lobjc -lANGLE -framework Metal;
-OTHER_LDFLAGS_BASE_ios = $(OTHER_LDFLAGS_BASE) -framework CFNetwork -framework CoreGraphics -framework CoreText -framework Foundation -framework ImageIO -framework MobileCoreServices -framework OpenGLES -lMobileGestalt $(WK_IOS_BINCOMPAT_LDFLAGS);
+OTHER_LDFLAGS_BASE = -lsqlite3 -lobjc -lANGLE -framework Metal -allowable_client WebCoreTestSupport -allowable_client WebKitLegacy;
+// FIXME: Reduce the number of allowable_client <rdar://problem/31823969>
+OTHER_LDFLAGS_BASE_ios = $(OTHER_LDFLAGS_BASE) -framework CFNetwork -framework CoreGraphics -framework CoreText -framework Foundation -framework ImageIO -framework MobileCoreServices -framework OpenGLES -lMobileGestalt $(WK_IOS_BINCOMPAT_LDFLAGS) -allowable_client WebKit -allowable_client iTunesU -allowable_client Casablanca -allowable_client Remote -allowable_client TVBooks -allowable_client DumpRenderTree -allowable_client WebKitTestRunner -allowable_client TestWebKitAPI;
OTHER_LDFLAGS_PLATFORM[sdk=iphoneos*] = $(OTHER_LDFLAGS_BASE_ios) -framework IOSurface -framework GraphicsServices $(LIBWEBRTC_LDFLAGS);
OTHER_LDFLAGS_PLATFORM[sdk=iphonesimulator*] = $(OTHER_LDFLAGS_BASE_ios) $(LIBWEBRTC_LDFLAGS);
-OTHER_LDFLAGS_PLATFORM[sdk=macosx*] = $(OTHER_LDFLAGS_BASE) -sub_library libobjc -umbrella WebKit -allowable_client WebCoreTestSupport -allowable_client WebKit2 -allowable_client WebKitLegacy -framework ApplicationServices -framework AudioUnit -framework Carbon -framework Cocoa -framework CoreAudio -framework DataDetectorsCore -framework IOSurface -framework OpenGL -framework SystemConfiguration $(LIBWEBRTC_LDFLAGS);
+OTHER_LDFLAGS_PLATFORM[sdk=macosx*] = $(OTHER_LDFLAGS_BASE) -sub_library libobjc -umbrella WebKit -framework ApplicationServices -framework AudioUnit -framework Carbon -framework Cocoa -framework CoreAudio -framework DataDetectorsCore -framework IOSurface -framework OpenGL -framework SystemConfiguration $(LIBWEBRTC_LDFLAGS);
SECTORDER_FLAGS = $(SECTORDER_FLAGS_$(CONFIGURATION));
SECTORDER_FLAGS_Production[sdk=iphoneos*] = -Wl,-order_file,$(SDKROOT)/AppleInternal/OrderFiles/WebCore.order;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
