Title: [99514] trunk
- Revision
- 99514
- Author
- cfleiz...@apple.com
- Date
- 2011-11-07 18:25:59 -0800 (Mon, 07 Nov 2011)
Log Message
REGRESSION(r99025-r99037): platform/mac/accessibility/select-element-selection-with-optgroups.html is asserting
https://bugs.webkit.org/show_bug.cgi?id=71421
Reviewed by Ryosuke Niwa.
Source/WebCore:
Remove an assert that was added by r99035. It was added based on a comment in the code, but not tested.
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::selectOption):
LayoutTests:
Re-enable test after removing an erroneous assert.
* platform/mac/test_expectations.txt:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (99513 => 99514)
--- trunk/LayoutTests/ChangeLog 2011-11-08 02:25:20 UTC (rev 99513)
+++ trunk/LayoutTests/ChangeLog 2011-11-08 02:25:59 UTC (rev 99514)
@@ -1,3 +1,14 @@
+2011-11-07 Chris Fleizach <cfleiz...@apple.com>
+
+ REGRESSION(r99025-r99037): platform/mac/accessibility/select-element-selection-with-optgroups.html is asserting
+ https://bugs.webkit.org/show_bug.cgi?id=71421
+
+ Reviewed by Ryosuke Niwa.
+
+ Re-enable test after removing an erroneous assert.
+
+ * platform/mac/test_expectations.txt:
+
2011-11-07 Ariya Hidayat <ar...@sencha.com>
"use strict" can not contain escape sequences or line continuation
Modified: trunk/LayoutTests/platform/mac/test_expectations.txt (99513 => 99514)
--- trunk/LayoutTests/platform/mac/test_expectations.txt 2011-11-08 02:25:20 UTC (rev 99513)
+++ trunk/LayoutTests/platform/mac/test_expectations.txt 2011-11-08 02:25:59 UTC (rev 99514)
@@ -31,5 +31,3 @@
BUGWK67007 DEBUG : fast/ruby/generated-before-and-after-counter-doesnt-crash.html = CRASH
BUGWK69999 RELEASE : http/tests/security/contentSecurityPolicy/media-src-allowed.html = TEXT PASS
-
-BUGWK71421 DEBUG : platform/mac/accessibility/select-element-selection-with-optgroups.html = CRASH
Modified: trunk/Source/WebCore/ChangeLog (99513 => 99514)
--- trunk/Source/WebCore/ChangeLog 2011-11-08 02:25:20 UTC (rev 99513)
+++ trunk/Source/WebCore/ChangeLog 2011-11-08 02:25:59 UTC (rev 99514)
@@ -1,3 +1,15 @@
+2011-11-07 Chris Fleizach <cfleiz...@apple.com>
+
+ REGRESSION(r99025-r99037): platform/mac/accessibility/select-element-selection-with-optgroups.html is asserting
+ https://bugs.webkit.org/show_bug.cgi?id=71421
+
+ Reviewed by Ryosuke Niwa.
+
+ Remove an assert that was added by r99035. It was added based on a comment in the code, but not tested.
+
+ * html/HTMLSelectElement.cpp:
+ (WebCore::HTMLSelectElement::selectOption):
+
2011-11-07 Emil A Eklund <e...@chromium.org>
Revert platform and scrolling to ints
Modified: trunk/Source/WebCore/html/HTMLSelectElement.cpp (99513 => 99514)
--- trunk/Source/WebCore/html/HTMLSelectElement.cpp 2011-11-08 02:25:20 UTC (rev 99513)
+++ trunk/Source/WebCore/html/HTMLSelectElement.cpp 2011-11-08 02:25:59 UTC (rev 99514)
@@ -788,9 +788,7 @@
scrollToSelection();
- if (!usesMenuList())
- ASSERT(!(flags & DispatchChangeEvent));
- else {
+ if (usesMenuList()) {
m_isProcessingUserDrivenChange = flags & UserDriven;
if (flags & DispatchChangeEvent)
dispatchChangeEventForMenuList();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
