Title: [216106] trunk/Source
- Revision
- 216106
- Author
- dba...@webkit.org
- Date
- 2017-05-02 16:15:19 -0700 (Tue, 02 May 2017)
Log Message
Source/WebCore:
Improve scrolling tree logging
https://bugs.webkit.org/show_bug.cgi?id=171574
Patch by Simon Fraser <simon.fra...@apple.com> on 2017-05-02
Reviewed by Tim Horton.
Make a call to showScrollingStateTree() print debugging-related information like node and layer IDs.
Required fixing scrolling state tree nodes to respect ScrollingStateTreeAsTextBehavior, and fixing
fixed and sticky nodes to call super.
Also enhance compositing logging to show layer IDs, and to log for layer scrolling tree registration.
* page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::scrollingStateTreeAsText):
* page/scrolling/AsyncScrollingCoordinator.h:
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::scrollingStateTreeAsText):
* page/scrolling/ScrollingCoordinator.h:
* page/scrolling/ScrollingStateFixedNode.cpp:
(WebCore::ScrollingStateFixedNode::dumpProperties):
* page/scrolling/ScrollingStateNode.cpp:
(WebCore::ScrollingStateNode::dumpProperties):
(WebCore::ScrollingStateNode::scrollingStateTreeAsText):
* page/scrolling/ScrollingStateNode.h:
* page/scrolling/ScrollingStateScrollingNode.cpp:
(WebCore::ScrollingStateScrollingNode::dumpProperties):
* page/scrolling/ScrollingStateStickyNode.cpp:
(WebCore::ScrollingStateStickyNode::dumpProperties):
* page/scrolling/ScrollingStateTree.cpp:
(showScrollingStateTree):
* page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::commitTreeState):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::detachFromScrollingCoordinator):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::logLayerInfo):
(WebCore::RenderLayerCompositor::updateScrollCoordinatedLayer):
Source/WTF:
Fix the build after <https://trac.webkit.org/changeset/216102>
(https://bugs.webkit.org/show_bug.cgi?id=170925)
Export into global scope ASCIICaseInsensitiveStringViewHashTranslator.
Also fix indentation of member functions of ASCIICaseInsensitiveStringViewHashTranslator.
* wtf/text/StringHash.h:
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (216105 => 216106)
--- trunk/Source/WTF/ChangeLog 2017-05-02 23:07:35 UTC (rev 216105)
+++ trunk/Source/WTF/ChangeLog 2017-05-02 23:15:19 UTC (rev 216106)
@@ -14,12 +14,13 @@
Using StringView.split() instead of String.split() in some places
https://bugs.webkit.org/show_bug.cgi?id=170925
- Reviewed by Darin Adler.
+ Reviewed by Darin Adler and Sam Weinig.
- Add HashMap::get() overload that takes a HashTranslator.
+ * wtf/HashMap.h: Add HashMap::get() overload that takes a HashTranslator.
+ * wtf/text/StringHash.h:
+ (WebCore::ASCIICaseInsensitiveStringViewHashTranslator::hash): Added.
+ (WebCore::ASCIICaseInsensitiveStringViewHashTranslator::equal): Added.
- * wtf/HashMap.h:
-
2017-05-01 Dan Bernstein <m...@apple.com>
[Xcode] It’s easy to accidentally install a WTF header outside /usr/local/include/wtf
Modified: trunk/Source/WebCore/ChangeLog (216105 => 216106)
--- trunk/Source/WebCore/ChangeLog 2017-05-02 23:07:35 UTC (rev 216105)
+++ trunk/Source/WebCore/ChangeLog 2017-05-02 23:15:19 UTC (rev 216106)
@@ -42,7 +42,7 @@
Using StringView.split() instead of String.split() in some places
https://bugs.webkit.org/show_bug.cgi?id=170925
- Reviewed by Darin Adler.
+ Reviewed by Darin Adler and Sam Weinig.
Replace some uses of String.split() with StringView.split() (added in r211087) as the latter
avoids the need to allocate an intermediary Vector of substrings. Instead StringView.split()
@@ -51,8 +51,6 @@
No functionality changed. So, no new tests.
* accessibility/AccessibilityObject.cpp: Convert some typedefs to modern C++ using declarations.
- (WebCore::ASCIICaseInsensitiveStringViewHashTranslator::hash): Added.
- (WebCore::ASCIICaseInsensitiveStringViewHashTranslator::equal): Added.
(WebCore::AccessibilityObject::ariaRoleToWebCoreRole): Modified code to use StringView.split().
(WebCore::AccessibilityObject::elementsFromAttribute): Ditto.
* dom/TreeScope.cpp:
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
