Title: [216245] trunk
- Revision
- 216245
- Author
- commit-qu...@webkit.org
- Date
- 2017-05-05 08:49:54 -0700 (Fri, 05 May 2017)
Log Message
REGRESSION (r215951): LayoutTest media/modern-media-controls/placard-support/placard-support-pip.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=171610
<rdar://problem/31976820>
Patch by Jeremy Jones <jere...@apple.com> on 2017-05-05
Reviewed by Eric Carlson.
Source/WebKit/mac:
Fullscreen state gets confused because WK1 WebChromeClient doesn't implement exitVideoFullscreenToModeWithoutAnimation.
* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::exitVideoFullscreenToModeWithoutAnimation):
LayoutTests:
enable test: media/modern-media-controls/pip-support/pip-support-click.html
* platform/mac-wk1/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (216244 => 216245)
--- trunk/LayoutTests/ChangeLog 2017-05-05 15:33:18 UTC (rev 216244)
+++ trunk/LayoutTests/ChangeLog 2017-05-05 15:49:54 UTC (rev 216245)
@@ -1,3 +1,15 @@
+2017-05-05 Jeremy Jones <jere...@apple.com>
+
+ REGRESSION (r215951): LayoutTest media/modern-media-controls/placard-support/placard-support-pip.html is a flaky crash
+ https://bugs.webkit.org/show_bug.cgi?id=171610
+ <rdar://problem/31976820>
+
+ Reviewed by Eric Carlson.
+
+ enable test: media/modern-media-controls/pip-support/pip-support-click.html
+
+ * platform/mac-wk1/TestExpectations:
+
2017-05-05 Carlos Garcia Campos <cgar...@igalia.com>
Unreviewed GTK+ gardening. Update expectations of tests failing after GST upgrade to 1.10.4.
Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (216244 => 216245)
--- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2017-05-05 15:33:18 UTC (rev 216244)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2017-05-05 15:49:54 UTC (rev 216245)
@@ -347,7 +347,6 @@
webkit.org/b/169117 media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-audio-background.html [ Pass Timeout ]
webkit.org/b/170456 media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-buttons-styles.html [ Pass Timeout ]
webkit.org/b/167752 media/modern-media-controls/icon-button/icon-button-active-state.html [ Pass Timeout ]
-webkit.org/b/171610 media/modern-media-controls/pip-support/pip-support-click.html [ Skip ]
webkit.org/b/167477 [ Debug ] media/modern-media-controls/play-pause-button/play-pause-button.html [ Pass Timeout ]
webkit.org/b/171245 [ Debug ] media/modern-media-controls/scrubber-support/scrubber-support-click.html [ Pass Timeout ]
webkit.org/b/171629 media/modern-media-controls/slider/slider-styles.html [ Pass Timeout ]
Modified: trunk/Source/WebKit/mac/ChangeLog (216244 => 216245)
--- trunk/Source/WebKit/mac/ChangeLog 2017-05-05 15:33:18 UTC (rev 216244)
+++ trunk/Source/WebKit/mac/ChangeLog 2017-05-05 15:49:54 UTC (rev 216245)
@@ -1,3 +1,17 @@
+2017-05-05 Jeremy Jones <jere...@apple.com>
+
+ REGRESSION (r215951): LayoutTest media/modern-media-controls/placard-support/placard-support-pip.html is a flaky crash
+ https://bugs.webkit.org/show_bug.cgi?id=171610
+ <rdar://problem/31976820>
+
+ Reviewed by Eric Carlson.
+
+ Fullscreen state gets confused because WK1 WebChromeClient doesn't implement exitVideoFullscreenToModeWithoutAnimation.
+
+ * WebCoreSupport/WebChromeClient.h:
+ * WebCoreSupport/WebChromeClient.mm:
+ (WebChromeClient::exitVideoFullscreenToModeWithoutAnimation):
+
2017-05-04 Commit Queue <commit-qu...@webkit.org>
Unreviewed, rolling out r216206.
Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.h (216244 => 216245)
--- trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.h 2017-05-05 15:33:18 UTC (rev 216244)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.h 2017-05-05 15:49:54 UTC (rev 216245)
@@ -187,6 +187,7 @@
bool supportsVideoFullscreen(WebCore::HTMLMediaElementEnums::VideoFullscreenMode) final;
void enterVideoFullscreenForVideoElement(WebCore::HTMLVideoElement&, WebCore::HTMLMediaElementEnums::VideoFullscreenMode) final;
void exitVideoFullscreenForVideoElement(WebCore::HTMLVideoElement&) final;
+ void exitVideoFullscreenToModeWithoutAnimation(WebCore::HTMLVideoElement&, WebCore::HTMLMediaElementEnums::VideoFullscreenMode) final;
#endif
#if ENABLE(FULLSCREEN_API)
Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm (216244 => 216245)
--- trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm 2017-05-05 15:33:18 UTC (rev 216244)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm 2017-05-05 15:49:54 UTC (rev 216245)
@@ -974,6 +974,13 @@
END_BLOCK_OBJC_EXCEPTIONS;
}
+void WebChromeClient::exitVideoFullscreenToModeWithoutAnimation(HTMLVideoElement& videoElement, HTMLMediaElementEnums::VideoFullscreenMode targetMode)
+{
+ BEGIN_BLOCK_OBJC_EXCEPTIONS;
+ [m_webView _exitVideoFullscreen];
+ END_BLOCK_OBJC_EXCEPTIONS;
+}
+
#endif // ENABLE(VIDEO)
#if ENABLE(VIDEO) && PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
