Title: [216285] trunk/Source/WebCore
- Revision
- 216285
- Author
- commit-qu...@webkit.org
- Date
- 2017-05-05 15:50:56 -0700 (Fri, 05 May 2017)
Log Message
TURNS gathering is not working properly
https://bugs.webkit.org/show_bug.cgi?id=171747
Patch by Youenn Fablet <you...@apple.com> on 2017-05-05
Reviewed by Eric Carlson.
Did manual testing on real TURNS servers.
* Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:
(WebCore::configurationFromMediaEndpointConfiguration): Disabling TURNS servers gathering.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (216284 => 216285)
--- trunk/Source/WebCore/ChangeLog 2017-05-05 22:48:59 UTC (rev 216284)
+++ trunk/Source/WebCore/ChangeLog 2017-05-05 22:50:56 UTC (rev 216285)
@@ -1,3 +1,15 @@
+2017-05-05 Youenn Fablet <you...@apple.com>
+
+ TURNS gathering is not working properly
+ https://bugs.webkit.org/show_bug.cgi?id=171747
+
+ Reviewed by Eric Carlson.
+
+ Did manual testing on real TURNS servers.
+
+ * Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:
+ (WebCore::configurationFromMediaEndpointConfiguration): Disabling TURNS servers gathering.
+
2017-05-05 Ryan Haddad <ryanhad...@apple.com>
Unreviewed, rolling out r216275.
Modified: trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp (216284 => 216285)
--- trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp 2017-05-05 22:48:59 UTC (rev 216284)
+++ trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp 2017-05-05 22:50:56 UTC (rev 216285)
@@ -88,9 +88,14 @@
webrtc::PeerConnectionInterface::IceServer iceServer;
iceServer.username = server.username.utf8().data();
iceServer.password = server.credential.utf8().data();
- for (auto& url : server.urls)
- iceServer.urls.push_back({ url.string().utf8().data() });
- rtcConfiguration.servers.push_back(WTFMove(iceServer));
+ for (auto& url : server.urls) {
+ // FIXME: If TURNS is failing, the whole ICE candidate gathering is failing.
+ // We should fix that and reactivate TURNS gathering.
+ if (!url.protocolIs("turns"))
+ iceServer.urls.push_back({ url.string().utf8().data() });
+ }
+ if (iceServer.urls.size())
+ rtcConfiguration.servers.push_back(WTFMove(iceServer));
}
rtcConfiguration.ice_candidate_pool_size = configuration.iceCandidatePoolSize;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
