Title: [216405] releases/WebKitGTK/webkit-2.16/Source/WebCore
- Revision
- 216405
- Author
- carlo...@webkit.org
- Date
- 2017-05-08 06:32:45 -0700 (Mon, 08 May 2017)
Log Message
Merge r216343 - [GTK] Cannot sign in with new Google sign-in page
https://bugs.webkit.org/show_bug.cgi?id=171770
Reviewed by Carlos Garcia Campos.
Google's new authentication page does not work with the Firefox user
agent that's required to make various Google websites work. Special-case
accounts.google.com so that it receives our standard user agent.
* platform/UserAgentQuirks.cpp:
(WebCore::isGoogle):
(WebCore::urlRequiresFirefoxBrowser):
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog (216404 => 216405)
--- releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog 2017-05-08 13:32:39 UTC (rev 216404)
+++ releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog 2017-05-08 13:32:45 UTC (rev 216405)
@@ -1,3 +1,18 @@
+2017-05-07 Michael Catanzaro <mcatanz...@igalia.com>
+
+ [GTK] Cannot sign in with new Google sign-in page
+ https://bugs.webkit.org/show_bug.cgi?id=171770
+
+ Reviewed by Carlos Garcia Campos.
+
+ Google's new authentication page does not work with the Firefox user
+ agent that's required to make various Google websites work. Special-case
+ accounts.google.com so that it receives our standard user agent.
+
+ * platform/UserAgentQuirks.cpp:
+ (WebCore::isGoogle):
+ (WebCore::urlRequiresFirefoxBrowser):
+
2017-05-03 Michael Catanzaro <mcatanz...@igalia.com>
YouTube user agent quirk breaks new YouTube
Modified: releases/WebKitGTK/webkit-2.16/Source/WebCore/platform/UserAgentQuirks.cpp (216404 => 216405)
--- releases/WebKitGTK/webkit-2.16/Source/WebCore/platform/UserAgentQuirks.cpp 2017-05-08 13:32:39 UTC (rev 216404)
+++ releases/WebKitGTK/webkit-2.16/Source/WebCore/platform/UserAgentQuirks.cpp 2017-05-08 13:32:45 UTC (rev 216405)
@@ -41,8 +41,9 @@
// Our Google UA is *very* complicated to get right. Read
// https://webkit.org/b/142074 carefully before changing. Test that Earth
// view is available in Google Maps. Test Google Calendar. Test downloading
- // the Hangouts browser plugin. Change platformVersionForUAString() to
- // return "FreeBSD amd64" and test Maps and Calendar again.
+ // the Hangouts browser plugin. Test logging out and logging in to a Google
+ // account. Change platformVersionForUAString() to return "FreeBSD amd64"
+ // and test everything again.
if (baseDomain.startsWith("google."))
return true;
if (baseDomain == "gstatic.com")
@@ -75,7 +76,7 @@
static bool urlRequiresFirefoxBrowser(const URL& url)
{
- return isGoogle(url);
+ return isGoogle(url) && url.host() != "accounts.google.com";
}
static bool urlRequiresMacintoshPlatform(const URL& url)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
