Title: [99624] trunk/Source/WebKit/chromium
- Revision
- 99624
- Author
- fsam...@chromium.org
- Date
- 2011-11-08 15:49:44 -0800 (Tue, 08 Nov 2011)
Log Message
Delete WebViewimpl::scalePage
https://bugs.webkit.org/show_bug.cgi?id=71711
Reviewed by Darin Fisher.
Once this patch lands: http://codereview.chromium.org/8477033
WebViewImpl::scalePage will no longer be used in Chromium and
can safely be deleted.
* public/WebView.h:
* src/WebViewImpl.cpp:
* src/WebViewImpl.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (99623 => 99624)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-11-08 23:48:53 UTC (rev 99623)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-11-08 23:49:44 UTC (rev 99624)
@@ -1,3 +1,19 @@
+2011-11-08 Fady Samuel <fsam...@chromium.org>
+
+ Delete WebViewimpl::scalePage
+ https://bugs.webkit.org/show_bug.cgi?id=71711
+
+ Reviewed by Darin Fisher.
+
+ Once this patch lands: http://codereview.chromium.org/8477033
+
+ WebViewImpl::scalePage will no longer be used in Chromium and
+ can safely be deleted.
+
+ * public/WebView.h:
+ * src/WebViewImpl.cpp:
+ * src/WebViewImpl.h:
+
2011-11-08 Joshua Bell <jsb...@chromium.org>
IndexedDB: implement compound (array) key support
Modified: trunk/Source/WebKit/chromium/public/WebView.h (99623 => 99624)
--- trunk/Source/WebKit/chromium/public/WebView.h 2011-11-08 23:48:53 UTC (rev 99623)
+++ trunk/Source/WebKit/chromium/public/WebView.h 2011-11-08 23:49:44 UTC (rev 99624)
@@ -211,9 +211,6 @@
// is scaled up, < 1.0 is scaled down.
virtual float pageScaleFactor() const = 0;
- // FIXME: Delete this once Chromium side has been updated.
- virtual void scalePage(float scaleFactor, const WebPoint& origin) = 0;
-
// Scales a page by a factor of scaleFactor and then sets a scroll position to (x, y).
// setPageScaleFactor() magnifies and shrinks a page without affecting layout.
// On the other hand, zooming affects layout of the page.
Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (99623 => 99624)
--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2011-11-08 23:48:53 UTC (rev 99623)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2011-11-08 23:49:44 UTC (rev 99624)
@@ -1847,11 +1847,6 @@
return page()->pageScaleFactor();
}
-void WebViewImpl::scalePage(float scaleFactor, const WebPoint& origin)
-{
- setPageScaleFactor(scaleFactor, origin);
-}
-
void WebViewImpl::setPageScaleFactor(float scaleFactor, const WebPoint& origin)
{
if (!page())
Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.h (99623 => 99624)
--- trunk/Source/WebKit/chromium/src/WebViewImpl.h 2011-11-08 23:48:53 UTC (rev 99623)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.h 2011-11-08 23:49:44 UTC (rev 99624)
@@ -158,7 +158,6 @@
virtual void zoomLimitsChanged(double minimumZoomLevel,
double maximumZoomLevel);
virtual float pageScaleFactor() const;
- virtual void scalePage(float scaleFactor, const WebPoint& origin);
virtual void setPageScaleFactor(float scaleFactor, const WebPoint& origin);
virtual float deviceScaleFactor() const;
virtual void setDeviceScaleFactor(float);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
