Modified: trunk/LayoutTests/ChangeLog (217825 => 217826)
--- trunk/LayoutTests/ChangeLog 2017-06-06 11:46:31 UTC (rev 217825)
+++ trunk/LayoutTests/ChangeLog 2017-06-06 14:30:47 UTC (rev 217826)
@@ -1,3 +1,16 @@
+2017-06-06 Antoine Quint <grao...@apple.com>
+
+ Update modern media controls testing utilities
+ https://bugs.webkit.org/show_bug.cgi?id=172976
+ <rdar://problem/32588432>
+
+ Reviewed by Eric Carlson.
+
+ Update the list of CSS files to load to match the current list of
+ existing CSS files in the modern-media-controls module.
+
+ * media/modern-media-controls/resources/media-controls-loader.js:
+
2017-06-05 Antoine Quint <grao...@apple.com>
Update media controls to match latest design specs
Modified: trunk/LayoutTests/media/modern-media-controls/resources/media-controls-loader.js (217825 => 217826)
--- trunk/LayoutTests/media/modern-media-controls/resources/media-controls-loader.js 2017-06-06 11:46:31 UTC (rev 217825)
+++ trunk/LayoutTests/media/modern-media-controls/resources/media-controls-loader.js 2017-06-06 14:30:47 UTC (rev 217826)
@@ -3,7 +3,7 @@
const layoutTestsPath = window.location.href.substr(0, window.location.href.indexOf("/LayoutTests/"));
const modulePath = layoutTestsPath ? layoutTestsPath + "/Source/WebCore/Modules/modern-media-controls" : "/modern-media-controls";
- ["media-controls", "background-tint", "volume-slider", "slider", "button", "start-button", "icon-button", "airplay-button", "time-label", "status-label", "controls-bar", "macos-media-controls", "macos-inline-media-controls", "macos-compact-inline-media-controls", "macos-fullscreen-media-controls", "ios-inline-media-controls", "buttons-container", "placard", "tracks-panel"].forEach(cssFile => {
+ ["activity-indicator", "airplay-button", "background-tint", "button", "buttons-container", "controls-bar", "inline-media-controls", "macos-fullscreen-media-controls", "macos-inline-media-controls", "media-controls", "media-document", "placard", "slider", "status-label", "text-tracks", "time-label", "tracks-panel"].forEach(cssFile => {
document.write(`<link rel="stylesheet" type="text/css" href=""
});
Modified: trunk/Source/WebCore/ChangeLog (217825 => 217826)
--- trunk/Source/WebCore/ChangeLog 2017-06-06 11:46:31 UTC (rev 217825)
+++ trunk/Source/WebCore/ChangeLog 2017-06-06 14:30:47 UTC (rev 217826)
@@ -1,3 +1,19 @@
+2017-06-06 Antoine Quint <grao...@apple.com>
+
+ Update modern media controls testing utilities
+ https://bugs.webkit.org/show_bug.cgi?id=172976
+ <rdar://problem/32588432>
+
+ Reviewed by Eric Carlson.
+
+ Stop logging an error when we're not able to load UI Strings since UI strings
+ are not defined in the majority of modern-media-controls tests as we load the
+ code directly from the modern-media-controls module and can't reach into the
+ English.lproj directory, nor is it necessary.
+
+ * Modules/modern-media-controls/main.js:
+ (UIString):
+
2017-06-06 Carlos Garcia Campos <cgar...@igalia.com>
[GStreamer] Use the same draw timer and mutex when AC disabled or building without OpenGL
Modified: trunk/Source/WebCore/Modules/modern-media-controls/main.js (217825 => 217826)
--- trunk/Source/WebCore/Modules/modern-media-controls/main.js 2017-06-06 11:46:31 UTC (rev 217825)
+++ trunk/Source/WebCore/Modules/modern-media-controls/main.js 2017-06-06 14:30:47 UTC (rev 217826)
@@ -39,9 +39,7 @@
let localizedStrings = {};
try {
localizedStrings = UIStrings;
- } catch (error) {
- console.error("Could not find localized strings");
- }
+ } catch (error) {}
if (localizedStrings[string])
return localizedStrings[string];
