Title: [217845] trunk/Source
- Revision
- 217845
- Author
- jer.no...@apple.com
- Date
- 2017-06-06 11:28:55 -0700 (Tue, 06 Jun 2017)
Log Message
[Cocoa] Set defaults for mediaContentTypesRequiringHardwareSupport setting
https://bugs.webkit.org/show_bug.cgi?id=173008
Reviewed by Eric Carlson.
Source/WebKit/mac:
Add a private preference (with default) for the mediaContentTypesRequiringHardwareSupport WebCore setting.
* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences mediaUserGestureInheritsFromDocument]):
(-[WebPreferences setMediaUserGestureInheritsFromDocument:]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKit2:
* UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration init]):
Modified Paths
Diff
Modified: trunk/Source/WebKit/mac/ChangeLog (217844 => 217845)
--- trunk/Source/WebKit/mac/ChangeLog 2017-06-06 18:27:53 UTC (rev 217844)
+++ trunk/Source/WebKit/mac/ChangeLog 2017-06-06 18:28:55 UTC (rev 217845)
@@ -1,3 +1,21 @@
+2017-06-06 Jer Noble <jer.no...@apple.com>
+
+ [Cocoa] Set defaults for mediaContentTypesRequiringHardwareSupport setting
+ https://bugs.webkit.org/show_bug.cgi?id=173008
+
+ Reviewed by Eric Carlson.
+
+ Add a private preference (with default) for the mediaContentTypesRequiringHardwareSupport WebCore setting.
+
+ * WebView/WebPreferenceKeysPrivate.h:
+ * WebView/WebPreferences.mm:
+ (+[WebPreferences initialize]):
+ (-[WebPreferences mediaUserGestureInheritsFromDocument]):
+ (-[WebPreferences setMediaUserGestureInheritsFromDocument:]):
+ * WebView/WebPreferencesPrivate.h:
+ * WebView/WebView.mm:
+ (-[WebView _preferencesChanged:]):
+
2017-06-06 Youenn Fablet <you...@apple.com>
Add an option to disable getUserMedia prompt in case of mock capture sources
Modified: trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h (217844 => 217845)
--- trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h 2017-06-06 18:27:53 UTC (rev 217844)
+++ trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h 2017-06-06 18:28:55 UTC (rev 217845)
@@ -237,3 +237,4 @@
#define WebKitDisplayContentsEnabledPreferenceKey @"WebKitDisplayContentsEnabled"
#define WebKitUserTimingEnabledPreferenceKey @"WebKitUserTimingEnabled"
#define WebKitResourceTimingEnabledPreferenceKey @"WebKitResourceTimingEnabled"
+#define WebKitMediaContentTypesRequiringHardwareSupportPreferenceKey @"WebKitMediaContentTypesRequiringHardwareSupport"
Modified: trunk/Source/WebKit/mac/WebView/WebPreferences.mm (217844 => 217845)
--- trunk/Source/WebKit/mac/WebView/WebPreferences.mm 2017-06-06 18:27:53 UTC (rev 217844)
+++ trunk/Source/WebKit/mac/WebView/WebPreferences.mm 2017-06-06 18:28:55 UTC (rev 217845)
@@ -671,6 +671,7 @@
@NO, WebKitResourceTimingEnabledPreferenceKey,
@NO, WebKitCredentialManagementEnabledPreferenceKey,
@NO, WebKitMediaUserGestureInheritsFromDocument,
+ @"video/mp4;codecs=hvc1:video/mp4;codecs=hev1", WebKitMediaContentTypesRequiringHardwareSupportPreferenceKey,
nil];
#if !PLATFORM(IOS)
@@ -3096,6 +3097,15 @@
}
#endif
+- (NSString *)mediaContentTypesRequiringHardwareSupport
+{
+ return [self _stringValueForKey:WebKitMediaContentTypesRequiringHardwareSupportPreferenceKey];
+}
+
+- (void)setMediaContentTypesRequiringHardwareSupport:(NSString *)value
+{
+ [self _setStringValue:value forKey:WebKitMediaContentTypesRequiringHardwareSupportPreferenceKey];
+}
@end
@implementation WebPreferences (WebInternal)
Modified: trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h (217844 => 217845)
--- trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h 2017-06-06 18:27:53 UTC (rev 217844)
+++ trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h 2017-06-06 18:28:55 UTC (rev 217845)
@@ -566,4 +566,6 @@
@property (nonatomic) BOOL quickLookDocumentSavingEnabled;
#endif
+@property (nonatomic) NSString *mediaContentTypesRequiringHardwareSupport;
+
@end
Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (217844 => 217845)
--- trunk/Source/WebKit/mac/WebView/WebView.mm 2017-06-06 18:27:53 UTC (rev 217844)
+++ trunk/Source/WebKit/mac/WebView/WebView.mm 2017-06-06 18:28:55 UTC (rev 217845)
@@ -2879,6 +2879,7 @@
settings.setJavaScriptCanOpenWindowsAutomatically([preferences _javascript_CanOpenWindowsAutomatically] || shouldAllowWindowOpenWithoutUserGesture());
settings.setVisualViewportEnabled([preferences visualViewportEnabled]);
+ settings.setMediaContentTypesRequiringHardwareSupport([preferences mediaContentTypesRequiringHardwareSupport]);
switch ([preferences storageBlockingPolicy]) {
case WebAllowAllStorage:
Modified: trunk/Source/WebKit2/ChangeLog (217844 => 217845)
--- trunk/Source/WebKit2/ChangeLog 2017-06-06 18:27:53 UTC (rev 217844)
+++ trunk/Source/WebKit2/ChangeLog 2017-06-06 18:28:55 UTC (rev 217845)
@@ -1,3 +1,13 @@
+2017-06-06 Jer Noble <jer.no...@apple.com>
+
+ [Cocoa] Set defaults for mediaContentTypesRequiringHardwareSupport setting
+ https://bugs.webkit.org/show_bug.cgi?id=173008
+
+ Reviewed by Eric Carlson.
+
+ * UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
+ (-[WKWebViewConfiguration init]):
+
2017-06-06 Joseph Pecoraro <pecor...@apple.com>
Move Resource Timing / User Timing from experimental features into main preferences
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm (217844 => 217845)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm 2017-06-06 18:27:53 UTC (rev 217844)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm 2017-06-06 18:28:55 UTC (rev 217845)
@@ -200,6 +200,8 @@
_allowsBlockSelection = [[NSUserDefaults standardUserDefaults] boolForKey:@"WebKitDebugAllowBlockSelection"];
#endif
+ _mediaContentTypesRequiringHardwareSupport = @"video/mp4;codecs=hvc1:video/mp4;codecs=hev1";
+
return self;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
