Title: [218091] trunk/Tools
Revision
218091
Author
carlo...@webkit.org
Date
2017-06-12 01:14:32 -0700 (Mon, 12 Jun 2017)

Log Message

Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/notification after r216641.

Notifications are no longer cleared on page navigation.

* TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
(testWebViewNotification):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (218090 => 218091)


--- trunk/Tools/ChangeLog	2017-06-12 06:54:04 UTC (rev 218090)
+++ trunk/Tools/ChangeLog	2017-06-12 08:14:32 UTC (rev 218091)
@@ -1,3 +1,12 @@
+2017-06-12  Carlos Garcia Campos  <cgar...@igalia.com>
+
+        Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/notification after r216641.
+
+        Notifications are no longer cleared on page navigation.
+
+        * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
+        (testWebViewNotification):
+
 2017-06-11  Carlos Garcia Campos  <cgar...@igalia.com>
 
         Unreviewed. Fix GTK+ test /webkit2/WebKitAutomationSession/request-session after r217831.

Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp (218090 => 218091)


--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp	2017-06-12 06:54:04 UTC (rev 218090)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp	2017-06-12 08:14:32 UTC (rev 218091)
@@ -883,11 +883,6 @@
     test->requestNotificationAndWaitUntilShown(title, body, tag);
     test->requestNotificationAndWaitUntilShown(title, body, tag);
     g_assert(test->m_event == NotificationWebViewTest::Shown);
-
-    // Notification should be closed when navigating to a different webpage.
-    test->loadURI(gServer->getURIForPath("/").data());
-    test->waitUntilLoadFinished();
-    g_assert(test->m_event == NotificationWebViewTest::Closed);
 }
 
 static void setInitialNotificationPermissionsAllowedCallback(WebKitWebContext* context, NotificationWebViewTest* test)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to