Log Message
[EFL] Remove unnecessary casts when creating the WebCoreSupport objects in ewk_view. https://bugs.webkit.org/show_bug.cgi?id=71891
Patch by Raphael Kubo da Costa <k...@profusion.mobi> on 2011-11-09 Reviewed by Antonio Gomes. This is C++ code, there is no need to cast the new objects to their parents when creating them. * ewk/ewk_view.cpp: (_ewk_view_priv_new):
Modified Paths
Diff
Modified: trunk/Source/WebKit/efl/ChangeLog (99727 => 99728)
--- trunk/Source/WebKit/efl/ChangeLog 2011-11-09 17:32:22 UTC (rev 99727)
+++ trunk/Source/WebKit/efl/ChangeLog 2011-11-09 17:32:47 UTC (rev 99728)
@@ -1,3 +1,16 @@
+2011-11-09 Raphael Kubo da Costa <k...@profusion.mobi>
+
+ [EFL] Remove unnecessary casts when creating the WebCoreSupport objects in ewk_view.
+ https://bugs.webkit.org/show_bug.cgi?id=71891
+
+ Reviewed by Antonio Gomes.
+
+ This is C++ code, there is no need to cast the new objects to their
+ parents when creating them.
+
+ * ewk/ewk_view.cpp:
+ (_ewk_view_priv_new):
+
2011-11-09 Tomasz Morawski <t.moraw...@samsung.com>
[EFL] Removed unused variable
Modified: trunk/Source/WebKit/efl/ewk/ewk_view.cpp (99727 => 99728)
--- trunk/Source/WebKit/efl/ewk/ewk_view.cpp 2011-11-09 17:32:22 UTC (rev 99727)
+++ trunk/Source/WebKit/efl/ewk/ewk_view.cpp 2011-11-09 17:32:47 UTC (rev 99728)
@@ -603,13 +603,13 @@
}
WebCore::Page::PageClients pageClients;
- pageClients.chromeClient = static_cast<WebCore::ChromeClient*>(new WebCore::ChromeClientEfl(smartData->self));
- pageClients.editorClient = static_cast<WebCore::EditorClient*>(new WebCore::EditorClientEfl(smartData->self));
- pageClients.dragClient = static_cast<WebCore::DragClient*>(new WebCore::DragClientEfl);
- pageClients.inspectorClient = static_cast<WebCore::InspectorClient*>(new WebCore::InspectorClientEfl);
+ pageClients.chromeClient = new WebCore::ChromeClientEfl(smartData->self);
+ pageClients.editorClient = new WebCore::EditorClientEfl(smartData->self);
+ pageClients.dragClient = new WebCore::DragClientEfl;
+ pageClients.inspectorClient = new WebCore::InspectorClientEfl;
#if ENABLE(DEVICE_ORIENTATION)
- pageClients.deviceMotionClient = static_cast<WebCore::DeviceMotionClient*>(new WebCore::DeviceMotionClientEfl);
- pageClients.deviceOrientationClient = static_cast<WebCore::DeviceOrientationClient*>(new WebCore::DeviceOrientationClientEfl);
+ pageClients.deviceMotionClient = new WebCore::DeviceMotionClientEfl;
+ pageClients.deviceOrientationClient = new WebCore::DeviceOrientationClientEfl;
#endif
priv->page = new WebCore::Page(pageClients);
if (!priv->page) {
_______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
