Title: [219108] trunk/Source/WebCore
- Revision
- 219108
- Author
- [email protected]
- Date
- 2017-07-03 16:44:39 -0700 (Mon, 03 Jul 2017)
Log Message
Null RenderLayer* deref in FrameView::adjustTiledBackingCoverage()
https://bugs.webkit.org/show_bug.cgi?id=174106
<rdar://problem/33085838>
Reviewed by Tim Horton.
I haven't been able to reproduce this crash locally, but I have seen
video of someone who can, so here's a null check for the RenderView::layer()
which could be null if we're called between RenderView construction
and the first callback to RenderLayerModelObject::styleDidChange().
* page/FrameView.cpp:
(WebCore::FrameView::adjustTiledBackingCoverage):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (219107 => 219108)
--- trunk/Source/WebCore/ChangeLog 2017-07-03 23:34:46 UTC (rev 219107)
+++ trunk/Source/WebCore/ChangeLog 2017-07-03 23:44:39 UTC (rev 219108)
@@ -1,3 +1,19 @@
+2017-07-03 Andreas Kling <[email protected]>
+
+ Null RenderLayer* deref in FrameView::adjustTiledBackingCoverage()
+ https://bugs.webkit.org/show_bug.cgi?id=174106
+ <rdar://problem/33085838>
+
+ Reviewed by Tim Horton.
+
+ I haven't been able to reproduce this crash locally, but I have seen
+ video of someone who can, so here's a null check for the RenderView::layer()
+ which could be null if we're called between RenderView construction
+ and the first callback to RenderLayerModelObject::styleDidChange().
+
+ * page/FrameView.cpp:
+ (WebCore::FrameView::adjustTiledBackingCoverage):
+
2017-07-03 Matt Rajca <[email protected]>
Add/remove appropriate media element behavior restrictions when updateWebsitePolicies is called
Modified: trunk/Source/WebCore/page/FrameView.cpp (219107 => 219108)
--- trunk/Source/WebCore/page/FrameView.cpp 2017-07-03 23:34:46 UTC (rev 219107)
+++ trunk/Source/WebCore/page/FrameView.cpp 2017-07-03 23:44:39 UTC (rev 219108)
@@ -2937,7 +2937,7 @@
enableSpeculativeTilingIfNeeded();
RenderView* renderView = this->renderView();
- if (renderView && renderView->layer()->backing())
+ if (renderView && renderView->layer() && renderView->layer()->backing())
renderView->layer()->backing()->adjustTiledBackingCoverage();
#if PLATFORM(IOS)
if (LegacyTileCache* tileCache = legacyTileCache())
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
