Title: [219201] trunk/Source/WebCore
- Revision
- 219201
- Author
- [email protected]
- Date
- 2017-07-06 09:49:16 -0700 (Thu, 06 Jul 2017)
Log Message
Add release assert to explore crash for <rdar://problem/32908525>
Reviewed by Brady Eidson.
* Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::~UniqueIDBDatabase): Add
release assert to catch cases when the IDBBackingStore is not
deleted before the UniqueIDBDatabase is destroyed. The
IDBBackingStore should always be released on the database
thread.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (219200 => 219201)
--- trunk/Source/WebCore/ChangeLog 2017-07-06 16:31:34 UTC (rev 219200)
+++ trunk/Source/WebCore/ChangeLog 2017-07-06 16:49:16 UTC (rev 219201)
@@ -1,3 +1,16 @@
+2017-07-06 David Kilzer <[email protected]>
+
+ Add release assert to explore crash for <rdar://problem/32908525>
+
+ Reviewed by Brady Eidson.
+
+ * Modules/indexeddb/server/UniqueIDBDatabase.cpp:
+ (WebCore::IDBServer::UniqueIDBDatabase::~UniqueIDBDatabase): Add
+ release assert to catch cases when the IDBBackingStore is not
+ deleted before the UniqueIDBDatabase is destroyed. The
+ IDBBackingStore should always be released on the database
+ thread.
+
2017-07-06 Matt Lewis <[email protected]>
Unreviewed, rolling out r219178.
Modified: trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp (219200 => 219201)
--- trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp 2017-07-06 16:31:34 UTC (rev 219200)
+++ trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp 2017-07-06 16:49:16 UTC (rev 219201)
@@ -66,6 +66,7 @@
UniqueIDBDatabase::~UniqueIDBDatabase()
{
LOG(IndexedDB, "UniqueIDBDatabase::~UniqueIDBDatabase() (%p) %s", this, m_identifier.debugString().utf8().data());
+ RELEASE_ASSERT(!m_backingStore);
ASSERT(isMainThread());
ASSERT(!hasAnyPendingCallbacks());
ASSERT(!hasUnfinishedTransactions());
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
