Title: [219251] trunk/PerformanceTests
- Revision
- 219251
- Author
- [email protected]
- Date
- 2017-07-07 03:25:00 -0700 (Fri, 07 Jul 2017)
Log Message
Speedometer 2.0: Fix vanilla JS example
https://bugs.webkit.org/show_bug.cgi?id=174246
Patch by Mathias Bynens <[email protected]> on 2017-07-07
Reviewed by Ryosuke Niwa.
Previously, all TODO items were assigned an ID of `null`. This patch
fixes that bug. Manually deleting items now works again.
* Speedometer/resources/todomvc/vanilla-examples/vanillajs/index.html: Made title consistent.
* Speedometer/resources/todomvc/vanilla-examples/vanillajs/js/store.js: Fixed bug with deleting items.
* Speedometer/resources/todomvc/vanilla-examples/vanillajs/readme.md: Added docs.
Modified Paths
Diff
Modified: trunk/PerformanceTests/ChangeLog (219250 => 219251)
--- trunk/PerformanceTests/ChangeLog 2017-07-07 08:30:08 UTC (rev 219250)
+++ trunk/PerformanceTests/ChangeLog 2017-07-07 10:25:00 UTC (rev 219251)
@@ -1,3 +1,17 @@
+2017-07-07 Mathias Bynens <[email protected]>
+
+ Speedometer 2.0: Fix vanilla JS example
+ https://bugs.webkit.org/show_bug.cgi?id=174246
+
+ Reviewed by Ryosuke Niwa.
+
+ Previously, all TODO items were assigned an ID of `null`. This patch
+ fixes that bug. Manually deleting items now works again.
+
+ * Speedometer/resources/todomvc/vanilla-examples/vanillajs/index.html: Made title consistent.
+ * Speedometer/resources/todomvc/vanilla-examples/vanillajs/js/store.js: Fixed bug with deleting items.
+ * Speedometer/resources/todomvc/vanilla-examples/vanillajs/readme.md: Added docs.
+
2017-07-06 Myles C. Maxfield <[email protected]>
[Cocoa] Improve performance of font lookups
Modified: trunk/PerformanceTests/Speedometer/resources/todomvc/vanilla-examples/vanillajs/index.html (219250 => 219251)
--- trunk/PerformanceTests/Speedometer/resources/todomvc/vanilla-examples/vanillajs/index.html 2017-07-07 08:30:08 UTC (rev 219250)
+++ trunk/PerformanceTests/Speedometer/resources/todomvc/vanilla-examples/vanillajs/index.html 2017-07-07 10:25:00 UTC (rev 219251)
@@ -2,7 +2,7 @@
<html lang="en" data-framework="_javascript_">
<head>
<meta charset="utf-8">
- <title>VanillaJS • TodoMVC</title>
+ <title>Vanilla _javascript_ TodoMVC example</title>
<link rel="stylesheet" href=""
<link rel="stylesheet" href=""
</head>
Modified: trunk/PerformanceTests/Speedometer/resources/todomvc/vanilla-examples/vanillajs/js/store.js (219250 => 219251)
--- trunk/PerformanceTests/Speedometer/resources/todomvc/vanilla-examples/vanillajs/js/store.js 2017-07-07 08:30:08 UTC (rev 219250)
+++ trunk/PerformanceTests/Speedometer/resources/todomvc/vanilla-examples/vanillajs/js/store.js 2017-07-07 10:25:00 UTC (rev 219251)
@@ -3,7 +3,7 @@
'use strict';
var MemoryStorage = {};
- var id = 1;
+ var ID = 1;
/**
* Creates a new client side storage object and will create an empty
@@ -98,7 +98,7 @@
callback.call(this, todos);
} else {
// Generate an ID
- updateData.id = id++;
+ updateData.id = ID++;
todos.push(updateData);
MemoryStorage[this._dbName] = JSON.stringify(data);
Modified: trunk/PerformanceTests/Speedometer/resources/todomvc/vanilla-examples/vanillajs/readme.md (219250 => 219251)
--- trunk/PerformanceTests/Speedometer/resources/todomvc/vanilla-examples/vanillajs/readme.md 2017-07-07 08:30:08 UTC (rev 219250)
+++ trunk/PerformanceTests/Speedometer/resources/todomvc/vanilla-examples/vanillajs/readme.md 2017-07-07 10:25:00 UTC (rev 219251)
@@ -1,5 +1,10 @@
-# Vanilla _javascript_ TodoMVC Example
+# Speedometer 2.0: Vanilla _javascript_ TodoMVC example
-> _javascript_® (often shortened to JS) is a lightweight, interpreted, object-oriented language with first-class functions, most known as the scripting language for Web pages, but used in many non-browser environments as well such as node.js or Apache CouchDB.
+## Test locally
-> _[_javascript_ - developer.mozilla.org](http://developer.mozilla.org/en-US/docs/_javascript_)
+1. Run a local server from this directory. (You could use [`npm i -g http-server`](https://github.com/indexzero/http-server).)
+2. Open the URL pointing to the local server in your web browser of choice.
+
+## Build
+
+There is no build step for this example.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
