Title: [219264] trunk
- Revision
- 219264
- Author
- [email protected]
- Date
- 2017-07-07 13:05:27 -0700 (Fri, 07 Jul 2017)
Log Message
Unreviewed, rolling out r219257.
The test added in the revision was still extreamly flaky on
all testers.
Reverted changeset:
"[SVG] Leak in SVGAnimatedListPropertyTearOff"
https://bugs.webkit.org/show_bug.cgi?id=172545
http://trac.webkit.org/changeset/219257
Modified Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (219263 => 219264)
--- trunk/LayoutTests/ChangeLog 2017-07-07 19:50:00 UTC (rev 219263)
+++ trunk/LayoutTests/ChangeLog 2017-07-07 20:05:27 UTC (rev 219264)
@@ -1,3 +1,16 @@
+2017-07-07 Matt Lewis <[email protected]>
+
+ Unreviewed, rolling out r219257.
+
+ The test added in the revision was still extreamly flaky on
+ all testers.
+
+ Reverted changeset:
+
+ "[SVG] Leak in SVGAnimatedListPropertyTearOff"
+ https://bugs.webkit.org/show_bug.cgi?id=172545
+ http://trac.webkit.org/changeset/219257
+
2017-07-07 Mark Lam <[email protected]>
\n\r is not the same as \r\n.
Deleted: trunk/LayoutTests/svg/animations/animation-leak-list-property-instances-expected.txt (219263 => 219264)
--- trunk/LayoutTests/svg/animations/animation-leak-list-property-instances-expected.txt 2017-07-07 19:50:00 UTC (rev 219263)
+++ trunk/LayoutTests/svg/animations/animation-leak-list-property-instances-expected.txt 2017-07-07 20:05:27 UTC (rev 219264)
@@ -1,2 +0,0 @@
-PASS: all nodes were properly removed.
-
Deleted: trunk/LayoutTests/svg/animations/animation-leak-list-property-instances.html (219263 => 219264)
--- trunk/LayoutTests/svg/animations/animation-leak-list-property-instances.html 2017-07-07 19:50:00 UTC (rev 219263)
+++ trunk/LayoutTests/svg/animations/animation-leak-list-property-instances.html 2017-07-07 20:05:27 UTC (rev 219264)
@@ -1,72 +0,0 @@
-<!DOCTYPE html>
-<script>
-
- var xmlns = "http://www.w3.org/2000/svg";
-
- function log(message) {
- var logDiv = document.getElementById('log');
- logDiv.appendChild(document.createTextNode(message));
- }
-
- function addRect()
- {
- var elem = document.createElementNS(xmlns, "rect");
- elem.setAttributeNS(null,"id", "rect");
- elem.setAttributeNS(null,"x",50);
- elem.setAttributeNS(null,"y",50);
- elem.setAttributeNS(null,"width",50);
- elem.setAttributeNS(null,"height",50);
- elem.setAttributeNS(null,"fill", "blue");
-
- document.getElementById("rootSVG").appendChild(elem);
- }
-
- function applyTransform()
- {
- var svgroot = document.getElementById("rootSVG");
- var transformList = document.getElementById("rect").transform.baseVal;
- var rotate = svgroot.createSVGTransform();
- rotate.setRotate(15,0,0);
- transformList.appendItem(rotate);
- }
-
- function removeRect()
- {
- document.getElementById("rootSVG").removeChild(document.getElementById("rect"));
- }
-
- var originalLiveElements = 0;
-
- function test()
- {
- if (!window.testRunner) {
- log("This test requires testRunner");
- return;
- }
-
- testRunner.dumpAsText();
- testRunner.waitUntilDone();
-
- GCController.collect();
- originalLiveElements = window.internals.numberOfLiveNodes();
-
- addRect();
- applyTransform();
- removeRect();
-
- GCController.collect();
- var delta = window.internals.numberOfLiveNodes() - originalLiveElements;
- if (delta == 0)
- log("PASS: all nodes were properly removed.");
- else
- log("FAIL: " + delta + " nodes leaked.")
-
- testRunner.notifyDone();
- }
-</script>
-
-<body _onload_="test()">
- <div id="log"></div>
- <svg id="rootSVG" width="300" height="300" xmlns="http://www.w3.org/2000/svg" version="1.1">
- </svg>
-</body>
Modified: trunk/Source/WebCore/ChangeLog (219263 => 219264)
--- trunk/Source/WebCore/ChangeLog 2017-07-07 19:50:00 UTC (rev 219263)
+++ trunk/Source/WebCore/ChangeLog 2017-07-07 20:05:27 UTC (rev 219264)
@@ -1,3 +1,16 @@
+2017-07-07 Matt Lewis <[email protected]>
+
+ Unreviewed, rolling out r219257.
+
+ The test added in the revision was still extreamly flaky on
+ all testers.
+
+ Reverted changeset:
+
+ "[SVG] Leak in SVGAnimatedListPropertyTearOff"
+ https://bugs.webkit.org/show_bug.cgi?id=172545
+ http://trac.webkit.org/changeset/219257
+
2017-07-07 Commit Queue <[email protected]>
Unreviewed, rolling out r219238, r219239, and r219241.
Modified: trunk/Source/WebCore/svg/properties/SVGAnimatedListPropertyTearOff.h (219263 => 219264)
--- trunk/Source/WebCore/svg/properties/SVGAnimatedListPropertyTearOff.h 2017-07-07 19:50:00 UTC (rev 219263)
+++ trunk/Source/WebCore/svg/properties/SVGAnimatedListPropertyTearOff.h 2017-07-07 20:05:27 UTC (rev 219264)
@@ -73,8 +73,6 @@
m_baseVal = nullptr;
else if (&property == m_animVal)
m_animVal = nullptr;
- if (!m_baseVal && !m_animVal)
- detachListWrappers(m_values.size());
}
int findItem(SVGProperty* property)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
