Title: [219396] trunk
Revision
219396
Author
commit-qu...@webkit.org
Date
2017-07-12 08:57:14 -0700 (Wed, 12 Jul 2017)

Log Message

Wrong radix used in Unicode Escape in invalid character error message
https://bugs.webkit.org/show_bug.cgi?id=174419

Patch by Tooru Fujisawa [:arai] <arai.un...@gmail.com> on 2017-07-12
Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

* web-platform-tests/html/syntax/parsing-html-fragments/the-input-byte-stream-003-expected.txt:
* web-platform-tests/html/syntax/parsing-html-fragments/the-input-byte-stream-004-expected.txt:

Source/_javascript_Core:

* parser/Lexer.cpp:
(JSC::Lexer<T>::invalidCharacterMessage):

LayoutTests:

* fast/loader/cache-encoding-expected.txt:
* http/tests/preload/preload-encoding-expected.txt:
* js/basic-strict-mode-expected.txt:
* js/kde/parse-expected.txt:
* loader/reload-subresource-when-type-changes-expected.txt:
* platform/ios/imported/w3c/web-platform-tests/html/syntax/parsing-html-fragments/the-input-byte-stream-003-expected.txt:
* platform/ios/imported/w3c/web-platform-tests/html/syntax/parsing-html-fragments/the-input-byte-stream-004-expected.txt:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (219395 => 219396)


--- trunk/LayoutTests/ChangeLog	2017-07-12 15:47:33 UTC (rev 219395)
+++ trunk/LayoutTests/ChangeLog	2017-07-12 15:57:14 UTC (rev 219396)
@@ -1,3 +1,18 @@
+2017-07-12  Tooru Fujisawa [:arai]  <arai.un...@gmail.com>
+
+        Wrong radix used in Unicode Escape in invalid character error message
+        https://bugs.webkit.org/show_bug.cgi?id=174419
+
+        Reviewed by Alex Christensen.
+
+        * fast/loader/cache-encoding-expected.txt:
+        * http/tests/preload/preload-encoding-expected.txt:
+        * js/basic-strict-mode-expected.txt:
+        * js/kde/parse-expected.txt:
+        * loader/reload-subresource-when-type-changes-expected.txt:
+        * platform/ios/imported/w3c/web-platform-tests/html/syntax/parsing-html-fragments/the-input-byte-stream-003-expected.txt:
+        * platform/ios/imported/w3c/web-platform-tests/html/syntax/parsing-html-fragments/the-input-byte-stream-004-expected.txt:
+
 2017-07-12  Youenn Fablet  <you...@apple.com>
 
         WebRTC: Incorrect sdpMLineIndex for video breaks Firefox interop

Modified: trunk/LayoutTests/fast/loader/cache-encoding-expected.txt (219395 => 219396)


--- trunk/LayoutTests/fast/loader/cache-encoding-expected.txt	2017-07-12 15:47:33 UTC (rev 219395)
+++ trunk/LayoutTests/fast/loader/cache-encoding-expected.txt	2017-07-12 15:57:14 UTC (rev 219396)
@@ -1,4 +1,4 @@
-CONSOLE MESSAGE: line 1: SyntaxError: Invalid character '\u8307'
+CONSOLE MESSAGE: line 1: SyntaxError: Invalid character '\u2073'
 First load a script with a wrong charset then again with the right one. Second attempt should work and 'scriptSuccess' should be set to true.
 
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".

Modified: trunk/LayoutTests/http/tests/preload/preload-encoding-expected.txt (219395 => 219396)


--- trunk/LayoutTests/http/tests/preload/preload-encoding-expected.txt	2017-07-12 15:47:33 UTC (rev 219395)
+++ trunk/LayoutTests/http/tests/preload/preload-encoding-expected.txt	2017-07-12 15:57:14 UTC (rev 219396)
@@ -1,4 +1,4 @@
-CONSOLE MESSAGE: line 1: SyntaxError: Invalid character '\u8307'
+CONSOLE MESSAGE: line 1: SyntaxError: Invalid character '\u2073'
 First load a script with a wrong charset then again with the right one. Second attempt should work and 'scriptSuccess' should be set to true. 'successfullyParsed' will be undefined.
 
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (219395 => 219396)


--- trunk/LayoutTests/imported/w3c/ChangeLog	2017-07-12 15:47:33 UTC (rev 219395)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2017-07-12 15:57:14 UTC (rev 219396)
@@ -1,3 +1,13 @@
+2017-07-12  Tooru Fujisawa [:arai]  <arai.un...@gmail.com>
+
+        Wrong radix used in Unicode Escape in invalid character error message
+        https://bugs.webkit.org/show_bug.cgi?id=174419
+
+        Reviewed by Alex Christensen.
+
+        * web-platform-tests/html/syntax/parsing-html-fragments/the-input-byte-stream-003-expected.txt:
+        * web-platform-tests/html/syntax/parsing-html-fragments/the-input-byte-stream-004-expected.txt:
+
 2017-07-12  Frederic Wang  <fw...@igalia.com>
 
         Import test verifying combination of allow-top-navigation and allow-top-navigation-by-user-activation

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing-html-fragments/the-input-byte-stream-003-expected.txt (219395 => 219396)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing-html-fragments/the-input-byte-stream-003-expected.txt	2017-07-12 15:47:33 UTC (rev 219395)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing-html-fragments/the-input-byte-stream-003-expected.txt	2017-07-12 15:57:14 UTC (rev 219396)
@@ -1,5 +1,5 @@
-CONSOLE MESSAGE: line 1: SyntaxError: Invalid character '\u10799'
-CONSOLE MESSAGE: line 1: SyntaxError: Invalid character '\u10799'
+CONSOLE MESSAGE: line 1: SyntaxError: Invalid character '\u2a2f'
+CONSOLE MESSAGE: line 1: SyntaxError: Invalid character '\u2a2f'
 CONSOLE MESSAGE: line 25: ReferenceError: Can't find variable: test
 layer at (0,0) size 800x600
   RenderView at (0,0) size 800x600

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing-html-fragments/the-input-byte-stream-004-expected.txt (219395 => 219396)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing-html-fragments/the-input-byte-stream-004-expected.txt	2017-07-12 15:47:33 UTC (rev 219395)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing-html-fragments/the-input-byte-stream-004-expected.txt	2017-07-12 15:57:14 UTC (rev 219396)
@@ -1,5 +1,5 @@
-CONSOLE MESSAGE: line 1: SyntaxError: Invalid character '\u10799'
-CONSOLE MESSAGE: line 1: SyntaxError: Invalid character '\u10799'
+CONSOLE MESSAGE: line 1: SyntaxError: Invalid character '\u2a2f'
+CONSOLE MESSAGE: line 1: SyntaxError: Invalid character '\u2a2f'
 CONSOLE MESSAGE: line 25: ReferenceError: Can't find variable: test
 layer at (0,0) size 800x600
   RenderView at (0,0) size 800x600

Modified: trunk/LayoutTests/js/basic-strict-mode-expected.txt (219395 => 219396)


--- trunk/LayoutTests/js/basic-strict-mode-expected.txt	2017-07-12 15:47:33 UTC (rev 219395)
+++ trunk/LayoutTests/js/basic-strict-mode-expected.txt	2017-07-12 15:57:14 UTC (rev 219396)
@@ -189,12 +189,12 @@
 PASS (function f(arg){'use strict'; var descriptor = Object.getOwnPropertyDescriptor(f.__proto__, 'caller'); return descriptor.get === descriptor.set; })() is true
 PASS (function f(arg){'use strict'; var descriptor = Object.getOwnPropertyDescriptor(f.__proto__, 'arguments'); return descriptor.get === descriptor.set; })() is true
 PASS 'use strict'; (function f() { for(var i in this); })(); true; is true
-PASS 'use strict'̻ threw exception SyntaxError: Invalid character '\u0827'.
-PASS (function(){'use strict'̻}) threw exception SyntaxError: Invalid character '\u0827'.
+PASS 'use strict'̻ threw exception SyntaxError: Invalid character '\u033b'.
+PASS (function(){'use strict'̻}) threw exception SyntaxError: Invalid character '\u033b'.
 PASS 'use strict'5.f threw exception SyntaxError: No identifiers allowed directly after numeric literal.
 PASS (function(){'use strict'5.f}) threw exception SyntaxError: No identifiers allowed directly after numeric literal.
-PASS 'use strict';̻ threw exception SyntaxError: Invalid character '\u0827'.
-PASS (function(){'use strict';̻}) threw exception SyntaxError: Invalid character '\u0827'.
+PASS 'use strict';̻ threw exception SyntaxError: Invalid character '\u033b'.
+PASS (function(){'use strict';̻}) threw exception SyntaxError: Invalid character '\u033b'.
 PASS 'use strict';5.f threw exception SyntaxError: No identifiers allowed directly after numeric literal.
 PASS (function(){'use strict';5.f}) threw exception SyntaxError: No identifiers allowed directly after numeric literal.
 PASS 'use strict';1-(eval=1); threw exception SyntaxError: Cannot modify 'eval' in strict mode..

Modified: trunk/LayoutTests/js/kde/parse-expected.txt (219395 => 219396)


--- trunk/LayoutTests/js/kde/parse-expected.txt	2017-07-12 15:47:33 UTC (rev 219395)
+++ trunk/LayoutTests/js/kde/parse-expected.txt	2017-07-12 15:57:14 UTC (rev 219396)
@@ -16,7 +16,7 @@
 PASS function test() { while(0) break lab } lab: 1 threw exception SyntaxError: Cannot use the undeclared label 'lab'..
 PASS function test() { while(0) continue lab } lab: 1 threw exception SyntaxError: Cannot use the undeclared label 'lab'..
 PASS var éĀʯΈᢨ = 101; éĀʯΈᢨ; is 101
-PASS var f÷; threw exception SyntaxError: Invalid character '\u0247'.
+PASS var f÷; threw exception SyntaxError: Invalid character '\u00f7'.
 PASS var \u0061 = 102; a is 102
 PASS var f\u0030 = 103; f0 is 103
 PASS var \u00E9\u0100\u02AF\u0388\u18A8 = 104; \u00E9\u0100\u02AF\u0388\u18A8; is 104

Modified: trunk/LayoutTests/loader/reload-subresource-when-type-changes-expected.txt (219395 => 219396)


--- trunk/LayoutTests/loader/reload-subresource-when-type-changes-expected.txt	2017-07-12 15:47:33 UTC (rev 219395)
+++ trunk/LayoutTests/loader/reload-subresource-when-type-changes-expected.txt	2017-07-12 15:57:14 UTC (rev 219396)
@@ -1,4 +1,4 @@
-CONSOLE MESSAGE: line 1: SyntaxError: Invalid character '\u8240'
+CONSOLE MESSAGE: line 1: SyntaxError: Invalid character '\u2030'
 PASS 1 of 3
 PASS 2 of 3
 PASS 3 of 3

Modified: trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/syntax/parsing-html-fragments/the-input-byte-stream-003-expected.txt (219395 => 219396)


--- trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/syntax/parsing-html-fragments/the-input-byte-stream-003-expected.txt	2017-07-12 15:47:33 UTC (rev 219395)
+++ trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/syntax/parsing-html-fragments/the-input-byte-stream-003-expected.txt	2017-07-12 15:57:14 UTC (rev 219396)
@@ -1,5 +1,5 @@
-CONSOLE MESSAGE: line 1: SyntaxError: Invalid character '\u10799'
-CONSOLE MESSAGE: line 1: SyntaxError: Invalid character '\u10799'
+CONSOLE MESSAGE: line 1: SyntaxError: Invalid character '\u2a2f'
+CONSOLE MESSAGE: line 1: SyntaxError: Invalid character '\u2a2f'
 CONSOLE MESSAGE: line 25: ReferenceError: Can't find variable: test
 layer at (0,0) size 800x600
   RenderView at (0,0) size 800x600

Modified: trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/syntax/parsing-html-fragments/the-input-byte-stream-004-expected.txt (219395 => 219396)


--- trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/syntax/parsing-html-fragments/the-input-byte-stream-004-expected.txt	2017-07-12 15:47:33 UTC (rev 219395)
+++ trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/syntax/parsing-html-fragments/the-input-byte-stream-004-expected.txt	2017-07-12 15:57:14 UTC (rev 219396)
@@ -1,5 +1,5 @@
-CONSOLE MESSAGE: line 1: SyntaxError: Invalid character '\u10799'
-CONSOLE MESSAGE: line 1: SyntaxError: Invalid character '\u10799'
+CONSOLE MESSAGE: line 1: SyntaxError: Invalid character '\u2a2f'
+CONSOLE MESSAGE: line 1: SyntaxError: Invalid character '\u2a2f'
 CONSOLE MESSAGE: line 25: ReferenceError: Can't find variable: test
 layer at (0,0) size 800x600
   RenderView at (0,0) size 800x600

Modified: trunk/Source/_javascript_Core/ChangeLog (219395 => 219396)


--- trunk/Source/_javascript_Core/ChangeLog	2017-07-12 15:47:33 UTC (rev 219395)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-07-12 15:57:14 UTC (rev 219396)
@@ -1,3 +1,13 @@
+2017-07-12  Tooru Fujisawa [:arai]  <arai.un...@gmail.com>
+
+        Wrong radix used in Unicode Escape in invalid character error message
+        https://bugs.webkit.org/show_bug.cgi?id=174419
+
+        Reviewed by Alex Christensen.
+
+        * parser/Lexer.cpp:
+        (JSC::Lexer<T>::invalidCharacterMessage):
+
 2017-07-11  Dean Jackson  <d...@apple.com>
 
         Remove NAVIGATOR_HWCONCURRENCY

Modified: trunk/Source/_javascript_Core/parser/Lexer.cpp (219395 => 219396)


--- trunk/Source/_javascript_Core/parser/Lexer.cpp	2017-07-12 15:47:33 UTC (rev 219395)
+++ trunk/Source/_javascript_Core/parser/Lexer.cpp	2017-07-12 15:57:14 UTC (rev 219396)
@@ -525,7 +525,7 @@
     case 96:
         return ASCIILiteral("Invalid character: '`'");
     default:
-        return String::format("Invalid character '\\u%04u'", static_cast<unsigned>(m_current));
+        return String::format("Invalid character '\\u%04x'", static_cast<unsigned>(m_current));
     }
 }
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to