Title: [219508] trunk
- Revision
- 219508
- Author
- jlew...@apple.com
- Date
- 2017-07-14 10:31:14 -0700 (Fri, 14 Jul 2017)
Log Message
Unreviewed, rolling out r219500.
The test is consistently failing on iOS simulator.
Reverted changeset:
"AX: VoiceOver silent or skipping over time values on media
player."
https://bugs.webkit.org/show_bug.cgi?id=174324
http://trac.webkit.org/changeset/219500
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (219507 => 219508)
--- trunk/LayoutTests/ChangeLog 2017-07-14 17:15:02 UTC (rev 219507)
+++ trunk/LayoutTests/ChangeLog 2017-07-14 17:31:14 UTC (rev 219508)
@@ -1,3 +1,16 @@
+2017-07-14 Matt Lewis <jlew...@apple.com>
+
+ Unreviewed, rolling out r219500.
+
+ The test is consistently failing on iOS simulator.
+
+ Reverted changeset:
+
+ "AX: VoiceOver silent or skipping over time values on media
+ player."
+ https://bugs.webkit.org/show_bug.cgi?id=174324
+ http://trac.webkit.org/changeset/219500
+
2017-07-14 Jonathan Bedard <jbed...@apple.com>
Add script to rebase patches during the WebKit2->WebKit/WebKit->WebKitLegacy transition
Modified: trunk/LayoutTests/media/modern-media-controls/time-label/time-label-expected.txt (219507 => 219508)
--- trunk/LayoutTests/media/modern-media-controls/time-label/time-label-expected.txt 2017-07-14 17:15:02 UTC (rev 219507)
+++ trunk/LayoutTests/media/modern-media-controls/time-label/time-label-expected.txt 2017-07-14 17:31:14 UTC (rev 219508)
@@ -14,8 +14,6 @@
PASS elaspedLabel is "Elapsed"
PASS remainingLabel is "Remaining"
-PASS accessibilityController.accessibleElementById('remaining').role is "AXRole: AXStaticText"
-PASS accessibilityController.accessibleElementById('elasped').role is "AXRole: AXStaticText"
elapsedTimeLabels[3].element.textContent = 0:01
elapsedTimeLabels[3].width = 27
Modified: trunk/LayoutTests/media/modern-media-controls/time-label/time-label.html (219507 => 219508)
--- trunk/LayoutTests/media/modern-media-controls/time-label/time-label.html 2017-07-14 17:15:02 UTC (rev 219507)
+++ trunk/LayoutTests/media/modern-media-controls/time-label/time-label.html 2017-07-14 17:31:14 UTC (rev 219508)
@@ -31,12 +31,7 @@
const remainingTimeLabel = new TimeLabel(TimeLabel.Types.Remaining);
remainingTimeLabel.element.id = "remaining";
-remainingTimeLabel.setValueWithNumberOfDigits(0, 4);
-const elaspedTimeLabel = new TimeLabel(TimeLabel.Types.Elasped);
-elaspedTimeLabel.element.id = "elasped";
-elaspedTimeLabel.setValueWithNumberOfDigits(0, 4);
-
let style;
let elaspedLabel;
let remainingLabel;
@@ -44,8 +39,6 @@
{
document.body.appendChild(timeLabel.element);
document.body.appendChild(remainingTimeLabel.element);
- document.body.appendChild(elaspedTimeLabel.element);
-
style = window.getComputedStyle(timeLabel.element);
shouldBeEqualToString("style.position", "absolute");
@@ -56,16 +49,12 @@
debug(`NaNTimeLabel.element.textContent = ${NaNTimeLabel.element.textContent}`);
debug("");
-
- elaspedLabel = elaspedTimeLabel.element.getAttribute("aria-label").split(":")[0];
- remainingLabel = remainingTimeLabel.element.getAttribute("aria-label").split(":")[0];
+ elaspedLabel = accessibilityController.accessibleElementById('elasped').description.split(": ")[1];
+ remainingLabel = accessibilityController.accessibleElementById('remaining').description.split(": ")[1];
shouldBeEqualToString("elaspedLabel", "Elapsed");
shouldBeEqualToString("remainingLabel", "Remaining");
- shouldBeEqualToString("accessibilityController.accessibleElementById('remaining').role", "AXRole: AXStaticText");
- shouldBeEqualToString("accessibilityController.accessibleElementById('elasped').role", "AXRole: AXStaticText");
timeLabel.element.remove();
remainingTimeLabel.element.remove();
- elaspedTimeLabel.element.remove();
for (numberOfDigits of digits) {
debug("");
Modified: trunk/Source/WebCore/ChangeLog (219507 => 219508)
--- trunk/Source/WebCore/ChangeLog 2017-07-14 17:15:02 UTC (rev 219507)
+++ trunk/Source/WebCore/ChangeLog 2017-07-14 17:31:14 UTC (rev 219508)
@@ -1,3 +1,16 @@
+2017-07-14 Matt Lewis <jlew...@apple.com>
+
+ Unreviewed, rolling out r219500.
+
+ The test is consistently failing on iOS simulator.
+
+ Reverted changeset:
+
+ "AX: VoiceOver silent or skipping over time values on media
+ player."
+ https://bugs.webkit.org/show_bug.cgi?id=174324
+ http://trac.webkit.org/changeset/219500
+
2017-07-14 Fujii Hironori <hironori.fu...@sony.com>
[WinCairo] error 'm_compositorTexture': undeclared identifier since Bug 174345
Modified: trunk/Source/WebCore/Modules/modern-media-controls/controls/time-label.js (219507 => 219508)
--- trunk/Source/WebCore/Modules/modern-media-controls/controls/time-label.js 2017-07-14 17:15:02 UTC (rev 219507)
+++ trunk/Source/WebCore/Modules/modern-media-controls/controls/time-label.js 2017-07-14 17:31:14 UTC (rev 219508)
@@ -42,7 +42,7 @@
constructor(type)
{
- super(`<div role="text" class="time-label"></div>`);
+ super(`<div class="time-label"></div>`);
this._type = type;
this.setValueWithNumberOfDigits(0, 4);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
