Title: [219562] trunk/Source/_javascript_Core
- Revision
- 219562
- Author
- sbar...@apple.com
- Date
- 2017-07-17 09:38:10 -0700 (Mon, 17 Jul 2017)
Log Message
Remove custom defined RELEASE_ASSERT in DFGObjectAllocationSinkingPhase
https://bugs.webkit.org/show_bug.cgi?id=174584
Rubber stamped by Keith Miller.
I used it to diagnose a bug. The bug is now fixed. This custom
RELEASE_ASSERT is no longer needed.
* dfg/DFGObjectAllocationSinkingPhase.cpp:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (219561 => 219562)
--- trunk/Source/_javascript_Core/ChangeLog 2017-07-17 15:30:59 UTC (rev 219561)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-07-17 16:38:10 UTC (rev 219562)
@@ -1,3 +1,15 @@
+2017-07-17 Saam Barati <sbar...@apple.com>
+
+ Remove custom defined RELEASE_ASSERT in DFGObjectAllocationSinkingPhase
+ https://bugs.webkit.org/show_bug.cgi?id=174584
+
+ Rubber stamped by Keith Miller.
+
+ I used it to diagnose a bug. The bug is now fixed. This custom
+ RELEASE_ASSERT is no longer needed.
+
+ * dfg/DFGObjectAllocationSinkingPhase.cpp:
+
2017-07-17 Michael Catanzaro <mcatanz...@igalia.com>
-Wformat-truncation warning in ConfigFile.cpp
Modified: trunk/Source/_javascript_Core/dfg/DFGObjectAllocationSinkingPhase.cpp (219561 => 219562)
--- trunk/Source/_javascript_Core/dfg/DFGObjectAllocationSinkingPhase.cpp 2017-07-17 15:30:59 UTC (rev 219561)
+++ trunk/Source/_javascript_Core/dfg/DFGObjectAllocationSinkingPhase.cpp 2017-07-17 16:38:10 UTC (rev 219562)
@@ -48,20 +48,6 @@
namespace {
-NO_RETURN_DUE_TO_CRASH NEVER_INLINE void crash(const char*, int line, int)
-{
- UNUSED_PARAM(line);
- CRASH_WITH_SECURITY_IMPLICATION_AND_INFO(ObjectAllocationSinkingAssertionFailure, line);
-}
-
-#undef RELEASE_ASSERT
-#define RELEASE_ASSERT(assertion) do { \
- if (!(assertion)) { \
- WTFReportAssertionFailure(__FILE__, __LINE__, WTF_PRETTY_FUNCTION, #assertion); \
- crash(__FILE__, __LINE__, __COUNTER__); \
- } \
-} while (0)
-
bool verbose = false;
// In order to sink object cycles, we use a points-to analysis coupled
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes