Title: [219596] trunk/Source/WebCore
- Revision
- 219596
- Author
- drou...@apple.com
- Date
- 2017-07-17 19:00:50 -0700 (Mon, 17 Jul 2017)
Log Message
Web Inspector: overlay page highlight doesn't disappear when a page is constantly updating
https://bugs.webkit.org/show_bug.cgi?id=174468
Reviewed by Simon Fraser.
Do not allow the PageOverlay to start another fade animation of the same type if one has
already started. As an example, if the PageOverlay is fading out, startFadeOutAnimation
should just return.
* page/PageOverlay.cpp:
(WebCore::PageOverlay::startFadeInAnimation):
(WebCore::PageOverlay::startFadeOutAnimation):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (219595 => 219596)
--- trunk/Source/WebCore/ChangeLog 2017-07-18 01:53:34 UTC (rev 219595)
+++ trunk/Source/WebCore/ChangeLog 2017-07-18 02:00:50 UTC (rev 219596)
@@ -1,3 +1,18 @@
+2017-07-17 Devin Rousso <drou...@apple.com>
+
+ Web Inspector: overlay page highlight doesn't disappear when a page is constantly updating
+ https://bugs.webkit.org/show_bug.cgi?id=174468
+
+ Reviewed by Simon Fraser.
+
+ Do not allow the PageOverlay to start another fade animation of the same type if one has
+ already started. As an example, if the PageOverlay is fading out, startFadeOutAnimation
+ should just return.
+
+ * page/PageOverlay.cpp:
+ (WebCore::PageOverlay::startFadeInAnimation):
+ (WebCore::PageOverlay::startFadeOutAnimation):
+
2017-07-17 Darin Adler <da...@apple.com>
Improve use of NeverDestroyed
Modified: trunk/Source/WebCore/page/PageOverlay.cpp (219595 => 219596)
--- trunk/Source/WebCore/page/PageOverlay.cpp 2017-07-18 01:53:34 UTC (rev 219595)
+++ trunk/Source/WebCore/page/PageOverlay.cpp 2017-07-18 02:00:50 UTC (rev 219596)
@@ -227,6 +227,9 @@
void PageOverlay::startFadeInAnimation()
{
+ if (m_fadeAnimationType == FadeInAnimation && m_fadeAnimationTimer.isActive())
+ return;
+
m_fractionFadedIn = 0;
m_fadeAnimationType = FadeInAnimation;
@@ -235,6 +238,9 @@
void PageOverlay::startFadeOutAnimation()
{
+ if (m_fadeAnimationType == FadeOutAnimation && m_fadeAnimationTimer.isActive())
+ return;
+
m_fractionFadedIn = 1;
m_fadeAnimationType = FadeOutAnimation;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
