Title: [219894] trunk/Source/WebInspectorUI
- Revision
- 219894
- Author
- commit-qu...@webkit.org
- Date
- 2017-07-25 17:45:04 -0700 (Tue, 25 Jul 2017)
Log Message
Web Inspector: Fix warnings about console.assert lines without semicolons
https://bugs.webkit.org/show_bug.cgi?id=174840
Patch by Joseph Pecoraro <pecor...@apple.com> on 2017-07-25
Reviewed by Brian Burg.
* UserInterface/Views/SettingsTabContentView.js:
(WebInspector.SettingsTabContentView.prototype.set selectedSettingsView):
(WebInspector.SettingsTabContentView.prototype.setSettingsViewVisible):
Add semicolon to assert lines so they can be stripped in optimized builds.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (219893 => 219894)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-07-25 23:31:19 UTC (rev 219893)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-07-26 00:45:04 UTC (rev 219894)
@@ -1,5 +1,17 @@
2017-07-25 Joseph Pecoraro <pecor...@apple.com>
+ Web Inspector: Fix warnings about console.assert lines without semicolons
+ https://bugs.webkit.org/show_bug.cgi?id=174840
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Views/SettingsTabContentView.js:
+ (WebInspector.SettingsTabContentView.prototype.set selectedSettingsView):
+ (WebInspector.SettingsTabContentView.prototype.setSettingsViewVisible):
+ Add semicolon to assert lines so they can be stripped in optimized builds.
+
+2017-07-25 Joseph Pecoraro <pecor...@apple.com>
+
Web Inspector: Inline multiple console log values if they are simple
https://bugs.webkit.org/show_bug.cgi?id=174746
<rdar://problem/33469376>
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js (219893 => 219894)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2017-07-25 23:31:19 UTC (rev 219893)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2017-07-26 00:45:04 UTC (rev 219894)
@@ -80,7 +80,7 @@
this._selectedSettingsView.updateLayout();
let navigationItem = this._navigationBar.findNavigationItem(settingsView.identifier);
- console.assert(navigationItem, "Missing navigation item for settings view.", settingsView)
+ console.assert(navigationItem, "Missing navigation item for settings view.", settingsView);
if (!navigationItem)
return;
@@ -125,7 +125,7 @@
return;
let index = this._settingsViews.indexOf(settingsView);
- console.assert(index !== -1, "SettingsView not found.", settingsView)
+ console.assert(index !== -1, "SettingsView not found.", settingsView);
if (index === -1)
return;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
