Title: [219920] branches/safari-604-branch/Source/WebCore
- Revision
- 219920
- Author
- [email protected]
- Date
- 2017-07-26 02:51:39 -0700 (Wed, 26 Jul 2017)
Log Message
Cherry-pick r219742. rdar://problem/33523798
Modified Paths
Diff
Modified: branches/safari-604-branch/Source/WebCore/ChangeLog (219919 => 219920)
--- branches/safari-604-branch/Source/WebCore/ChangeLog 2017-07-26 09:51:36 UTC (rev 219919)
+++ branches/safari-604-branch/Source/WebCore/ChangeLog 2017-07-26 09:51:39 UTC (rev 219920)
@@ -1,5 +1,27 @@
2017-07-26 Jason Marcell <[email protected]>
+ Cherry-pick r219742. rdar://problem/33523798
+
+ 2017-07-21 Zalan Bujtas <[email protected]>
+
+ iBooks: Overlapping/missing content at beginning/end of paragraph.
+ https://bugs.webkit.org/show_bug.cgi?id=174717
+ <rdar://problem/33117912>
+
+ Reviewed by Simon Fraser.
+
+ By definiton simple and normal line layout should always produce the exact same lineboxes. It enables us not
+ to force repaint while swapping between these 2 line layouts.
+ However in certain cases (font size pixel rounding as an example) they don't agree on how much content fits the line and
+ that could result in missing/overlapping content due to the lack of repaint.
+
+ Unable to test.
+
+ * rendering/RenderBlockFlow.cpp:
+ (WebCore::RenderBlockFlow::ensureLineBoxes):
+
+2017-07-26 Jason Marcell <[email protected]>
+
Cherry-pick r219737. rdar://problem/33523854
2017-07-21 Jeremy Jones <[email protected]>
Modified: branches/safari-604-branch/Source/WebCore/rendering/RenderBlockFlow.cpp (219919 => 219920)
--- branches/safari-604-branch/Source/WebCore/rendering/RenderBlockFlow.cpp 2017-07-26 09:51:36 UTC (rev 219919)
+++ branches/safari-604-branch/Source/WebCore/rendering/RenderBlockFlow.cpp 2017-07-26 09:51:39 UTC (rev 219920)
@@ -3758,6 +3758,8 @@
// This matches relayoutToAvoidWidows.
if (shouldBreakAtLineToAvoidWidow())
layoutLineBoxes(relayoutChildren, repaintLogicalTop, repaintLogicalBottom);
+ // FIXME: This is needed as long as simple and normal line layout produce different line breakings.
+ repaint();
} else
layoutLineBoxes(relayoutChildren, repaintLogicalTop, repaintLogicalBottom);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
