Title: [220014] trunk/Source/WebCore
- Revision
- 220014
- Author
- [email protected]
- Date
- 2017-07-28 14:08:57 -0700 (Fri, 28 Jul 2017)
Log Message
WebMediaSessionHelper calls -[UIApplication beginReceivingRemoteControlEvents] from WebThread
https://bugs.webkit.org/show_bug.cgi?id=174934
rdar://problem/33586772
Patch by Jeremy Jones <[email protected]> on 2017-07-28
Reviewed by Eric Carlson.
No new tests because no effect on DOM.
This dispatches a UIKit call to the main thread since it might happen on WebThread in WK1.
* platform/audio/ios/MediaSessionManagerIOS.mm:
(-[WebMediaSessionHelper initWithCallback:]):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (220013 => 220014)
--- trunk/Source/WebCore/ChangeLog 2017-07-28 20:49:34 UTC (rev 220013)
+++ trunk/Source/WebCore/ChangeLog 2017-07-28 21:08:57 UTC (rev 220014)
@@ -1,3 +1,18 @@
+2017-07-28 Jeremy Jones <[email protected]>
+
+ WebMediaSessionHelper calls -[UIApplication beginReceivingRemoteControlEvents] from WebThread
+ https://bugs.webkit.org/show_bug.cgi?id=174934
+ rdar://problem/33586772
+
+ Reviewed by Eric Carlson.
+
+ No new tests because no effect on DOM.
+
+ This dispatches a UIKit call to the main thread since it might happen on WebThread in WK1.
+
+ * platform/audio/ios/MediaSessionManagerIOS.mm:
+ (-[WebMediaSessionHelper initWithCallback:]):
+
2017-07-28 Myles C. Maxfield <[email protected]>
[macOS] Reeder's defaults font is Times instead of San Francisco
Modified: trunk/Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm (220013 => 220014)
--- trunk/Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm 2017-07-28 20:49:34 UTC (rev 220013)
+++ trunk/Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm 2017-07-28 21:08:57 UTC (rev 220014)
@@ -338,8 +338,10 @@
[self allocateVolumeView];
// Now playing won't work unless we turn on the delivery of remote control events.
- [[UIApplication sharedApplication] beginReceivingRemoteControlEvents];
-
+ dispatch_async(dispatch_get_main_queue(), ^ {
+ [[UIApplication sharedApplication] beginReceivingRemoteControlEvents];
+ });
+
return self;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
