Title: [220054] trunk/Source/WebCore
Revision
220054
Author
zandober...@gmail.com
Date
2017-07-30 23:59:59 -0700 (Sun, 30 Jul 2017)

Log Message

Unreviewed. Suppress the -Wextra compiler warning when building with GCC 6.3.0,
explicitly initializing the RefCounted<> base class in the
FetchHeaders(const FetchHeaders&) constructor.

Note that while that's the signature of the copy constructor for the FetchHeaders
class, the base RefCounted<> class is not copyable, so the default RefCounted<>
constructor is used, but the FetchHeaders resources are normally copied into the
new object from the one that's passed in.

* Modules/fetch/FetchHeaders.h:
(WebCore::FetchHeaders::FetchHeaders):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (220053 => 220054)


--- trunk/Source/WebCore/ChangeLog	2017-07-31 04:57:15 UTC (rev 220053)
+++ trunk/Source/WebCore/ChangeLog	2017-07-31 06:59:59 UTC (rev 220054)
@@ -1,3 +1,17 @@
+2017-07-30  Zan Dobersek  <zdober...@igalia.com>
+
+        Unreviewed. Suppress the -Wextra compiler warning when building with GCC 6.3.0,
+        explicitly initializing the RefCounted<> base class in the
+        FetchHeaders(const FetchHeaders&) constructor.
+
+        Note that while that's the signature of the copy constructor for the FetchHeaders
+        class, the base RefCounted<> class is not copyable, so the default RefCounted<>
+        constructor is used, but the FetchHeaders resources are normally copied into the
+        new object from the one that's passed in.
+
+        * Modules/fetch/FetchHeaders.h:
+        (WebCore::FetchHeaders::FetchHeaders):
+
 2017-07-30  Darin Adler  <da...@apple.com>
 
         Remove code in HTMLObjectElement attribute parsing that forces style resolution and layout

Modified: trunk/Source/WebCore/Modules/fetch/FetchHeaders.h (220053 => 220054)


--- trunk/Source/WebCore/Modules/fetch/FetchHeaders.h	2017-07-31 04:57:15 UTC (rev 220053)
+++ trunk/Source/WebCore/Modules/fetch/FetchHeaders.h	2017-07-31 06:59:59 UTC (rev 220054)
@@ -100,7 +100,8 @@
 }
 
 inline FetchHeaders::FetchHeaders(const FetchHeaders& other)
-    : m_guard(other.m_guard)
+    : RefCounted<FetchHeaders>()
+    , m_guard(other.m_guard)
     , m_headers(other.m_headers)
 {
 }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to