Title: [220074] trunk/Source/WebKit
- Revision
- 220074
- Author
- [email protected]
- Date
- 2017-07-31 14:26:26 -0700 (Mon, 31 Jul 2017)
Log Message
WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction() may not be able to
determine page that initiated navigation
https://bugs.webkit.org/show_bug.cgi?id=174531
Remove a comment from WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction()
about determining the originating page independently from the originating frame. There
does not seem to be much value to fixing this. We can always revisit this issue if we
discover a strong motivating example. See <https://bugs.webkit.org/show_bug.cgi?id=174531#c1>
for more details.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (220073 => 220074)
--- trunk/Source/WebKit/ChangeLog 2017-07-31 20:31:05 UTC (rev 220073)
+++ trunk/Source/WebKit/ChangeLog 2017-07-31 21:26:26 UTC (rev 220074)
@@ -1,3 +1,18 @@
+2017-07-31 Daniel Bates <[email protected]>
+
+ WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction() may not be able to
+ determine page that initiated navigation
+ https://bugs.webkit.org/show_bug.cgi?id=174531
+
+ Remove a comment from WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction()
+ about determining the originating page independently from the originating frame. There
+ does not seem to be much value to fixing this. We can always revisit this issue if we
+ discover a strong motivating example. See <https://bugs.webkit.org/show_bug.cgi?id=174531#c1>
+ for more details.
+
+ * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
+ (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
+
2017-07-31 Sam Weinig <[email protected]>
Remove unnecessary exceptions from storage code
Modified: trunk/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp (220073 => 220074)
--- trunk/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp 2017-07-31 20:31:05 UTC (rev 220073)
+++ trunk/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp 2017-07-31 21:26:26 UTC (rev 220074)
@@ -822,9 +822,6 @@
// Notify the UIProcess.
Ref<WebFrame> protect(*m_frame);
WebsitePolicies websitePolicies;
- // FIXME: Determine the originating page independently from the originating frame as it may exist even if
- // the originating frame does not exist. This can happen if the originating frame was removed from the page.
- // See <https://bugs.webkit.org/show_bug.cgi?id=174531>.
if (!webPage->sendSync(Messages::WebPageProxy::DecidePolicyForNavigationAction(m_frame->frameID(), SecurityOriginData::fromFrame(coreFrame), documentLoader->navigationID(), navigationActionData, originatingFrameInfoData, originatingFrame && originatingFrame->page() ? originatingFrame->page()->pageID() : 0, navigationAction.resourceRequest(), request, listenerID, UserData(WebProcess::singleton().transformObjectsToHandles(userData.get()).get())), Messages::WebPageProxy::DecidePolicyForNavigationAction::Reply(newNavigationID, policyAction, downloadID, websitePolicies))) {
m_frame->didReceivePolicyDecision(listenerID, PolicyIgnore, 0, { });
return;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
