Diff
Modified: branches/safari-604.1.38.1-branch/LayoutTests/ChangeLog (220597 => 220598)
--- branches/safari-604.1.38.1-branch/LayoutTests/ChangeLog 2017-08-11 16:53:36 UTC (rev 220597)
+++ branches/safari-604.1.38.1-branch/LayoutTests/ChangeLog 2017-08-11 16:53:39 UTC (rev 220598)
@@ -1,5 +1,9 @@
2017-08-11 Jason Marcell <jmarc...@apple.com>
+ Revert r220587. rdar://problem/33843387
+
+2017-08-11 Jason Marcell <jmarc...@apple.com>
+
Revert r220588. rdar://problem/33843387
2017-08-11 Ryan Haddad <ryanhad...@apple.com>
Deleted: branches/safari-604.1.38.1-branch/LayoutTests/accessibility/add-children-pseudo-element-expected.txt (220597 => 220598)
--- branches/safari-604.1.38.1-branch/LayoutTests/accessibility/add-children-pseudo-element-expected.txt 2017-08-11 16:53:36 UTC (rev 220597)
+++ branches/safari-604.1.38.1-branch/LayoutTests/accessibility/add-children-pseudo-element-expected.txt 2017-08-11 16:53:39 UTC (rev 220598)
@@ -1,12 +0,0 @@
-Language Email
-Make sure that we are updating the render block flow element's children correctly.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS element.childrenCount is 3
-PASS element.childrenCount is 2
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
Deleted: branches/safari-604.1.38.1-branch/LayoutTests/accessibility/add-children-pseudo-element.html (220597 => 220598)
--- branches/safari-604.1.38.1-branch/LayoutTests/accessibility/add-children-pseudo-element.html 2017-08-11 16:53:36 UTC (rev 220597)
+++ branches/safari-604.1.38.1-branch/LayoutTests/accessibility/add-children-pseudo-element.html 2017-08-11 16:53:39 UTC (rev 220598)
@@ -1,70 +0,0 @@
-<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
-<html>
-<head>
-<script src=""
-</head>
-
-<style>
-.pseudo::after {
- content: url(resources/svg-circle.svg);
- width: 18px;
- height: 20px;
- position: absolute;
- margin-top: 6px;
- right: 6px
-}
-
-.pseudo.hidden::after {
- content: ' ';
-}
-</style>
-
-<body id="body">
-
-<div id="container">
-<div id="test" style="float : left;">
-<span>Language</span>
-<input id="test">
-</div>
-
-<div id="float" style="display: inline-block;" class="pseudo">
-<span required="" style="color: rgb(194, 0, 0);">Email</span>
-<input type="text" required="" aria-required="true" value="" _onkeyup_="hidePseudo();">
-</div>
-
-</div>
-
-<p id="description"></p>
-<div id="console"></div>
-
-<script>
-
- description("Make sure that we are updating the render block flow element's children correctly.");
-
- if (window.accessibilityController) {
- var element = accessibilityController.accessibleElementById("float");
- shouldBe("element.childrenCount", "3");
-
- eventSender.keyDown('\t');
- eventSender.keyDown('\t');
-
- shouldBe("element.childrenCount", "2");
- showPseudo();
-
- function hidePseudo() {
- document.getElementById("float").className += "hidden"
- }
-
- function showPseudo() {
- document.getElementById("float").className = "pseudo";
- }
-
- // Make sure getting the attributes of its children won't cause crash
- element.attributesOfChildren();
- }
-
-</script>
-
-<script src=""
-</body>
-</html>
Deleted: branches/safari-604.1.38.1-branch/LayoutTests/accessibility/resources/svg-circle.svg (220597 => 220598)
--- branches/safari-604.1.38.1-branch/LayoutTests/accessibility/resources/svg-circle.svg 2017-08-11 16:53:36 UTC (rev 220597)
+++ branches/safari-604.1.38.1-branch/LayoutTests/accessibility/resources/svg-circle.svg 2017-08-11 16:53:39 UTC (rev 220598)
@@ -1,6 +0,0 @@
-<svg xmlns="http://www.w3.org/2000/svg">
- <g>
- <text style="float:right"></text>
- <text>circle</text>
- </g>
-</svg>
\ No newline at end of file
Modified: branches/safari-604.1.38.1-branch/Source/WebCore/ChangeLog (220597 => 220598)
--- branches/safari-604.1.38.1-branch/Source/WebCore/ChangeLog 2017-08-11 16:53:36 UTC (rev 220597)
+++ branches/safari-604.1.38.1-branch/Source/WebCore/ChangeLog 2017-08-11 16:53:39 UTC (rev 220598)
@@ -1,5 +1,9 @@
2017-08-11 Jason Marcell <jmarc...@apple.com>
+ Revert r220587. rdar://problem/33843387
+
+2017-08-11 Jason Marcell <jmarc...@apple.com>
+
Revert r220588. rdar://problem/33843387
2017-08-11 Jason Marcell <jmarc...@apple.com>
Modified: branches/safari-604.1.38.1-branch/Source/WebCore/rendering/RenderBlockFlow.cpp (220597 => 220598)
--- branches/safari-604.1.38.1-branch/Source/WebCore/rendering/RenderBlockFlow.cpp 2017-08-11 16:53:36 UTC (rev 220597)
+++ branches/safari-604.1.38.1-branch/Source/WebCore/rendering/RenderBlockFlow.cpp 2017-08-11 16:53:39 UTC (rev 220598)
@@ -24,7 +24,6 @@
#include "config.h"
#include "RenderBlockFlow.h"
-#include "AXObjectCache.h"
#include "Editor.h"
#include "FloatingObjects.h"
#include "Frame.h"
@@ -2353,9 +2352,6 @@
}
setLogicalWidthForFloat(*floatingObject, logicalWidthForChild(floatBox) + marginStartForChild(floatBox) + marginEndForChild(floatBox));
-
- if (AXObjectCache* cache = document().existingAXObjectCache())
- cache->childrenChanged(this);
return m_floatingObjects->add(WTFMove(floatingObject));
}
@@ -2393,9 +2389,6 @@
markLinesDirtyInBlockRange(0, logicalBottom);
}
m_floatingObjects->remove(&floatingObject);
-
- if (AXObjectCache* cache = document().existingAXObjectCache())
- cache->childrenChanged(this);
}
}
}
