Title: [220876] trunk/Source/WebCore
- Revision
- 220876
- Author
- mcatanz...@igalia.com
- Date
- 2017-08-17 14:17:34 -0700 (Thu, 17 Aug 2017)
Log Message
-Wreturn-type warnings in CryptoKey.cpp and SubtleCrypto.cpp
https://bugs.webkit.org/show_bug.cgi?id=175675
Reviewed by Jiewen Tan.
* crypto/CryptoKey.cpp:
(WebCore::CryptoKey::algorithm const):
* crypto/SubtleCrypto.cpp:
(WebCore::toCryptoKeyUsageBitmap):
(WebCore::toKeyData):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (220875 => 220876)
--- trunk/Source/WebCore/ChangeLog 2017-08-17 20:54:17 UTC (rev 220875)
+++ trunk/Source/WebCore/ChangeLog 2017-08-17 21:17:34 UTC (rev 220876)
@@ -1,3 +1,16 @@
+2017-08-17 Michael Catanzaro <mcatanz...@igalia.com>
+
+ -Wreturn-type warnings in CryptoKey.cpp and SubtleCrypto.cpp
+ https://bugs.webkit.org/show_bug.cgi?id=175675
+
+ Reviewed by Jiewen Tan.
+
+ * crypto/CryptoKey.cpp:
+ (WebCore::CryptoKey::algorithm const):
+ * crypto/SubtleCrypto.cpp:
+ (WebCore::toCryptoKeyUsageBitmap):
+ (WebCore::toKeyData):
+
2017-08-17 Andreas Kling <akl...@apple.com>
Disable CSS regions at compile time
Modified: trunk/Source/WebCore/crypto/CryptoKey.cpp (220875 => 220876)
--- trunk/Source/WebCore/crypto/CryptoKey.cpp 2017-08-17 20:54:17 UTC (rev 220875)
+++ trunk/Source/WebCore/crypto/CryptoKey.cpp 2017-08-17 21:17:34 UTC (rev 220876)
@@ -67,6 +67,8 @@
case KeyAlgorithmClass::Raw:
return downcast<RawKeyAlgorithm>(*algorithm).dictionary();
}
+
+ RELEASE_ASSERT_NOT_REACHED();
}
auto CryptoKey::usages() const -> Vector<CryptoKeyUsage>
Modified: trunk/Source/WebCore/crypto/SubtleCrypto.cpp (220875 => 220876)
--- trunk/Source/WebCore/crypto/SubtleCrypto.cpp 2017-08-17 20:54:17 UTC (rev 220875)
+++ trunk/Source/WebCore/crypto/SubtleCrypto.cpp 2017-08-17 21:17:34 UTC (rev 220876)
@@ -394,6 +394,8 @@
case CryptoKeyUsage::UnwrapKey:
return CryptoKeyUsageUnwrapKey;
}
+
+ RELEASE_ASSERT_NOT_REACHED();
}
static CryptoKeyUsageBitmap toCryptoKeyUsageBitmap(const Vector<CryptoKeyUsage>& usages)
@@ -476,6 +478,8 @@
}
);
}
+
+ RELEASE_ASSERT_NOT_REACHED();
}
static Vector<uint8_t> copyToVector(BufferSource&& data)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
