Title: [221141] trunk/LayoutTests/imported/w3c
Revision
221141
Author
commit-qu...@webkit.org
Date
2017-08-24 09:49:36 -0700 (Thu, 24 Aug 2017)

Log Message

WPT harness errors on leaks and iOS-sim EWS bots
https://bugs.webkit.org/show_bug.cgi?id=175269
<rdar://problem/33902404>

Patch by Youenn Fablet <you...@apple.com> on 2017-08-24
Reviewed by Alexey Proskuryakov.

Adding more logging to check whether the server is hanging or TCP connection is timing out.

* web-platform-tests/tools/wptserve/wptserve/response.py:
(Response.write_content):
(ResponseWriter.write):
(ResponseWriter.write_content_file):
* web-platform-tests/tools/wptserve/wptserve/server.py:
(WebTestRequestHandler.handle_one_request):

Modified Paths

Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (221140 => 221141)


--- trunk/LayoutTests/imported/w3c/ChangeLog	2017-08-24 16:42:50 UTC (rev 221140)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2017-08-24 16:49:36 UTC (rev 221141)
@@ -1,3 +1,20 @@
+2017-08-24  Youenn Fablet  <you...@apple.com>
+
+        WPT harness errors on leaks and iOS-sim EWS bots
+        https://bugs.webkit.org/show_bug.cgi?id=175269
+        <rdar://problem/33902404>
+
+        Reviewed by Alexey Proskuryakov.
+
+        Adding more logging to check whether the server is hanging or TCP connection is timing out.
+
+        * web-platform-tests/tools/wptserve/wptserve/response.py:
+        (Response.write_content):
+        (ResponseWriter.write):
+        (ResponseWriter.write_content_file):
+        * web-platform-tests/tools/wptserve/wptserve/server.py:
+        (WebTestRequestHandler.handle_one_request):
+
 2017-08-22  Youenn Fablet  <you...@apple.com>
 
         [Cache API] Add support for overwriting responses with put on an existing record

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/tools/wptserve/wptserve/response.py (221140 => 221141)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/tools/wptserve/wptserve/response.py	2017-08-24 16:42:50 UTC (rev 221140)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/tools/wptserve/wptserve/response.py	2017-08-24 16:49:36 UTC (rev 221141)
@@ -210,7 +210,7 @@
         if self.request.method != "HEAD" or self.send_body_for_head_request:
             for item in self.iter_content():
                 response_size += self.writer.write_content(item)
-        self.logger.debug("Wrote content of size %d for %s" % (response_size, self.request.request_path))
+        self.logger.debug(" %s - Wrote content of size %d for %s" % (datetime.now(), response_size, self.request.request_path))
 
     def write(self):
         """Write the whole response"""
@@ -447,7 +447,7 @@
             return len(buffer)
         except socket.error:
             # This can happen if the socket got closed by the remote end
-            self.logger.debug("Got exception when writing response " + traceback.format_exc())
+            self.logger.debug(" %s - Got exception when writing response for %s: %s" % (datetime.now(), self._response.request.request_path, traceback.format_exc()))
             pass
 
     def write_content_file(self, data):
@@ -463,7 +463,7 @@
             try:
                 self._wfile.write(buf)
             except socket.error:
-                self.logger.debug("Got exception when writing response " + traceback.format_exc())
+                self.logger.debug(" %s - Got exception when writing response for %s: %s" % (datetime.now(), self._response.request.request_path, traceback.format_exc()))
                 break
         data.close()
         return written_size

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/tools/wptserve/wptserve/server.py (221140 => 221141)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/tools/wptserve/wptserve/server.py	2017-08-24 16:42:50 UTC (rev 221140)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/tools/wptserve/wptserve/server.py	2017-08-24 16:49:36 UTC (rev 221141)
@@ -1,4 +1,5 @@
 import BaseHTTPServer
+from datetime import datetime
 import errno
 import os
 import socket
@@ -229,7 +230,7 @@
                 response.write()
                 return
 
-            self.logger.debug("%s %s" % (request.method, request.request_path))
+            self.logger.debug(" %s - %s %s" % (datetime.now(), request.method, request.request_path))
             handler = self.server.router.get_handler(request)
 
             # If the handler we used for the request had a non-default base path
@@ -261,7 +262,8 @@
                         err = []
                     err.append(traceback.format_exc())
                     response.set_error(500, "\n".join(err))
-            self.logger.debug("%i %s %s (%s) %i" % (response.status[0],
+            self.logger.debug(" %s - %i %s %s (%s) %i" % (datetime.now(),
+                                                    response.status[0],
                                                     request.method,
                                                     request.request_path,
                                                     request.headers.get('Referer'),
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to